Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy-loaded <style is="custom-style"> containing mixin not shimmed correctly #3734

Closed
1 of 6 tasks
kevinpschaaf opened this issue Jun 24, 2016 · 0 comments
Closed
1 of 6 tasks

Comments

@kevinpschaaf
Copy link
Member

kevinpschaaf commented Jun 24, 2016

Description

Fix for #3705 left one failing test on Firefox which has native CSS properties but not HTML imports. In this configuration when useNativeCSSProperties is used, the following test fails (not caught due to intermittent selenium failures on CI):
https://github.com/Polymer/polymer/blob/master/test/runner.html#L75

Failure happens because lazy-loaded import containing script that calls Polymer({...}) causes synchronous registration & upgrade of an already-parsed element before a <custom-style> it depends on upgrades. This violates the timing requirements of the useNativeCSSProperties optimization, which requires that custom property bags be defined before they're used.

Live Demo / Steps to Reproduce

Run test highlighted below on Firefox:
https://github.com/Polymer/polymer/blob/master/test/runner.html#L75

Browsers Affected

  • Chrome
  • Firefox
  • Edge
  • Safari 9
  • Safari 8
  • IE 11

Versions

  • Polymer: v1.5.0+master
sorvell pushed a commit that referenced this issue Jun 24, 2016
…time dependencies of scripts on previous elements in async imports.
kevinpschaaf added a commit that referenced this issue Jun 24, 2016
Fixes #3734: address HI/CE timing issue in importHref. Fixes upgrade …
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant