Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Getting the code" instructions are out of date/broken #369

Closed
radix opened this issue Dec 11, 2013 · 2 comments
Closed

"Getting the code" instructions are out of date/broken #369

radix opened this issue Dec 11, 2013 · 2 comments

Comments

@radix
Copy link

radix commented Dec 11, 2013

There are a few problems with the "Getting the code" page.

  • under "Test your environment" the prose mentions importing the "polymer-ajax" element, but actually the example is about polymer-ui-tabs.
  • the index.html includes a link to a 404. It refers to "bower_components/polymer-elements/polymer-ui-elements/polymer-ui-tabs.html". I think there are two things wrong:
    • The directory it refers to is "bower_components/polymer-elements/polymer-ui-elements", but that director doesn't exist. I assume it should be pointing to "polymer-ui-elements/".
    • The polymer-ui-elements directory does not contain polymer-ui-tabs.html, but it contains a polymer-ui-tabs directory which itself contains a polymer-ui-tabs.html.

Unfortunately even with these changes to the index.html it seems to still be doing something wrong for me, as evidenced here:

http://wordeology.com/radix/polytest/

So maybe my proposed fix is wrong or maybe there are some other bugs.
@ebidel
Copy link
Contributor

ebidel commented Dec 12, 2013

I'll take care of the first issue. The second is partly the docs having the wrong path to polymer-ui-tabs.html (this is fixed in github but not pushed on the site) and our fault with Bower.

The next release should fix the bower install issue. Until then, you can use:

bower install Polymer/polymer-ui-elements#master

index.html:

<html>
<head>
    <script src="bower_components/platform/platform.js"></script>
    <link rel="import" href="bower_components/polymer-ui-tabs/polymer-ui-tabs.html">
</head>
<body>
  <polymer-ui-tabs selected="0">
    <span>One</span><span>Two</span><span>Three</span><span>Four</span><span>Five</span>
  </polymer-ui-tabs>
</body>

I just tried this and it works like a charm.

In the next release, bower install Polymer/polymer-ui-elements will install all the elements a siblings. The polymer-elements/ and polymer-ui-elements/ directories will be meta folders.

cc @azakus

@ebidel
Copy link
Contributor

ebidel commented Dec 12, 2013

This should be fixed on the docs side.

@ebidel ebidel closed this as completed Dec 12, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@radix @ebidel