Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style sheets incorrectly added when updateStyles is called #3661

Closed
sorvell opened this issue May 18, 2016 · 0 comments
Closed

Style sheets incorrectly added when updateStyles is called #3661

sorvell opened this issue May 18, 2016 · 0 comments
Assignees
@sorvell
Labels
p0 source: hooli

Comments

@sorvell
Copy link
Contributor

sorvell commented May 18, 2016

When a custom-style is used to pass variable data to a nested element and updateStyles is called to update styling, a stylesheet can be incorrectly added to the document for every element that needs styling. Here is an example: http://output.jsbin.com/fapuduk. This occurs because the style caching system in the custom properties shim gets confused and incorrectly adds too many stylesheets.
@sorvell sorvell self-assigned this May 18, 2016
@sorvell sorvell added the p0 label May 18, 2016
sorvell pushed a commit that referenced this issue May 23, 2016
More efficient fix for #3661. Re-uses cached style element that needs…
63f91ae 
… to be replaced in the document rather than creating a new one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sorvell sorvell

Labels
p0 source: hooli
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sorvell