Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polymer-selected class is not applied to Polymer UI elements #364

Closed
warpech opened this issue Dec 9, 2013 · 4 comments
Closed

polymer-selected class is not applied to Polymer UI elements #364

warpech opened this issue Dec 9, 2013 · 4 comments

Comments

@warpech
Copy link

warpech commented Dec 9, 2013

Polymer version: head (installed using bower install polymer-ui-elements#master)
Chrome version: 33.0.1733.1 canary SyzyASan (Web Platform features enabled)

In <polymer-ui-tabs> and <polymer-ui-menu> demos, the currently selected item is not visually highlighted on screen. It turns out, that the class name polymer-selected is not added to the current element.

The bug is likely to be in https://github.com/Polymer/polymer-selector/blob/master/polymer-selector.html but I am not sure. Two tests fail in the polymer-selector test suite.

Steps to reproduce: Load demo polymer-ui-tabs\index.html and click on tabs. Observe that the current tab is not highlighted

@zoechi
Copy link

zoechi commented Dec 9, 2013

Hi Marcin,

we had troubles testing polymer_ui_elements there were always some polymer bugs that hit us (import, build).
Especially with polymer_ui_elements building upon imported polymer_elements like polymer-selector.

This has improved lately but we were busy revising the polymer_elements to support the new shadowDom CSS selectors. They are almost done.
The next task is to revise the polymer_ui_elements to support the new CSS selectors and test and improve their quality.
We hope we can provide proper working ui_elements soon.

Günter

@sorvell
Copy link
Contributor

sorvell commented Dec 9, 2013

It looks like there's a release problem in the platform repo. That will be fixed this week.

In the meantime, you can bower for the master versions to make sure you have the latest. For example,

bower install Polymer/polymer-ui-tabs#master

Note, we just fixed a version issue that was preventing polymer from grabbing the master platform.

If you have an existing bower installation, you can correct it by (1) deleting the platform component, (2) doing bower install Polymer/platform#master.

@warpech
Copy link
Author

warpech commented Dec 9, 2013

Awesome! A fresh installation from bower fixes the problem.

Thank you for such a quick response.

@frankiefu
Copy link
Member

verified with bower install Polymer/polymer-ui-elements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants