Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The custom style shim should stick the :root styles on html and not body #3503

Closed
notwaldorf opened this issue Mar 11, 2016 · 3 comments
Closed
Assignees
Labels

Comments

@notwaldorf
Copy link
Contributor

This is to be able to workaround the default-theme issue (PolymerElements/paper-styles#93) by allowing a user to override the :root styles present in default-theme.html with their own body {...} styles.

I thiiiiink this should work (currently doesn't): http://jsbin.com/revini/edit?html,output

(Sample JSBin using native custom properties: http://jsbin.com/vibadelure/edit?html,output)

@abdonrd
Copy link
Contributor

abdonrd commented Mar 11, 2016

@notwaldorf the example with the native custom properties works for me in Google Chrome v49. :)

@notwaldorf
Copy link
Contributor Author

@abdonrd Yes, but the equivalent one using the custom style shim doesn't, which is what this issue is about :)

@abdonrd
Copy link
Contributor

abdonrd commented Mar 11, 2016

@notwaldorf yes, I said because in the JSBin there are a note: Note: This only works on Chrome Canary, with the experimental features flag turned on in chrome://flags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants