Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS keyframes reference incorrectly renamed when prefixed by another keyframes set #3475

Closed
1 task done
keanulee opened this issue Feb 25, 2016 · 3 comments
Closed
1 task done

CSS keyframes reference incorrectly renamed when prefixed by another keyframes set #3475

keanulee opened this issue Feb 25, 2016 · 3 comments
Assignees
@dfreedm
Labels
1.x 2.x css p1

Comments

@keanulee
Copy link
Contributor

Description

If keyframes slide and slide-back are defined in a element, the slide-back keyframes declaration are renamed to @keyframes slide-back-x-el-0 {...}, but the animation property is incorrectly renamed to animation: slide-x-el-0-back.

Live Demo

https://jsbin.com/vidaxokeho/edit?html,output

Browsers Affected

  • Chrome

Versions

  • Polymer: v1.3.0
@keanulee
Copy link
Contributor Author

Thanks to @traviskaufman who found this in googlearchive/paper-linear-progress#1

@tjsavage tjsavage added the 1.x label Sep 8, 2016
@dfreedm dfreedm self-assigned this Jan 9, 2018
@dfreedm dfreedm mentioned this issue Jan 10, 2018
Closed
@dfreedm
Copy link
Member

dfreedm commented Jan 10, 2018

Yep, the animation name replacer is not quite smart enough. This issue also exists in Polymer 2 with ShadyCSS as webcomponents/shadycss#148

dfreedm added a commit that referenced this issue Jan 11, 2018
@dfreedm
Port keyframe name fix from ShadyCSS
99d0a60 
Fixes #3475
@dfreedm dfreedm mentioned this issue Jan 11, 2018
Merged
dfreedm added a commit that referenced this issue Jan 24, 2018
@dfreedm
Port keyframe name fix from ShadyCSS (#5038)
9721433 
* Port keyframe name fix from ShadyCSS

Fixes #3475

* animate border instead

* Port Edge 16 test fixes from 2.x
@TimvdLippe
Copy link
Contributor

This was fixed in #5038

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dfreedm dfreedm

Labels
1.x 2.x css p1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dfreedm @tjsavage @keanulee @TimvdLippe