Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polymer.dom element accessors can be incorrect when an element has no logical nodes #3308

Closed
sorvell opened this issue Jan 19, 2016 · 0 comments
Closed

Polymer.dom element accessors can be incorrect when an element has no logical nodes #3308

sorvell opened this issue Jan 19, 2016 · 0 comments
Assignees
@sorvell
Labels
p1

Comments

@sorvell
Copy link
Contributor

sorvell commented Jan 19, 2016

Consider for example this case: http://jsbin.com/jitiqu/edit?html,output.

Polymer is incorrectly falling back to the element's native firstChild when the logical firstChild is false-y. We must instead do a more explicit undefined check.
@sorvell sorvell added the p1 label Jan 19, 2016
@sorvell sorvell self-assigned this Jan 19, 2016
kevinpschaaf added a commit that referenced this issue Jan 19, 2016
@kevinpschaaf
Merge pull request #3309 from Polymer/fix-3308
b4fed21 
Fixes #3308. Use an explicit undefined check to test if logical tree …
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sorvell sorvell

Labels
p1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sorvell