Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS: only add [is=..] selector if element is type-extension #320

Closed
ebidel opened this issue Oct 16, 2013 · 2 comments
Closed

CSS: only add [is=..] selector if element is type-extension #320

ebidel opened this issue Oct 16, 2013 · 2 comments

Comments

@ebidel
Copy link
Contributor

ebidel commented Oct 16, 2013

Blink has recalc style/paint issues with complex attribute selectors...

In Chrome stable on chromestatus.com, I see large repaints on scrolling. The culprit is from a complex attribute selector that the styling polyfill produces:

chromedash-metadata ul li[selected],
[is=chromedash-metadata] ul li[selected] {
  font-weight: 600;
  color: rgb(54, 101, 151);
}

Note: turning off the font-weight:600; alone speeds up the scrolling.

It would be killer if the polyfill only added ([is=chromedash-metadata]...)-type selectors if the element is actually a type-extension. This will be an easy
perf boost for users.

@sorvell
Copy link
Contributor

sorvell commented Oct 21, 2013

Should be addressed as of googlearchive/platform@4e83085.

@sorvell sorvell closed this as completed Oct 21, 2013
@ebidel
Copy link
Contributor Author

ebidel commented Oct 22, 2013

👍 Actual commit is googlearchive/platform@515c583

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants