Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When element is detached and reattached, its dom-ifs are torn down and restamped #3125

Closed
rictic opened this issue Dec 2, 2015 · 1 comment
Closed

When element is detached and reattached, its dom-ifs are torn down and restamped #3125

rictic opened this issue Dec 2, 2015 · 1 comment
Assignees
@kevinpschaaf
Labels
performance

Comments

@rictic
Copy link
Contributor

rictic commented Dec 2, 2015

This invalidates references to the dom inside the dom-if.

e.g. http://jsbin.com/vicowoxohi/1/edit?html,console,output -- the timer changes updates on restamp
@kevinpschaaf
Copy link
Member

Will be fixed PR in #3160.

JSBin repro using PR branch: http://jsbin.com/fuyuka/edit?html,console,output

sorvell pushed a commit that referenced this issue Dec 7, 2015
Merge pull request #3160 from Polymer/3125-kschaaf-move-domif
bab847a 
Ensure dom-if in host does not restamp when host detaches. Fixes #3125.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinpschaaf kevinpschaaf

Labels
performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rictic @ebidel @kevinpschaaf