Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error when creating an element without a hyphenated name #303

Closed
wibblymat opened this issue Oct 2, 2013 · 3 comments
Closed

Better error when creating an element without a hyphenated name #303

wibblymat opened this issue Oct 2, 2013 · 3 comments
Assignees

Comments

@wibblymat
Copy link

If you run the following example, you get an error because the custom element does not have a hyphen in the name.

index.html

<html>
<script src="polymer-v0.0.20130912/polymer-v0.0.20130912.min.js"></script>
<link rel="import" href="element.html">
<element/>

element.html

<polymer-element name="element">
    <template>
    </template>
    <script>Polymer('element');</script>
</polymer-element>

However, the error has no message, so if you do this by accident it is difficult to work out what has gone wrong.

Error message

@ghost ghost assigned sorvell Oct 2, 2013
@dfreedm
Copy link
Member

dfreedm commented Oct 3, 2013

The error message does have a useful message as of googlearchive/CustomElements@315f9a4.

It looks like the build ate the nice message for some reason.
From my initial testing, it seems to have been fixed it in trunk.

Should be fixed in today's release version.

@ghost ghost assigned dfreedm Oct 8, 2013
@KubaBest
Copy link

Currently, creating custom element without hyphen in the name ends with Uncaught Error:

test_log

Which I think is enough descriptive to understand what we have done wrong, so an issue can be closed now.

@dfreedm
Copy link
Member

dfreedm commented Jul 16, 2014

Agreed, thx

@dfreedm dfreedm closed this as completed Jul 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants