Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polymer tests failing with Object.observe enabled #302

Closed
sorvell opened this issue Oct 2, 2013 · 2 comments
Closed

Polymer tests failing with Object.observe enabled #302

sorvell opened this issue Oct 2, 2013 · 2 comments
Assignees
@sorvell

Comments

@sorvell
Copy link
Contributor

sorvell commented Oct 2, 2013

The bindModel and prop-attr-reflection tests are failing with Object.observe on. This appears to be a test timing issue.
@ghost ghost assigned sorvell Oct 2, 2013
@sorvell
Copy link
Contributor Author

sorvell commented Oct 2, 2013

The issue is that we cannot rely on this construction for ensuring data changes are 'done':

Platform.flush();
Platform.endOfMicrotask(...);

Instead, we need another asynchrony like requestAnimationFrame/setTimeout.

@sorvell
Copy link
Contributor Author

sorvell commented Oct 2, 2013

Fixed via e035cf0

@sorvell sorvell closed this as completed Oct 2, 2013
sorvell added a commit to googlearchive/polymer-dev that referenced this issue Nov 15, 2013
@sorvell
Make tests pass under presence of O.o; fixes Polymer/polymer#302.
e035cf0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sorvell sorvell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sorvell