Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stricter key & path tests may cause breakage with non-defensive code #3018

Closed
kevinpschaaf opened this issue Nov 18, 2015 · 0 comments
Closed

Stricter key & path tests may cause breakage with non-defensive code #3018

kevinpschaaf opened this issue Nov 18, 2015 · 0 comments
Assignees
@kevinpschaaf
Labels
p0

Comments

@kevinpschaaf
Copy link
Member

Recent changes caused what used to gracefully fail on unexpected input now inadvertently throw, which could cause unexpected breakage:

  • Polymer.Collection.getItem(key) with an undefined key now throws where it didn't previously
  • Polymer.Base.notifyPath(path, value) where the path cannot be dereferenced to the leaf now throws where it didn't previously
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinpschaaf kevinpschaaf

Labels
p0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kevinpschaaf