Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bindings in nested templates with named scopes fail to update correctly after initial population #285

Closed
heatherdouglass opened this issue Sep 20, 2013 · 3 comments

Comments

@heatherdouglass
Copy link

I ran into this bug while doing some testing with nested repeated templates. Here is an example.

http://jsbin.com/UJAlICI/3/edit?html,output

I don't know if it's the right fix but I was able to fix this by moving line 1015 in TemplateBinding.js var delegate = template.bindingDelegate; out of the if loop.

@sjmiles
Copy link
Contributor

sjmiles commented Sep 20, 2013

@rafaelw

@sorvell
Copy link
Contributor

sorvell commented Sep 24, 2013

Here's another slightly simpler example of the same problem:

http://jsbin.com/odoJEPe/1/edit

@ghost ghost assigned rafaelw and ebidel Sep 25, 2013
@rafaelw
Copy link
Contributor

rafaelw commented Sep 25, 2013

Excellent bug and correct diagnosis! Thanks so much, @heatherdouglass.

Fixed here: googlearchive/TemplateBinding@dbbd7e7

@rafaelw rafaelw closed this as completed Sep 25, 2013
jmesserly pushed a commit to jmesserly/TemplateBinding that referenced this issue Nov 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants