Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing controllerStyles and requiring explicitly adding stylesheets #272

Closed
sorvell opened this issue Sep 9, 2013 · 2 comments
Assignees

Comments

@sorvell
Copy link
Contributor

sorvell commented Sep 9, 2013

This feature was added initially as a styling polyfill stopgap. It's been used now in a few polymer-ui-elements. In the interest of simplicity, it may be better to remove the feature and to simply require stylesheets to be added where needed.

@ghost ghost assigned frankiefu Sep 9, 2013
@sorvell
Copy link
Contributor Author

sorvell commented Sep 9, 2013

Some examples include polymer-overlay, polymer-collapse, polymer-flex-layout. These elements provide behavior which can be applied to another target element. They want to control the styling of the target element and they do so now by modifying the set of css in the target's scope and setting selectors on the target.

@ghost ghost assigned ebidel and frankiefu Sep 25, 2013
@frankiefu
Copy link
Member

We no longer use installControllerStyles in those elements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants