Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dom-module forces CustomElements.upgradeAll each time an element without a dom-module is registered #2708

Closed
kevinpschaaf opened this issue Nov 9, 2015 · 0 comments
Closed

dom-module forces CustomElements.upgradeAll each time an element without a dom-module is registered #2708

kevinpschaaf opened this issue Nov 9, 2015 · 0 comments
Assignees
@sorvell
Labels
p1

Comments

@kevinpschaaf
Copy link
Member

Code in dom-module added to ensure non-upgraded dom-modules can be found by registering elements has an undesired side-effect of doing potentially expensive tree walks for each element registered that intentionally has no dom-module. Issue is to consider avoiding these expensive tree-walks somehow.
@kevinpschaaf kevinpschaaf added the p1 label Nov 9, 2015
@kevinpschaaf kevinpschaaf mentioned this issue Nov 10, 2015
Closed
sorvell pushed a commit that referenced this issue Nov 10, 2015
Explicitly making an element's _template falsy is now considered an…
b905a37 
… allowable setting. This means the element stamps no content, doesn't collect any styles, and avoids looking up a dom-module. This helps address #2708 and the 5 elements Polymer registers that have no template have been set with `_template: null`.
@kevinpschaaf kevinpschaaf mentioned this issue Nov 14, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sorvell sorvell

Labels
p1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sorvell @kevinpschaaf