Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dom-if throws if detached before instance is stamped #2685

Closed
kevinpschaaf opened this issue Nov 5, 2015 · 1 comment
Closed

dom-if throws if detached before instance is stamped #2685

kevinpschaaf opened this issue Nov 5, 2015 · 1 comment
Assignees
@kevinpschaaf
Labels
p0

Comments

@kevinpschaaf
Copy link
Member

Repro: http://jsbin.com/xomime/edit?html,console,output

When dom-if is attached, it queues an async task to append its template content to its parent. If before the quited task runs it then gets detached, it has no parentNode and attempting to append throws.
@kevinpschaaf kevinpschaaf added the p0 label Nov 5, 2015
@kevinpschaaf kevinpschaaf self-assigned this Nov 5, 2015
@kevinpschaaf
Copy link
Member Author

Resolved in PR #2696

sorvell pushed a commit that referenced this issue Nov 6, 2015
Merge pull request #2696 from Polymer/2685-kschaaf-detached-domif
07d39a1 
Ensure parent node exists when stamping. Fixes #2685.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinpschaaf kevinpschaaf

Labels
p0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kevinpschaaf