Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom properties with 'var' in the value aren't applied #2660

Closed
robdodson opened this issue Oct 31, 2015 · 2 comments
Closed

Custom properties with 'var' in the value aren't applied #2660

robdodson opened this issue Oct 31, 2015 · 2 comments
Labels
css

Comments

@robdodson
Copy link
Contributor

ex: --my-font: 'Varela Round' will not be applied because of the word Var in Varela. @sorvell 😢
@ebidel ebidel added the css label Oct 31, 2015
@ebidel
Copy link
Contributor

ebidel commented Oct 31, 2015

From http://stackoverflow.com/questions/33445674/how-to-get-google-fonts-to-work-in-polymer-1-1-web-component

TimvdLippe added a commit to TimvdLippe/polymer that referenced this issue Oct 31, 2015
@TimvdLippe
Fix parsing of custom properties with 'var' in value
7b0666e 
Fixes Polymer#2660
TimvdLippe added a commit to TimvdLippe/polymer that referenced this issue Oct 31, 2015
@TimvdLippe
Fix parsing of custom properties with 'var' in value
7356c6f 
Fixes Polymer#2660
TimvdLippe added a commit to TimvdLippe/polymer that referenced this issue Oct 31, 2015
@TimvdLippe
Fix parsing of custom properties with 'var' in value
054a60c 
Fixes Polymer#2660
@TimvdLippe TimvdLippe mentioned this issue Oct 31, 2015
Merged
TimvdLippe added a commit to TimvdLippe/polymer that referenced this issue Oct 31, 2015
@TimvdLippe
Fix parsing of custom properties with 'var' in value
e533ec1 
Fixes Polymer#2660
TimvdLippe added a commit to TimvdLippe/polymer that referenced this issue Oct 31, 2015
@TimvdLippe
Fix parsing of custom properties with 'var' in value
61dc7bd 
Fixes Polymer#2660
TimvdLippe added a commit to TimvdLippe/polymer that referenced this issue Oct 31, 2015
@TimvdLippe
Fix parsing of custom properties with 'var' in value
dde18d2 
Fixes Polymer#2660
@TimvdLippe
Copy link
Contributor

Well that was an evening of edge-cases and testing, but I think I cracked it now. #2662 shows the reported fixed behaviour.

The multiple mentions are due to FireFox and Chrome parsing css selectors differently, but unrelated to the actual purpose of testing. Sorry for the spam.

TimvdLippe added a commit to TimvdLippe/polymer that referenced this issue Oct 31, 2015
@TimvdLippe
Fix parsing of custom properties with 'var' in value
61abfbd 
Fixes Polymer#2660
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ebidel @robdodson @TimvdLippe