Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using minified version on polymer, images of the button don't show in the ui-toolbar example #251

Closed
dinhvh opened this issue Aug 22, 2013 · 5 comments

Comments

@dinhvh
Copy link

dinhvh commented Aug 22, 2013

Using non-minified version:
plain

Using minified version:
minified

Images disappeared in the minified version.

Here's the diff of polymer-ui-toolbar/index.html.
I used the minified version (polymer.min.js) available here:
https://github.com/Polymer/polymer-all/releases/download/v0.0.20130816/polymer-all-v0.0.20130816.zip

diff --git a/polymer-ui-toolbar/index.html b/polymer-ui-toolbar/index.html
index 7f5fa35..eb8ba0a 100644
--- a/polymer-ui-toolbar/index.html
+++ b/polymer-ui-toolbar/index.html
@@ -11,7 +11,8 @@ license that can be found in the LICENSE file.
     <meta charset="utf-8">
     <meta http-equiv="X-UA-Compatible" content="IE=edge,chrome=1">
     <!-- load toolkit -->
-    <script src="../../polymer/polymer.js"></script>
+    <!-- <script src="../../polymer/polymer.js"></script> -->
+    <script src="polymer.min.js"></script>
     <!-- import elements-->
     <link rel="import" href="polymer-ui-toolbar.html">
     <link rel="import" href="../polymer-ui-icon-button/polymer-ui-icon-button.html">
@sorvell
Copy link
Contributor

sorvell commented Aug 22, 2013

I can't repro the problem in the polymer-ui-toolbar example (applying the diff you noted). Can you give some additional info? Thanks.

@dinhvh
Copy link
Author

dinhvh commented Aug 22, 2013

I can reproduce it on Chrome dev and Chrome canary.

@dfreedm
Copy link
Member

dfreedm commented Aug 26, 2013

This should be fixed with googlearchive/labs@7365ae8 and 5ed386b

@dinhvh
Copy link
Author

dinhvh commented Aug 27, 2013

Let me know when I can use the "Download Polymer" code to test it.
#261.

@dinhvh
Copy link
Author

dinhvh commented Aug 28, 2013

Tested with latest version. It's working now!

@dinhvh dinhvh closed this as completed Aug 28, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants