Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore compatibility with Chrome 39's registerElement #2403

Closed
sorvell opened this issue Sep 3, 2015 · 0 comments
Closed

Restore compatibility with Chrome 39's registerElement #2403

sorvell opened this issue Sep 3, 2015 · 0 comments
Assignees
@sorvell
Labels
p0

Comments

@sorvell
Copy link
Contributor

sorvell commented Sep 3, 2015

Although Polymer doesn't have official support for old Chrome versions, we've had a specific request to make a small change that allows Polymer to maintain compatibility with Chrome 39's implementation of document.registerElement.

We recently made a small change that can cause an undefined value in document.registerElement's options argument's extends property. We can trivially correct this by only setting extends if the user has requested to extend an element.
@sorvell sorvell added the p0 label Sep 3, 2015
@sorvell sorvell self-assigned this Sep 3, 2015
@sorvell sorvell closed this as completed in a6694b7 Sep 3, 2015
kevinpschaaf added a commit that referenced this issue Sep 3, 2015
@kevinpschaaf
Merge pull request #2404 from Polymer/fix-2403
649d24f 
Fixes #2403
MartinMoizard pushed a commit to MartinMoizard/polymer that referenced this issue Sep 8, 2015
Fixes Polymer#2403
cd75943
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sorvell sorvell

Labels
p0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sorvell