Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML imports fail when url params contain '/' characters #238

Closed
JoernT opened this issue Aug 14, 2013 · 7 comments
Closed

HTML imports fail when url params contain '/' characters #238

JoernT opened this issue Aug 14, 2013 · 7 comments

Comments

@JoernT
Copy link

JoernT commented Aug 14, 2013

We call a page with url params where some of them contain slashes. When url is encoded everything's fine but if these are not escaped the loading seems to go nuts.

@JoernT
Copy link
Author

JoernT commented Aug 14, 2013

Should have mentioned the version: polymer-build-v0.0.20130801

@dfreedm
Copy link
Member

dfreedm commented Aug 16, 2013

There's been two stable releases since then: now at 0.0.20130816. Is this problem still an issue?

@dfreedm
Copy link
Member

dfreedm commented Aug 16, 2013

Taking a dive into the HTMLImports code, this bug has to do with how we "compress" urls to remove instances of "..". The query string is treated as part of the url path when it should not be.

@totrash
Copy link

totrash commented Aug 18, 2013

The last stables (0.0.20130816, 0.0.20130815) doesnt work at all ...
Because of missing files like:

polymer-all/observe-js/src/observe.js
polymer-all/NodeBind/src/NodeBind.js
polymer-all/TemplateBinding/src/TemplateBinding.js
polymer-all/polymer-expressions/src/polymer-expressions.js
polymer-all/polymer-expressions/third_party/esprima/esprima.js

This cause following errors:

Uncaught ReferenceError: PolymerExpressions is not defined mdv.js:14
Uncaught ReferenceError: PathObserver is not defined

The stable package doesn`t have those files at all. Only empty folder like polymer-all/observe-js/

@dfreedm
Copy link
Member

dfreedm commented Aug 18, 2013

@totrash sigh, you're right. The submodule didn't get expanded for those zips. This should really be filed as it's own bug though.

@dfreedm
Copy link
Member

dfreedm commented Aug 18, 2013

@totrash Filed Polymer/polymer-all#12 to track, make sure this broken build doesn't happen again!

@dfreedm
Copy link
Member

dfreedm commented Sep 3, 2013

@JoernT closed by googlearchive/HTMLImports@cd35b53

@dfreedm dfreedm closed this as completed Sep 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants