Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf regression in polyfill - 20130808 release #236

Closed
ebidel opened this issue Aug 12, 2013 · 1 comment
Closed

Perf regression in polyfill - 20130808 release #236

ebidel opened this issue Aug 12, 2013 · 1 comment

Comments

@ebidel
Copy link
Contributor

ebidel commented Aug 12, 2013

In Chrome stable (e.g. polyfill), toggle a feature. There's a 1-2 delay seconds under the latest release:
v20130808 latest: http://20130808.cr-status.appspot.com/features
v20130801 release: http://www.chromestatus.com/features

I did some experimenting and found that calling Platform.flush() helps
on mobile view (where the CSS transitions are disabled). There's no delay opening
a panel, but the tradeoff is that the color status flash in.

openChanged: function() {
  this.open ? this.classList.add('open') : this.classList.remove('open');
},
toggle: function(e, details, sender) {
   if (Platform.flags.shadow) {
     this.asyncMethod(function() {
       this.open = !this.open;
       Platform.flush(); 
     });
   } else {
     this.open = !this.open;
  }
}

Could all of this be from the new property reflection to attributes?

@ebidel
Copy link
Contributor Author

ebidel commented Sep 9, 2013

Closing this. It's been addressed

@ebidel ebidel closed this as completed Sep 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant