Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

custom-style should generate a better error when its include is not found #2356

Closed
sorvell opened this issue Aug 24, 2015 · 0 comments
Closed

custom-style should generate a better error when its include is not found #2356

sorvell opened this issue Aug 24, 2015 · 0 comments
Assignees
@sorvell
Labels
p1

Comments

@sorvell
Copy link
Contributor

sorvell commented Aug 24, 2015

At the moment, this generates an arcane error. Instead, it should warn that the include name cannot be found.
@sorvell sorvell added the p1 label Aug 24, 2015
@sorvell sorvell self-assigned this Aug 24, 2015
sorvell pushed a commit that referenced this issue Aug 26, 2015
Fixes #2356: issue a warning and don't throw an exception when a styl…
a16ada1 
…e include cannot be found.

Fixes #2357: include data now comes before any textContent in a style element.
@sorvell sorvell mentioned this issue Aug 26, 2015
Merged
frankiefu added a commit that referenced this issue Aug 26, 2015
@frankiefu
Merge pull request #2375 from Polymer/fix-2356,2357
e00bd6a 
Fixes #2356, #2357
MartinMoizard pushed a commit to MartinMoizard/polymer that referenced this issue Sep 8, 2015
Fixes Polymer#2356: issue a warning and don't throw an exception when…
6365cf6 
… a style include cannot be found.

Fixes Polymer#2357: include data now comes before any textContent in a style element.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sorvell sorvell

Labels
p1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sorvell