Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shady distribution failure when a dom-repeat is moved #2323

Closed
sorvell opened this issue Aug 20, 2015 · 1 comment
Closed

Shady distribution failure when a dom-repeat is moved #2323

sorvell opened this issue Aug 20, 2015 · 1 comment
Assignees
@sorvell
Labels
p1

Comments

@sorvell
Copy link
Contributor

sorvell commented Aug 20, 2015

See: http://jsbin.com/lonuhi/edit?html,output

This occurs because when an element is added without removal, its composed data is incorrectly removed from its light parent rather than its composed parent.

At https://github.com/Polymer/polymer/blob/master/src/lib/dom-api.html#L292, node._composedParent should be used.
@sorvell sorvell added the p1 label Aug 20, 2015
@sorvell sorvell self-assigned this Aug 20, 2015
sorvell pushed a commit that referenced this issue Aug 20, 2015
Fixes #2311, #2323: when elements are removed from their previous pos…
3d93116 
…ition when they are added elsewhere, make sure to remove them from composed, not logical parent.
frankiefu added a commit that referenced this issue Aug 20, 2015
@frankiefu
Merge pull request #2331 from Polymer/fix-2311,2323
aa3b9cc 
Fixes #2311, #2323: when elements are removed from their previous pos…
@sorvell
Copy link
Contributor Author

sorvell commented Aug 20, 2015

Fixed via aa3b9cc

@sorvell sorvell closed this as completed Aug 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sorvell sorvell

Labels
p1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sorvell