Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Binding expressions should be able to start with non-word characters like $ #2107

Closed
sorvell opened this issue Jul 18, 2015 · 0 comments
Closed

Binding expressions should be able to start with non-word characters like $ #2107

sorvell opened this issue Jul 18, 2015 · 0 comments
Assignees
@sorvell
Labels
p1

Comments

@sorvell
Copy link
Contributor

sorvell commented Jul 18, 2015

Here's an example: $I(foo, baz, bar)

The parser for expressions currently looks for non-word characters so it misses expressions that start with $. Since it's valid to write javascript functions like this, it should be supported.
@sorvell sorvell added the p1 label Jul 18, 2015
@sorvell sorvell self-assigned this Jul 18, 2015
kevinpschaaf added a commit that referenced this issue Jul 24, 2015
@kevinpschaaf
Merge pull request #2109 from Polymer/fix-2107
7d72d7c 
Fix #2107: improve binding expression parser to match valid javascrip…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sorvell sorvell

Labels
p1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sorvell