template is="dom-if" throws if template contains comment

[ebidel]

Given an dom-if template with a comment:

<template is="dom-if" if="{{fetchingMail}}">
  <!-- div class="layout vertical center-center" style="height:100%">
    <paper-spinner active></paper-spinner>
  </div -->
  <div id="refresh" class="fit layout vertical center-center">
    ...
  </div>
</div>
</template>

Polymer 1.0.5 throws an error trying to display: none it:

[masonlouchart]

I worked a little bit on the dom-if yesterday. This error happens if the dom-if contains a node without style property (like text_node, comment_node). I'll update my pull request for this case. Please, see the PR #2027 .

[wesleycho]

Here is a simple reproduction (code here).

The _showHideChildren method in dom-if needs to correctly handle comment nodes - what would the desired behavior be for this situation?

I can file a PR if you like given guidance on the proper implementation here.

Edit: Oh, someone worked on this from the time I went to sleep heh.

[kevinpschaaf]

This is a dupe of #1786.

This PR will be merged this week: #1992

[masonlouchart]

Should I make a new PR to keep only the first commit of the PR #2027 who solves the issue #1725 ?

Edit:
Or maybe you could keep the PR #2027 who contains also the same fix as yours ( #1992 ) ?

Edit2:
I have got the answer, yours has been merged few minutes ago. Sorry for the flood of comments. I'll make a new PR for the issue #1725 .