-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
array-selector doesn't work with multi
unless toggle
is specified
#1810
Comments
I think the |
multi
unless toggle
is specified
Changed this title to better describe the bug you're seeing in #1. Here's a jsbin using a fixed branch: http://jsbin.com/guxijoyodi/1/edit As you can see, select works properly without toggle, the only difference is that clicking the button a second time doesn't deselect the actor. Not sure I really understand the questions in #2, but it seems like part of the problem is that the use cases for |
@arthurevans The renamed title is accurate of the original meaning of the article, & the fixed branch has indeed the expected behavior I was expecting. As I was originally expecting, select now works properly without toggle. Regarding #2, I'd say you're spot-on, more examples or explanation of the |
Fix incorrect test for `toggle`. Fixes #1810.
Problem 1
In the section regarding
array-selector
in the developer docs, it is unexplained the importance & relevance oftoggle
being set for the code snippet provided:If
toggle
is removed, the element's behavior doesn't work as expected. I & many perhaps thought the removal oftoggle
means that that a selection canbe added to{{selected}}
but not removed. Unfortunately, that isn't the case. This seems like a bug.An example of this can be found here; remove toggle & see what happens.
Problem 2
Another problem beyond the problem(s) above is showing
this.$.selector
.select being used outside of an event handler. It was obvious to me inside things like theready
callback but there may be value if it was demonstrated the following ways for developers:filter
&/orsort
selected
contents when the element is detached{{selected}}
being used outside the app with an outside listener by the forsight of the code defining the property name put inside theselected
attribute being available to the outside world with an event listnerThe text was updated successfully, but these errors were encountered: