Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider optimizing propertyForAttribute #181

Closed
sorvell opened this issue Jun 13, 2013 · 1 comment
Closed

Consider optimizing propertyForAttribute #181

sorvell opened this issue Jun 13, 2013 · 1 comment

Comments

@sorvell
Copy link
Contributor

sorvell commented Jun 13, 2013

Each time propertyForAttribute is called, it does work to create a lowercase list of published properties. This could probably be done once and memoized.

@sjmiles
Copy link
Contributor

sjmiles commented Jun 13, 2013

As it is now the list of properties could mutate at any time and there is no problem. For that reason, this was done this way on purpose, pending some actual data that it's a performance problem.

@sorvell sorvell closed this as completed Jun 17, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants