Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style shim only converts a single ::shadow or /deep/ in a selector #1809

Closed
jyasskin opened this issue Jun 9, 2015 · 1 comment
Closed
Assignees
Labels

Comments

@jyasskin
Copy link

jyasskin commented Jun 9, 2015

See http://plnkr.co/edit/DCLtFWbGN0RrIDVSikrB?p=preview for an example. Only the first ::shadow or /deep/ is getting removed from the style rules. On Chrome (with native support for /deep/, that means the background color gets stuck after the first nesting level. On Firefox, both the foreground and background colors get stuck there.

    li { color: red; }
    li ol::shadow li { color: blue; }
    li ol::shadow li ol::shadow li { color: green; }
    li { background-color: lightblue; }
    li /deep/ li { background-color: lightgreen; }
    li /deep/ li /deep/ li { background-color: pink; }

in the custom element stylesheet becomes the following in the document stylesheet:

li.dom-recurse {  color: red;}
li.dom-recurse ol.dom-recurse  li {  color: blue;}
li.dom-recurse ol.dom-recurse  li ol::shadow li {  color: green;}
li.dom-recurse {  background-color: lightblue;}
li.dom-recurse   li {  background-color: lightgreen;}
li.dom-recurse   li /deep/ li {  background-color: pink;}
@sorvell sorvell added the p2 label Jun 10, 2015
@sorvell sorvell self-assigned this Jun 10, 2015
@sorvell sorvell added p1 and removed p2 labels Jun 12, 2015
sorvell pushed a commit that referenced this issue Jun 12, 2015
Fixes #1807
Fixes #1809
@sorvell
Copy link
Contributor

sorvell commented Jun 12, 2015

Please note that ::shadow and /deep/ are being removed from the cross scope styling spec. They may become deprecated in Chrome soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants