Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Element templates are stamped into shadowRoot with unbound values #153

Closed
sorvell opened this issue May 22, 2013 · 2 comments
Closed

Element templates are stamped into shadowRoot with unbound values #153

sorvell opened this issue May 22, 2013 · 2 comments
Assignees
@sorvell
Labels
review then close

Comments

@sorvell
Copy link
Contributor

sorvell commented May 22, 2013

This results in undesired settings to attributes. If, for example, there's a binding to an img's src attribute, a network request is made that will typically cause an unintended 404.

When a custom element is upgraded, the shadowRoot is created and the template's contents are stamped into it. After this, bindings are setup.
@ghost ghost assigned sjmiles May 22, 2013
@sorvell
Copy link
Contributor Author

sorvell commented May 22, 2013

See this thread for more info:

https://groups.google.com/forum/?fromgroups#!topic/polymer-dev/3ads0i95xlg

@ebidel
Copy link
Contributor

ebidel commented May 22, 2013

Test: http://jsbin.com/ekotiv/1/edit

sorvell pushed a commit that referenced this issue May 22, 2013
Fix for #153. The process of putting template content into shadowRoot…
bd0bd6e 
… is now:

1. create instance of template content
2. bind it
3. append to shadowRoot

Previously it was 1, 3, 2 which could lead to attribute values having values with {{}} in them while being in dom. This can create issues like images loading with incorrect urls.
@ghost ghost assigned sorvell May 22, 2013
@sorvell sorvell closed this as completed Jun 12, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sorvell sorvell

Labels
review then close
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sorvell @sjmiles @ebidel