Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.8] hostAttributes should respect user-provided defaults #1458

Closed
cdata opened this issue Apr 28, 2015 · 2 comments
Closed

[0.8] hostAttributes should respect user-provided defaults #1458

cdata opened this issue Apr 28, 2015 · 2 comments
Assignees
@sorvell
Labels
0.8 api-feedback enhancement

Comments

@cdata
Copy link
Contributor

cdata commented Apr 28, 2015

First, I would like to clarify that this is a proposal for API change and not a bug report. AFAIK the existing API is working as advertised.

Currently, attribute values specified in hostAttributes will automatically override user-specified values for those attributes. I propose that this should be changed, so that attributes specified in hostAttributes will respect and defer to user-specified values.

One of the more tempting uses of hostAttributes is to set default ARIA attributes like role, and / or related ARIA states and properties. However, hostAttributes is a bad choice for this because you generally want to respect user-provided values for those same attributes.

For anecdotal evidence that the proposed behavior is preferable to the current behavior, please refer to the discussion here: PolymerElements/paper-toggle-button#1 (comment)
@cdata cdata mentioned this issue Apr 28, 2015
Merged
@sorvell
Copy link
Contributor

sorvell commented Apr 28, 2015

This sounds reasonable. Will make it so.

@sorvell sorvell self-assigned this Apr 28, 2015
@sorvell
Copy link
Contributor

sorvell commented May 1, 2015

Fixed via 85cc721

@sorvell sorvell closed this as completed May 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sorvell sorvell

Labels
0.8 api-feedback enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sorvell @cdata