Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.8] attached is called at different points in lifecycle for ShadeyDOM vs ShadowDOM #1285

Closed
cdata opened this issue Mar 11, 2015 · 0 comments
Closed

[0.8] attached is called at different points in lifecycle for ShadeyDOM vs ShadowDOM #1285

cdata opened this issue Mar 11, 2015 · 0 comments
Labels
0.8

Comments

@cdata
Copy link
Contributor

cdata commented Mar 11, 2015

When an element is created with ShadowDOM enabled, attached is called before properties are configured on the element instance. If ShadeyDOM is used, attached is called after properties are configured on the element instance.

This should probably be normalized. My vote would be that the ShadeyDOM lifecycle is used, because it allows attached handlers to assume that the instance's properties are configured and available. However, I understand this might be difficult to achieve.
@cdata cdata added the 0.8 label Mar 11, 2015
sorvell added a commit that referenced this issue Mar 14, 2015
@sorvell
Fixes #1285
a0f51e6
@sorvell sorvell closed this as completed Mar 14, 2015
cdata pushed a commit to googlearchive/core-focusable that referenced this issue Mar 16, 2015
Remove workaround for Polymer/polymer#1285
29783ba
sorvell pushed a commit that referenced this issue Mar 16, 2015
Ensures attached happens after ready (better fix for #1285); ensures …
86b37c1 
…elements distribute prior to configuration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0.8
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sorvell @cdata