Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.8-preview] Bespoke element constructors #1151

Closed
peterwmwong opened this issue Jan 31, 2015 · 1 comment
Closed

[0.8-preview] Bespoke element constructors #1151

peterwmwong opened this issue Jan 31, 2015 · 1 comment
Labels
0.8

Comments

@peterwmwong
Copy link
Contributor

http://jsbin.com/puvaze/3/edit?html,output

Bespoke element constructors, mentioned in the PRIMER.md, don't seem to work because this doesn't seem to be correctly bound. As such this.is is incorrect and nothing good gets passed to document.createElement() :(
@peterwmwong peterwmwong mentioned this issue Jan 31, 2015
Closed
@peterwmwong peterwmwong mentioned this issue Feb 20, 2015
Closed
@sorvell sorvell added 0.8 and removed 0.8 labels Mar 5, 2015
kevinpschaaf added a commit that referenced this issue Mar 9, 2015
@kevinpschaaf
Fix bespoke constructors, add test, and document. Also fixes #1151.
24a2914
@kevinpschaaf
Copy link
Member

Fixed in 24a2914 (didn't take PR #1152 as the implementation has changed a bit). Note the API change, such that the custom constructor need not call document.createElement and return the element. This will be done automatically; the user constructor should only configure the instance (this).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0.8
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sorvell @peterwmwong @justinfagnani @kevinpschaaf