Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paper-toggle-button and paper-checkbox events incorrectly documented #1074

Closed
m4b opened this issue Jan 6, 2015 · 2 comments
Closed

paper-toggle-button and paper-checkbox events incorrectly documented #1074

m4b opened this issue Jan 6, 2015 · 2 comments

Comments

@m4b
Copy link

m4b commented Jan 6, 2015

In the Polymer documentation for <paper-toggle-button>, the events section lists the two callbacks as change and core-change, but the actual callbacks seem to be on-change and on-core-change.

Similarly for <paper-checkbox>.

@IntranetFactory
Copy link

Why do you report this here and not in repos of each component? I did a quick check and https://github.com/Polymer/paper-toggle-button/blob/master/paper-toggle-button.html#L139 shows that 'change' and 'core-change' are fired.

@m4b
Copy link
Author

m4b commented Jan 6, 2015

Ah, yea I actually misunderstood the documentation. change and core-change are definitely fired, since I mentioned their respective on callbacks, but I thought event callbacks were documented with their respective on-x methods, and not the event x. Seems I was mistaken.

As for reporting, I just used the documentation's "file a bug" button, which didn't notice sent me to the base polymer repo, or here.

I'll close the issue.

@m4b m4b closed this as completed Jan 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants