Don't use translate as a method for testing

`.translate` is some magical property in Safari (and Chrome) Safari 7 puts this on the instance, and breaks tests for property effects
Polymer · Mar 24, 2016 · f80346f · f80346f
1 parent e7254d0
commit f80346f
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 14 deletions.
diff --git a/test/unit/bind-elements.html b/test/unit/bind-elements.html
@@ -595,13 +595,13 @@
 
 <dom-module id="x-bind-computed-property">
   <template>
-    <div id="check">[[translate('Hello World.')]]</div>
+    <div id="check">[[translateMessage('Hello World.')]]</div>
   </template>
   <script>
     (function(){
       var TranslateBehavior = {
         properties: {
-          translate: {
+          translateMessage: {
             type: Function,
             computed: '_computeTranslateFn(translator)'
           }
@@ -634,7 +634,7 @@
 
 <dom-module id="x-bind-computed-property-late-translator">
   <template>
-    <div id="check">[[translate(message)]]</div>
+    <div id="check">[[translateMessage(message)]]</div>
   </template>
   <script>
     Polymer({
@@ -644,7 +644,7 @@
           type: String,
           value: 'Hello'
         },
-        translate: {
+        translateMessage: {
           type: Function,
           computed: '_computeTranslateFn(translator)'
         },

diff --git a/test/unit/bind.html b/test/unit/bind.html
@@ -296,10 +296,6 @@
 
   var el;
 
-  setup(function() {
-
-  });
-
   teardown(function() {
     document.body.removeChild(el);
   });
@@ -334,7 +330,7 @@
     Polymer({
       is: 'x-observer-with-dynamic-function',
       properties: {
-        translate: {
+        translateMessage: {
           type: Function
         },
         message: {
@@ -343,15 +339,15 @@
         }
       },
 
-      observers: ['translate(message)']
+      observers: ['translateMessage(message)']
 
     });
 
     el = document.createElement('x-observer-with-dynamic-function');
     document.body.appendChild(el);
 
     var called = 0;
-    el.translate = function() {
+    el.translateMessage = function() {
       called += 1;
     };
 
@@ -364,9 +360,9 @@
       is: 'x-computed-property-with-dynamic-function',
       properties: {
         computedValue: {
-          computed: "translate('Hello')"
+          computed: "translateMessage('Hello')"
         },
-        translate: {
+        translateMessage: {
           type: Function
         }
       }
@@ -378,7 +374,7 @@
     assert.equal(el.computedValue, undefined);
 
     var called = 0;
-    el.translate = function(message) {
+    el.translateMessage = function(message) {
       called += 1;
       return 'translated: ' + message;
     };