Merge pull request #4789 from Polymer/closure-update

Update closure compiler to support polymer pass v2
Polymer · Aug 11, 2017 · e47f7df · e47f7df
2 parents ee3d36f + cc649e9
commit e47f7df
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 16 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -18,7 +18,7 @@ before_script:
 - export PATH=$HOME/bin:$PATH
 - npm install -g bower gulp-cli@1
 - bower install
-- gulp lint
+- npm run lint
 script:
 - xvfb-run wct
 - if [ "${TRAVIS_PULL_REQUEST}" = "false" ]; then wct -s 'windows 10/microsoftedge@14' -s 'windows 8.1/internet explorer@11' -s 'os x 10.11/safari@9' -s 'macos 10.12/safari@10' -s 'Linux/chrome@41'; fi

diff --git a/externs/polymer-externs.js b/externs/polymer-externs.js
@@ -7,8 +7,8 @@
 
 /**
  * @typedef {{
+ * type: !Function,
  * value: *,
- * type: (!Function | undefined),
  * readOnly: (boolean | undefined),
  * computed: (string | undefined),
  * reflectToAttribute: (boolean | undefined),
@@ -23,18 +23,21 @@ let PolymerElementPropertiesMeta;
  */
 let PolymerElementProperties;
 
-/**
- * @typedef {{
- *   is: string,
- *   extends: (string | undefined),
- *   properties: (!PolymerElementProperties | undefined),
- *   observers: (!Array<string> | undefined),
- *   template: (!HTMLTemplateElement | string | undefined),
- *   hostAttributes: (!Object<string, *> | undefined),
- *   listeners: (!Object<string, string> | undefined)
- * }}
- */
-let PolymerInit;
+let PolymerInit = function(){};
+/** @type {string} */
+PolymerInit.prototype.is;
+/** @type {(string | undefined)} */
+PolymerInit.prototype.extends;
+/** @type {(!PolymerElementProperties | undefined)} */
+PolymerInit.prototype.properties;
+/** @type {(!Array<string> | undefined)} */
+PolymerInit.prototype.observers;
+/** @type {(!HTMLTemplateElement | string | undefined)} */
+PolymerInit.prototype.template;
+/** @type {(!Object<string, *> | undefined)} */
+PolymerInit.prototype.hostAttributes;
+/** @type {(!Object<string, string> | undefined)} */
+PolymerInit.prototype.listeners;
 
 let PolymerElementConstructor = function (){};
 /** @type {(string | undefined)} */

diff --git a/package.json b/package.json
@@ -15,7 +15,7 @@
     "del": "^3.0.0",
     "dom5": "^2.3.0",
     "eslint-plugin-html": "^2.0.1",
-    "google-closure-compiler": "^20170626.0.0",
+    "google-closure-compiler": "^20170806.0.0",
     "gulp": "^3.9.1",
     "gulp-babel": "^6.1.2",
     "gulp-eslint": "^3.0.1",
@@ -32,7 +32,8 @@
   },
   "scripts": {
     "build": "gulp",
-    "test": "gulp lint && wct"
+    "test": "npm run lint && wct",
+    "lint": "gulp lint lint-closure"
   },
   "repository": {
     "type": "git",