From 8a2aeb653b209304560324c1cc05e82e3e4c620e Mon Sep 17 00:00:00 2001
From: Anurag Pathak <anuragpathak1991@gmail.com>
Date: Wed, 3 May 2017 19:48:33 +0530
Subject: [PATCH 01/31] Corrected minor Method comments

---
 lib/utils/async.html | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/lib/utils/async.html b/lib/utils/async.html
index 6bcfbd4b61..c7e1f6bfa8 100644
--- a/lib/utils/async.html
+++ b/lib/utils/async.html
@@ -104,7 +104,7 @@
       /**
        * Enqueues a function called at `requestAnimationFrame` timing.
        *
-       * @memberof Polymer.Async.timeOut
+       * @memberof Polymer.Async.animationFrame
        * @param {Function} fn Callback to run
        * @return {*} Handle used for canceling task
        */
@@ -130,7 +130,7 @@
       /**
        * Enqueues a function called at `requestIdleCallback` timing.
        *
-       * @memberof Polymer.Async.timeOut
+       * @memberof Polymer.Async.idlePeriod
        * @param {Function} fn Callback to run
        * @return {*} Handle used for canceling task
        */
@@ -142,7 +142,7 @@
       /**
        * Cancels a previously enqueued `idlePeriod` callback.
        *
-       * @memberof Polymer.Async.timeOut
+       * @memberof Polymer.Async.idlePeriod
        * @param {*} handle Handle returned from `run` of callback to cancel
        */
       cancel(timer) {
@@ -171,7 +171,7 @@
       /**
        * Enqueues a function called at microtask timing.
        *
-       * @memberof Polymer.Async.timeOut
+       * @memberof Polymer.Async.microTask
        * @param {Function} fn Callback to run
        */
       run(callback) {
@@ -183,6 +183,7 @@
       /**
        * Cancels a previously enqueued `microTask` callback.
        *
+       * @memberof Polymer.Async.microTask
        * @param {*} handle Handle returned from `run` of callback to cancel
        */
       cancel(handle) {

From d72baf9da6779724dbfafdee6ae6aa1b8ed7d333 Mon Sep 17 00:00:00 2001
From: Kevin Schaaf <kschaaf@google.com>
Date: Thu, 4 May 2017 15:20:25 -0700
Subject: [PATCH 02/31] Ensure no warnings for dynamic fns. Fixes #4575

---
 lib/mixins/property-effects.html |  5 +++--
 test/unit/property-effects.html  | 14 +++++++++++---
 2 files changed, 14 insertions(+), 5 deletions(-)

diff --git a/lib/mixins/property-effects.html b/lib/mixins/property-effects.html
index 2321826b7e..4d92e7703b 100644
--- a/lib/mixins/property-effects.html
+++ b/lib/mixins/property-effects.html
@@ -189,7 +189,7 @@
     let changedProp = info.property;
     if (fn) {
       fn.call(inst, inst.__data[changedProp], oldProps[changedProp]);
-    } else {
+    } else if (!info.dynamicFn) {
       console.warn('observer method `' + info.methodName + '` not defined');
     }
   }
@@ -1905,7 +1905,7 @@
        * @protected
        */
       _createPropertyObserver(property, methodName, dynamicFn) {
-        let info = { property, methodName };
+        let info = { property, methodName, dynamicFn };
         this._addPropertyEffect(property, TYPES.OBSERVE, {
           fn: runObserverEffect, info, trigger: {name: property}
         });
@@ -2317,6 +2317,7 @@
             let dynamicFns = templateInfo.dynamicFns;
             if (dynamicFns && dynamicFns[methodName] || signature.static) {
               dependencies.push(methodName);
+              signature.dynamicFn = true;
             }
           } else {
             // Property or path
diff --git a/test/unit/property-effects.html b/test/unit/property-effects.html
index 1310ef0365..01761095e4 100644
--- a/test/unit/property-effects.html
+++ b/test/unit/property-effects.html
@@ -392,8 +392,13 @@
 
   var el;
 
+  setup(function() {
+    sinon.spy(console, 'warn');
+  });
+
   teardown(function() {
     document.body.removeChild(el);
+    console.warn.restore();
   });
 
   test('annotated computation with dynamic function', function() {
@@ -407,6 +412,7 @@
     };
 
     assert.equal(el.$.check.textContent, 'changed: Hello World.');
+    assert.equal(console.warn.callCount, 0);
   });
 
   test('annotated computation / late resolved dynamic function', function() {
@@ -420,6 +426,7 @@
     };
 
     assert.equal(el.$.check.textContent, 'translated: Hello');
+    assert.equal(console.warn.callCount, 0);
   });
 
   test('method observer with dynamic function', function() {
@@ -444,7 +451,7 @@
 
     el.translateMessage = sinon.spy();
     assert.equal(el.translateMessage.callCount, 1);
-
+    assert.equal(console.warn.callCount, 0);
   });
 
   test('observer with dynamic function', function() {
@@ -468,7 +475,7 @@
 
     el.messageChanged = sinon.spy();
     assert.equal(el.messageChanged.callCount, 1);
-
+    assert.equal(console.warn.callCount, 0);
   });
 
   test('computed property with dynamic function', function() {
@@ -497,7 +504,7 @@
 
     assert.equal(called, 1);
     assert.equal(el.computedValue, 'translated: Hello');
-
+    assert.equal(console.warn.callCount, 0);
   });
 
   test('ensure annotator can pass dynamic fn to parent props', function(done) {
@@ -507,6 +514,7 @@
     setTimeout(function() {
       var check = el.root.querySelector('p');
       assert.equal(check.textContent, 'text');
+      assert.equal(console.warn.callCount, 0);
       done();
     });
 

From 3b6981d46f0064d489bbed8e427c92536cb1b588 Mon Sep 17 00:00:00 2001
From: Steven Orvell <sorvell@google.com>
Date: Fri, 5 May 2017 14:48:38 -0700
Subject: [PATCH 03/31] =?UTF-8?q?Fixes=20#4585.=20Data=20notifications=20d?=
 =?UTF-8?q?o=20not=20flush=20host=20if=20host=20has=20not=20initialized=20?=
 =?UTF-8?q?clients.=20This=20preserves=20the=20Polymer=201.x=20guarantee?=
 =?UTF-8?q?=20that=20client=20dom=20is=20fully=20=E2=80=9Creadied=E2=80=9D?=
 =?UTF-8?q?=20when=20data=20observers=20run.?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 lib/mixins/element-mixin.html            |  6 +++++-
 lib/mixins/property-effects.html         | 10 +++++++++-
 test/unit/property-effects-elements.html | 25 ++++++++++++++++++++++--
 3 files changed, 37 insertions(+), 4 deletions(-)

diff --git a/lib/mixins/element-mixin.html b/lib/mixins/element-mixin.html
index a3bb9c9eec..aae9c992e9 100644
--- a/lib/mixins/element-mixin.html
+++ b/lib/mixins/element-mixin.html
@@ -656,6 +656,10 @@
           hostStack.endHosting(this);
           this.$ = this.root.$;
         }
+        // The super.ready here makes this element able to observe data changes.
+        // We must wait to do this until after client dom is created/attached
+        // so that any notifications fired during this process are not handled
+        // before all clients are ready.
         super.ready();
       }
 
@@ -669,10 +673,10 @@
        * @override
        */
       _readyClients() {
-        super._readyClients();
         if (this._template) {
           this.root = this._attachDom(this.root);
         }
+        super._readyClients();
       }
 
 
diff --git a/lib/mixins/property-effects.html b/lib/mixins/property-effects.html
index 2321826b7e..9cc1d0adcc 100644
--- a/lib/mixins/property-effects.html
+++ b/lib/mixins/property-effects.html
@@ -227,8 +227,11 @@
       }
     }
     // Flush host if we actually notified and host was batching
+    // And the host has already initialized clients; this prevents
+    // an issue with a host observing data changes before clients are ready.
     let host;
-    if (notified && (host = inst.__dataHost) && host._flushProperties) {
+    if (notified && (host = inst.__dataHost) && host._flushProperties
+      && host.__dataClientsInitialized) {
       host._flushProperties();
     }
   }
@@ -1509,6 +1512,11 @@
         if (!this.__dataClientsInitialized) {
           this._readyClients();
         }
+        // Before ready, client notifications do not trigger _flushProperties.
+        // Therefore a flush is necessary here if data has been set.
+        if (this.__dataPending) {
+          this._flushProperties();
+        }
       }
 
       /**
diff --git a/test/unit/property-effects-elements.html b/test/unit/property-effects-elements.html
index 7005ec55b3..aeb74816c1 100644
--- a/test/unit/property-effects-elements.html
+++ b/test/unit/property-effects-elements.html
@@ -184,6 +184,9 @@
         };
         this.titleChanged = sinon.spy();
       },
+      ready: function() {
+        this.isReady = true;
+      },
       clearObserverCounts: function() {
         for (var i in this.observerCounts) {
           this.observerCounts[i] = 0;
@@ -344,7 +347,8 @@
         'boundcomputedvalueChanged(boundcomputedvalue)',
         'boundcomputednotifyingvalueChanged(boundcomputednotifyingvalue)',
         'boundreadonlyvalueChanged(boundreadonlyvalue)',
-        'boundCustomNotifyingValueChanged(boundCustomNotifyingValue)'
+        'boundCustomNotifyingValueChanged(boundCustomNotifyingValue)',
+        'boundnotifyingvalueWithDefaultChanged(boundnotifyingvalueWithDefault)'
       ],
       properties: {
         a: {
@@ -367,7 +371,8 @@
           boundcomputedvalueChanged: 0,
           boundcomputednotifyingvalueChanged: 0,
           boundreadonlyvalueChanged: 0,
-          boundCustomNotifyingValueChanged: 0
+          boundCustomNotifyingValueChanged: 0,
+          boundnotifyingvalueWithDefault: 0
         };
       },
       computeComputedValue: function(a, b) {
@@ -378,23 +383,39 @@
           this.observerCounts[i] = 0;
         }
       },
+      assertClientsReady: function() {
+        assert.isTrue(this.$.basic1.isReady, 'basic1 not `ready` by observer time');
+        assert.isTrue(this.$.basic2.isReady, 'basic2 element not `ready` by observer time');
+        assert.isTrue(this.$.basic3.isReady, 'basic3 element not `ready` by observer time');
+        assert.isTrue(this.$.basic4.isReady, 'basic4 element not `ready` by observer time');
+      },
       boundvalueChanged: function() {
+        this.assertClientsReady();
         this.observerCounts.boundvalueChanged++;
       },
       boundnotifyingvalueChanged: function() {
+        this.assertClientsReady();
         this.observerCounts.boundnotifyingvalueChanged++;
       },
       boundcomputedvalueChanged: function() {
+        this.assertClientsReady();
         this.observerCounts.boundcomputedvalueChanged++;
       },
       boundcomputednotifyingvalueChanged: function() {
+        this.assertClientsReady();
         this.observerCounts.boundcomputednotifyingvalueChanged++;
       },
       boundreadonlyvalueChanged: function() {
+        this.assertClientsReady();
         this.observerCounts.boundreadonlyvalueChanged++;
       },
       boundCustomNotifyingValueChanged: function() {
+        this.assertClientsReady();
         this.observerCounts.boundCustomNotifyingValueChanged++;
+      },
+      boundnotifyingvalueWithDefaultChanged: function() {
+        this.assertClientsReady();
+        this.observerCounts.boundnotifyingvalueWithDefault++;
       }
     });
   </script>

From 6f1dde76697dae2c1f64bdbf304500e463d9de26 Mon Sep 17 00:00:00 2001
From: Steven Orvell <sorvell@google.com>
Date: Fri, 5 May 2017 14:53:17 -0700
Subject: [PATCH 04/31] Fix comment.

---
 lib/mixins/element-mixin.html | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/lib/mixins/element-mixin.html b/lib/mixins/element-mixin.html
index aae9c992e9..9465d1d034 100644
--- a/lib/mixins/element-mixin.html
+++ b/lib/mixins/element-mixin.html
@@ -656,10 +656,6 @@
           hostStack.endHosting(this);
           this.$ = this.root.$;
         }
-        // The super.ready here makes this element able to observe data changes.
-        // We must wait to do this until after client dom is created/attached
-        // so that any notifications fired during this process are not handled
-        // before all clients are ready.
         super.ready();
       }
 
@@ -676,6 +672,10 @@
         if (this._template) {
           this.root = this._attachDom(this.root);
         }
+        // The super._readyClients here sets the clients initialized flag.
+        // We must wait to do this until after client dom is created/attached
+        // so that this flag can be checked to prevent notifications fired
+        // during this process from being handled before clients are ready.
         super._readyClients();
       }
 

From 6b6092e0aee8158e08648e71a39f05775940cd3b Mon Sep 17 00:00:00 2001
From: Daniel Freedman <dfreedm@google.com>
Date: Thu, 11 May 2017 14:02:57 -0700
Subject: [PATCH 05/31] [ci skip] remove bower.json version, add npm
 devDependencies & np publish config

---
 bower.json   | 1 -
 package.json | 5 ++++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/bower.json b/bower.json
index 8a1120d472..9baa9c0ffd 100644
--- a/bower.json
+++ b/bower.json
@@ -1,6 +1,5 @@
 {
   "name": "polymer",
-  "version": "2.0.0-rc.7",
   "main": [
     "polymer.html"
   ],
diff --git a/package.json b/package.json
index d9e3423390..1fad2a2ce0 100644
--- a/package.json
+++ b/package.json
@@ -8,6 +8,8 @@
     "test": "test"
   },
   "devDependencies": {
+    "@webcomponents/shadycss": "^1.0.0-rc.6",
+    "@webcomponents/webcomponentsjs": "^1.0.0-rc.12",
     "babel-preset-babili": "0.0.12",
     "del": "^2.2.1",
     "dom5": "^1.3.1",
@@ -40,5 +42,6 @@
   "bugs": {
     "url": "https://github.com/Polymer/polymer/issues"
   },
-  "homepage": "https://github.com/Polymer/polymer"
+  "homepage": "https://github.com/Polymer/polymer",
+  "publishConfig": {"access": "public"}
 }

From 7497065a08c3a11de9fd25e6c7adab5b5aa5d8b1 Mon Sep 17 00:00:00 2001
From: Kevin Schaaf <kschaaf@google.com>
Date: Thu, 11 May 2017 14:08:36 -0700
Subject: [PATCH 06/31] Add static API for creating property fx and minor code
 refactoring.

---
 lib/mixins/property-effects.html | 179 ++++++++++++++++++++++++++++---
 lib/mixins/template-stamp.html   |   5 +-
 2 files changed, 169 insertions(+), 15 deletions(-)

diff --git a/lib/mixins/property-effects.html b/lib/mixins/property-effects.html
index 129cd73eb8..48a0084f0f 100644
--- a/lib/mixins/property-effects.html
+++ b/lib/mixins/property-effects.html
@@ -1026,21 +1026,23 @@
    * Element class mixin that provides meta-programming for Polymer's template
    * binding and data observation (collectively, "property effects") system.
    *
-   * This mixin uses provides the following key methods for adding property effects
-   * to this element:
-   * - `_createPropertyObserver`
-   * - `_createMethodObserver`
-   * - `_createNotifyingProperty`
-   * - `_createReadOnlyProperty`
-   * - `_createReflectedProperty`
-   * - `_createComputedProperty`
-   * - `_bindTemplate`
+   * This mixin uses provides the following key static methods for adding
+   * property effects to an element class:
+   * - `createPropertyEffect`
+   * - `createPropertyObserver`
+   * - `createMethodObserver`
+   * - `createNotifyingProperty`
+   * - `createReadOnlyProperty`
+   * - `createReflectedProperty`
+   * - `createComputedProperty`
+   * - `bindTemplate`
    *
    * Each method creates one or more property accessors, along with metadata
    * used by this mixin's implementation of `_propertiesChanged` to perform
-   * the property effects.  These methods may be called on element instances,
-   * but are designed to be called on element prototypes such that the work to
-   * set up accessors and effect metadata are done once per element class.
+   * the property effects.
+   *
+   * Underscored versions of the above methods also exist on the element
+   * prototype for adding property effects on instances at runtime.
    *
    * Note that this mixin overrides several `PropertyAccessors` methods, in
    * many cases to maintain guarantees provided by the Polymer 1.x features;
@@ -2004,6 +2006,150 @@
         createMethodEffect(this, sig, TYPES.COMPUTE, runComputedEffect, property, dynamicFns);
       }
 
+      // -- static class methods ------------
+
+      /**
+       * Ensures an accessor exists for the specified property, and adds
+       * to a list of "property effects" that will run when the accessor for
+       * the specified property is set.  Effects are grouped by "type", which
+       * roughly corresponds to a phase in effect processing.  The effect
+       * metadata should be in the following form:
+       *
+       *   {
+       *     fn: effectFunction, // Reference to function to call to perform effect
+       *     info: { ... }       // Effect metadata passed to function
+       *     trigger: {          // Optional triggering metadata; if not provided
+       *       name: string      // the property is treated as a wildcard
+       *       structured: boolean
+       *       wildcard: boolean
+       *     }
+       *   }
+       *
+       * Effects are called from `_propertiesChanged` in the following order by
+       * type:
+       *
+       * 1. COMPUTE
+       * 2. PROPAGATE
+       * 3. REFLECT
+       * 4. OBSERVE
+       * 5. NOTIFY
+       *
+       * Effect functions are called with the following signature:
+       *
+       *   effectFunction(inst, path, props, oldProps, info, hasPaths)
+       *
+       * @param {string} property Property that should trigger the effect
+       * @param {string} type Effect type, from this.PROPERTY_EFFECT_TYPES
+       * @param {Object=} effect Effect metadata object
+       * @protected
+       */
+      static addPropertyEffect(property, type, effect) {
+        this.prototype._addPropertyEffect(property, type, effect);
+      }
+
+      /**
+       * Creates a single-property observer for the given property.
+       *
+       * @param {string} property Property name
+       * @param {string} methodName Name of observer method to call
+       * @param {boolean=} dynamicFn Whether the method name should be included as
+       *   a dependency to the effect.
+       * @protected
+       */
+      static createPropertyObserver(property, methodName, dynamicFn) {
+        this.prototype._createPropertyObserver(property, methodName, dynamicFn);
+      }
+
+      /**
+       * Creates a multi-property "method observer" based on the provided
+       * expression, which should be a string in the form of a normal Javascript
+       * function signature: `'methodName(arg1, [..., argn])'`.  Each argument
+       * should correspond to a property or path in the context of this
+       * prototype (or instance), or may be a literal string or number.
+       *
+       * @param {string} expression Method expression
+       * @param {Object=} dynamicFns Map indicating whether method names should
+       *   be included as a dependency to the effect.
+       * @protected
+       */
+      static createMethodObserver(expression, dynamicFns) {
+        this.prototype._createMethodObserver(expression, dynamicFns);
+      }
+
+      /**
+       * Causes the setter for the given property to dispatch `<property>-changed`
+       * events to notify of changes to the property.
+       *
+       * @param {string} property Property name
+       * @protected
+       */
+      static createNotifyingProperty(property) {
+        this.prototype._createNotifyingProperty(property);
+      }
+
+      /**
+       * Creates a read-only accessor for the given property.
+       *
+       * To set the property, use the protected `_setProperty` API.
+       * To create a custom protected setter (e.g. `_setMyProp()` for
+       * property `myProp`), pass `true` for `protectedSetter`.
+       *
+       * Note, if the property will have other property effects, this method
+       * should be called first, before adding other effects.
+       *
+       * @param {string} property Property name
+       * @param {boolean=} protectedSetter Creates a custom protected setter
+       *   when `true`.
+       * @protected
+       */
+      static createReadOnlyProperty(property, protectedSetter) {
+        this.prototype._createReadOnlyProperty(property, protectedSetter);
+      }
+
+      /**
+       * Causes the setter for the given property to reflect the property value
+       * to a (dash-cased) attribute of the same name.
+       *
+       * @param {string} property Property name
+       * @protected
+       */
+      static createReflectedProperty(property) {
+        this.prototype._createReflectedProperty(property);
+      }
+
+      /**
+       * Creates a computed property whose value is set to the result of the
+       * method described by the given `expression` each time one or more
+       * arguments to the method changes.  The expression should be a string
+       * in the form of a normal Javascript function signature:
+       * `'methodName(arg1, [..., argn])'`
+       *
+       * @param {string} property Name of computed property to set
+       * @param {string} expression Method expression
+       * @param {Object=} dynamicFns Map indicating whether method names should
+       *   be included as a dependency to the effect.
+       * @protected
+       */
+      static createComputedProperty(property, expression, dynamicFns) {
+        this.prototype._createComputedProperty(property, expression, dynamicFns);
+      }
+
+      /**
+       * Parses the provided template to ensure binding effects are created
+       * for them, and then ensures property accessors are created for any
+       * dependent properties in the template.  Binding effects for bound
+       * templates are stored in a linked list on the instance so that
+       * templates can be efficiently stamped and unstamped.
+       *
+       * @param {HTMLTemplateElement} template Template containing binding
+       *   bindings
+       * @return {Object} Template metadata object
+       * @protected
+       */
+      static bindTemplate(template) {
+        return this.prototype._bindTemplate(template);
+      }
+
       // -- binding ----------------------------------------------
 
       /**
@@ -2046,8 +2192,10 @@
           templateInfo = Object.create(templateInfo);
           templateInfo.wasPreBound = wasPreBound;
           if (!wasPreBound && this.__templateInfo) {
-            templateInfo.nextTemplateInfo = this.__templateInfo;
-            this.__templateInfo.previousTemplateInfo = templateInfo;
+            let last = this.__templateInfoLast || this.__templateInfo;
+            this.__templateInfoLast = last.nextTemplateInfo = templateInfo;
+            templateInfo.previousTemplateInfo = last;
+            return templateInfo;
           }
         }
         return this.__templateInfo = templateInfo;
@@ -2134,6 +2282,9 @@
           templateInfo.nextTemplateInfo.previousTemplateInfo =
             templateInfo.previousTemplateInfo;
         }
+        if (this.__templateInfoLast == templateInfo) {
+          this.__templateInfoLast = templateInfo.previousTemplateInfo;
+        }
         // Remove stamped nodes
         let nodes = templateInfo.childNodes;
         for (let i=0; i<nodes.length; i++) {
diff --git a/lib/mixins/template-stamp.html b/lib/mixins/template-stamp.html
index fee06c90a2..643740da62 100644
--- a/lib/mixins/template-stamp.html
+++ b/lib/mixins/template-stamp.html
@@ -281,7 +281,10 @@
           if (this._parseTemplateNode(node, templateInfo, childInfo)) {
             childInfo.infoIndex = templateInfo.nodeInfoList.push(childInfo) - 1;
           }
-          parentIndex++;
+          // Increment if not removed
+          if (node.parentNode) {
+            parentIndex++;
+          }
         }
       }
 

From 24dd897d065cf854c9dc9a2664ea743ecb496008 Mon Sep 17 00:00:00 2001
From: Daniel Freedman <dfreedm@google.com>
Date: Thu, 11 May 2017 14:48:22 -0700
Subject: [PATCH 07/31] [ci skip] port gen-changelog from 1.x

---
 util/gen-changelog.sh | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/util/gen-changelog.sh b/util/gen-changelog.sh
index 84018969be..10d762ad14 100755
--- a/util/gen-changelog.sh
+++ b/util/gen-changelog.sh
@@ -6,9 +6,6 @@ end="$2"
 
 enddate=`git log -1 ${end} --pretty="%ai" | cut -d ' ' -f 1`
 
-startrev="`git show ${start}:build.log | awk '/polymer: / {print $2}'`"
-endrev="`git show ${end}:build.log | awk '/polymer: / {print $2}'`"
-
 old=""
 if [ -e CHANGELOG.md ]; then
   old="`sed -e '1,2d' CHANGELOG.md`"
@@ -18,7 +15,7 @@ cat > CHANGELOG.md <<EOD
 # Change Log
 
 ## [${end}](https://github.com/Polymer/polymer/tree/${end}) (${enddate})
-`git log --no-merges "${startrev}".."${endrev}^1" --pretty="${PRETTY}"`
+`git log --no-merges "${start}".."${end}^1" --pretty="${PRETTY}"`
 
 ${old}
 EOD

From 0f4ebf62e123a944ec59bff678592630811048b3 Mon Sep 17 00:00:00 2001
From: Kevin Schaaf <kschaaf@google.com>
Date: Thu, 11 May 2017 16:02:00 -0700
Subject: [PATCH 08/31] Add tests

---
 test/unit/property-effects.html | 216 +++++++++++++++++++++++++++++++-
 1 file changed, 215 insertions(+), 1 deletion(-)

diff --git a/test/unit/property-effects.html b/test/unit/property-effects.html
index 01761095e4..f6958a660a 100644
--- a/test/unit/property-effects.html
+++ b/test/unit/property-effects.html
@@ -23,7 +23,7 @@
 </dom-repeat>
 
 <script>
-
+/*
 suite('single-element binding effects', function() {
 
   var el;
@@ -1504,6 +1504,220 @@
     assert.equal(fn.callCount, 2);
   });
 
+});
+*/
+
+suite('a la carte usage of API', function() {
+
+  class BaseClass extends Polymer.PropertyEffects(HTMLElement) {
+    connectedCallback() {
+      this.pcSpy = sinon.spy();
+      this._flushProperties();
+    }
+    _propertiesChanged(props, changedProps, oldProps) {
+      this.pcSpy(props, changedProps, oldProps);
+      super._propertiesChanged(props, changedProps, oldProps);
+    }
+  }
+
+  test('generic property effect', function() {
+    class TestClass extends BaseClass {
+      constructor() {
+        super();
+        this.observer = sinon.spy();
+      }
+    }
+    let observer = sinon.spy();
+    TestClass.addPropertyEffect('prop', TestClass.prototype.PROPERTY_EFFECT_TYPES.OBSERVE, {
+      fn: observer
+    });
+    customElements.define('pe-pe', TestClass);
+    let el = document.createElement('pe-pe');
+    document.body.appendChild(el);
+    assert.equal(observer.callCount, 0);
+    assert.equal(el.pcSpy.callCount, 0);
+    el.prop = true;
+    assert.equal(observer.callCount, 1);
+    assert.equal(el.pcSpy.callCount, 1);
+    el.prop = 'hithere';
+    assert.equal(observer.callCount, 2);
+    assert.equal(el.pcSpy.callCount, 2);
+    el.prop = false;
+    assert.equal(observer.callCount, 3);
+    assert.equal(el.pcSpy.callCount, 3);
+    document.body.removeChild(el);
+  });
+
+  test('read only property', function() {
+    class TestClass extends BaseClass {}
+    TestClass.createReadOnlyProperty('prop', true);
+    customElements.define('pe-read-only', TestClass);
+    let el = document.createElement('pe-read-only');
+    document.body.appendChild(el);
+    el.prop = true;
+    assert.equal(el.prop, undefined);
+    assert.equal(el.pcSpy.callCount, 0);
+    el._setProp(true);
+    assert.equal(el.prop, true);
+    assert.equal(el.pcSpy.callCount, 1);
+    el.prop = false;
+    assert.equal(el.prop, true);
+    assert.equal(el.pcSpy.callCount, 1);
+    document.body.removeChild(el);
+  });
+
+  test('reflected property', function() {
+    class TestClass extends BaseClass {}
+    TestClass.createReflectedProperty('prop', true);
+    customElements.define('pe-reflected', TestClass);
+    let el = document.createElement('pe-reflected');
+    document.body.appendChild(el);
+    assert.equal(el.hasAttribute('prop'), false);
+    assert.equal(el.pcSpy.callCount, 0);
+    el.prop = true;
+    assert.equal(el.getAttribute('prop'), '');
+    assert.equal(el.pcSpy.callCount, 1);
+    el.prop = 'hithere';
+    assert.equal(el.getAttribute('prop'), 'hithere');
+    assert.equal(el.pcSpy.callCount, 2);
+    el.prop = false;
+    assert.equal(el.hasAttribute('prop'), false);
+    assert.equal(el.pcSpy.callCount, 3);
+    document.body.removeChild(el);
+  });
+
+  test('property observer', function() {
+    class TestClass extends BaseClass {
+      constructor() {
+        super();
+        this.observer = sinon.spy();
+      }
+    }
+    TestClass.createPropertyObserver('prop', 'observer');
+    customElements.define('pe-observer', TestClass);
+    let el = document.createElement('pe-observer');
+    document.body.appendChild(el);
+    assert.equal(el.observer.callCount, 0);
+    assert.equal(el.pcSpy.callCount, 0);
+    el.prop = true;
+    assert.equal(el.observer.callCount, 1);
+    assert.equal(el.pcSpy.callCount, 1);
+    el.prop = 'hithere';
+    assert.equal(el.observer.callCount, 2);
+    assert.equal(el.pcSpy.callCount, 2);
+    el.prop = false;
+    assert.equal(el.observer.callCount, 3);
+    assert.equal(el.pcSpy.callCount, 3);
+    document.body.removeChild(el);
+  });
+
+  test('method observer', function() {
+    class TestClass extends BaseClass {
+      constructor() {
+        super();
+        this.observer = sinon.spy();
+      }
+    }
+    TestClass.createMethodObserver('observer(a, b.c)');
+    customElements.define('pe-method-observer', TestClass);
+    let el = document.createElement('pe-method-observer');
+    document.body.appendChild(el);
+    assert.equal(el.observer.callCount, 0);
+    assert.equal(el.pcSpy.callCount, 0);
+    el.a = 'a';
+    assert.equal(el.observer.callCount, 1);
+    assert.deepEqual(el.observer.getCall(0).args, ['a', undefined]);
+    assert.equal(el.pcSpy.callCount, 1);
+    el.b = {c: 'c'};
+    assert.equal(el.observer.callCount, 2);
+    assert.deepEqual(el.observer.getCall(1).args, ['a', 'c']);
+    assert.equal(el.pcSpy.callCount, 2);
+    el.setProperties({
+      a: 'A',
+      b: {c: 'C'}
+    })
+    assert.equal(el.observer.callCount, 3);
+    assert.deepEqual(el.observer.getCall(2).args, ['A', 'C']);
+    assert.equal(el.pcSpy.callCount, 3);
+    document.body.removeChild(el);
+  });
+
+  test('computed property', function() {
+    class TestClass extends BaseClass {
+      constructor() {
+        super();
+        this.compute = sinon.spy(function(a, c) { return a + c; });
+      }
+    }
+    TestClass.createComputedProperty('prop', 'compute(a, b.c)');
+    customElements.define('pe-computed', TestClass);
+    let el = document.createElement('pe-computed');
+    document.body.appendChild(el);
+    assert.equal(el.compute.callCount, 0);
+    assert.equal(el.pcSpy.callCount, 0);
+    el.a = 'a';
+    assert.equal(el.compute.callCount, 1);
+    assert.deepEqual(el.compute.getCall(0).args, ['a', undefined]);
+    assert.equal(el.prop, 'aundefined');
+    assert.equal(el.pcSpy.callCount, 1);
+    el.b = {c: 'c'};
+    assert.equal(el.compute.callCount, 2);
+    assert.deepEqual(el.compute.getCall(1).args, ['a', 'c']);
+    assert.equal(el.prop, 'ac');
+    assert.equal(el.pcSpy.callCount, 2);
+    el.setProperties({
+      a: 'A',
+      b: {c: 'C'}
+    })
+    assert.equal(el.compute.callCount, 3);
+    assert.deepEqual(el.compute.getCall(2).args, ['A', 'C']);
+    assert.equal(el.prop, 'AC');
+    assert.equal(el.pcSpy.callCount, 3);
+    document.body.removeChild(el);
+  });
+
+  test('notifying property', function() {
+    class TestClass extends BaseClass { }
+    TestClass.createNotifyingProperty('prop');
+    customElements.define('pe-notify', TestClass);
+    let el = document.createElement('pe-notify');
+    let handler = sinon.spy();
+    el.addEventListener('prop-changed', handler);
+    document.body.appendChild(el);
+    assert.equal(handler.callCount, 0);
+    assert.equal(el.pcSpy.callCount, 0);
+    el.prop = 'prop';
+    assert.equal(handler.callCount, 1);
+    assert.equal(handler.getCall(0).args[0].detail.value, 'prop');
+    assert.equal(el.pcSpy.callCount, 1);
+    el.prop += '+';
+    assert.equal(handler.callCount, 2);
+    assert.equal(handler.getCall(1).args[0].detail.value, 'prop+');
+    document.body.removeChild(el);
+  });
+
+  test('bound template', function() {
+    let template = document.createElement('template');
+    template.innerHTML = '<div>[[prop]]</div><button on-click="handler"></button>';
+    class TestClass extends BaseClass {
+      connectedCallback() {
+        this.handler = sinon.spy();
+        this.attachShadow({mode:'open'}).appendChild(this._stampTemplate(template));
+        super.connectedCallback();
+      }
+    }
+    TestClass.bindTemplate(template);
+    customElements.define('pe-template', TestClass);
+    let el = document.createElement('pe-template');
+    document.body.appendChild(el);
+    assert.equal(el.handler.callCount, 0);
+    el.prop = 'prop';
+    assert.equal(el.shadowRoot.querySelector('div').textContent, 'prop');
+    el.shadowRoot.querySelector('button').click();
+    assert.equal(el.handler.callCount, 1);
+    document.body.removeChild(el);
+  });
+
 });
 
 </script>

From 55b2d16088c3624f1ef189802952fff7be0abd85 Mon Sep 17 00:00:00 2001
From: Kevin Schaaf <kschaaf@google.com>
Date: Thu, 11 May 2017 16:05:08 -0700
Subject: [PATCH 09/31] Uncomment previous tests

---
 test/unit/property-effects.html | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/test/unit/property-effects.html b/test/unit/property-effects.html
index f6958a660a..0481f2411b 100644
--- a/test/unit/property-effects.html
+++ b/test/unit/property-effects.html
@@ -23,7 +23,7 @@
 </dom-repeat>
 
 <script>
-/*
+
 suite('single-element binding effects', function() {
 
   var el;
@@ -1505,7 +1505,6 @@
   });
 
 });
-*/
 
 suite('a la carte usage of API', function() {
 

From d5b282fa09f4916d7a37b067abc74c0910b133b3 Mon Sep 17 00:00:00 2001
From: Kevin Schaaf <kschaaf@google.com>
Date: Thu, 11 May 2017 16:20:02 -0700
Subject: [PATCH 10/31] Move setup to suiteSetup

---
 test/unit/property-effects.html | 22 +++++++++++++---------
 1 file changed, 13 insertions(+), 9 deletions(-)

diff --git a/test/unit/property-effects.html b/test/unit/property-effects.html
index 0481f2411b..c9c3c1355a 100644
--- a/test/unit/property-effects.html
+++ b/test/unit/property-effects.html
@@ -1508,16 +1508,20 @@
 
 suite('a la carte usage of API', function() {
 
-  class BaseClass extends Polymer.PropertyEffects(HTMLElement) {
-    connectedCallback() {
-      this.pcSpy = sinon.spy();
-      this._flushProperties();
-    }
-    _propertiesChanged(props, changedProps, oldProps) {
-      this.pcSpy(props, changedProps, oldProps);
-      super._propertiesChanged(props, changedProps, oldProps);
+  let BaseClass;
+
+  suiteSetup(function() {
+    BaseClass = class extends Polymer.PropertyEffects(HTMLElement) {
+      connectedCallback() {
+        this.pcSpy = sinon.spy();
+        this._flushProperties();
+      }
+      _propertiesChanged(props, changedProps, oldProps) {
+        this.pcSpy(props, changedProps, oldProps);
+        super._propertiesChanged(props, changedProps, oldProps);
+      }
     }
-  }
+  });
 
   test('generic property effect', function() {
     class TestClass extends BaseClass {

From e97a6eb779f70f85b8f919e37fd51515f8e1c100 Mon Sep 17 00:00:00 2001
From: Kevin Schaaf <kschaaf@google.com>
Date: Thu, 11 May 2017 16:27:46 -0700
Subject: [PATCH 11/31] Dedupe API docs.

---
 lib/mixins/property-effects.html | 87 +++++++++-----------------------
 1 file changed, 24 insertions(+), 63 deletions(-)

diff --git a/lib/mixins/property-effects.html b/lib/mixins/property-effects.html
index 48a0084f0f..d81f682fff 100644
--- a/lib/mixins/property-effects.html
+++ b/lib/mixins/property-effects.html
@@ -1130,41 +1130,9 @@
       // Prototype setup ----------------------------------------
 
       /**
-       * Ensures an accessor exists for the specified property, and adds
-       * to a list of "property effects" that will run when the accessor for
-       * the specified property is set.  Effects are grouped by "type", which
-       * roughly corresponds to a phase in effect processing.  The effect
-       * metadata should be in the following form:
-       *
-       *   {
-       *     fn: effectFunction, // Reference to function to call to perform effect
-       *     info: { ... }       // Effect metadata passed to function
-       *     trigger: {          // Optional triggering metadata; if not provided
-       *       name: string      // the property is treated as a wildcard
-       *       structured: boolean
-       *       wildcard: boolean
-       *     }
-       *   }
-       *
-       * Effects are called from `_propertiesChanged` in the following order by
-       * type:
-       *
-       * 1. COMPUTE
-       * 2. PROPAGATE
-       * 3. REFLECT
-       * 4. OBSERVE
-       * 5. NOTIFY
-       *
-       * Effect functions are called with the following signature:
-       *
-       *   effectFunction(inst, path, props, oldProps, info, hasPaths)
-       *
-       * This method may be called either on the prototype of a class
-       * using the PropertyEffects mixin (for best performance), or on
-       * an instance to add dynamic effects.  When called on an instance or
-       * subclass of a class that has already had property effects added to
-       * its prototype, the property effect lists will be cloned and added as
-       * own properties of the caller.
+       * Equivalent to static `addPropertyEffect` API but can be called on
+       * an instance to add effects at runtime.  See that method for
+       * full API docs.
        *
        * @param {string} property Property that should trigger the effect
        * @param {string} type Effect type, from this.PROPERTY_EFFECT_TYPES
@@ -1882,14 +1850,9 @@
       }
 
       /**
-       * Creates a read-only accessor for the given property.
-       *
-       * To set the property, use the protected `_setProperty` API.
-       * To create a custom protected setter (e.g. `_setMyProp()` for
-       * property `myProp`), pass `true` for `protectedSetter`.
-       *
-       * Note, if the property will have other property effects, this method
-       * should be called first, before adding other effects.
+       * Equivalent to static `createReadOnlyProperty` API but can be called on
+       * an instance to add effects at runtime.  See that method for
+       * full API docs.
        *
        * @param {string} property Property name
        * @param {boolean=} protectedSetter Creates a custom protected setter
@@ -1906,7 +1869,9 @@
       }
 
       /**
-       * Creates a single-property observer for the given property.
+       * Equivalent to static `createPropertyObserver` API but can be called on
+       * an instance to add effects at runtime.  See that method for
+       * full API docs.
        *
        * @param {string} property Property name
        * @param {string} methodName Name of observer method to call
@@ -1927,11 +1892,9 @@
       }
 
       /**
-       * Creates a multi-property "method observer" based on the provided
-       * expression, which should be a string in the form of a normal Javascript
-       * function signature: `'methodName(arg1, [..., argn])'`.  Each argument
-       * should correspond to a property or path in the context of this
-       * prototype (or instance), or may be a literal string or number.
+       * Equivalent to static `createMethodObserver` API but can be called on
+       * an instance to add effects at runtime.  See that method for
+       * full API docs.
        *
        * @param {string} expression Method expression
        * @param {Object=} dynamicFns Map indicating whether method names should
@@ -1947,8 +1910,9 @@
       }
 
       /**
-       * Causes the setter for the given property to dispatch `<property>-changed`
-       * events to notify of changes to the property.
+       * Equivalent to static `createNotifyingProperty` API but can be called on
+       * an instance to add effects at runtime.  See that method for
+       * full API docs.
        *
        * @param {string} property Property name
        * @protected
@@ -1964,8 +1928,9 @@
       }
 
       /**
-       * Causes the setter for the given property to reflect the property value
-       * to a (dash-cased) attribute of the same name.
+       * Equivalent to static `createReflectedProperty` API but can be called on
+       * an instance to add effects at runtime.  See that method for
+       * full API docs.
        *
        * @param {string} property Property name
        * @protected
@@ -1986,11 +1951,9 @@
       }
 
       /**
-       * Creates a computed property whose value is set to the result of the
-       * method described by the given `expression` each time one or more
-       * arguments to the method changes.  The expression should be a string
-       * in the form of a normal Javascript function signature:
-       * `'methodName(arg1, [..., argn])'`
+       * Equivalent to static `createComputedProperty` API but can be called on
+       * an instance to add effects at runtime.  See that method for
+       * full API docs.
        *
        * @param {string} property Name of computed property to set
        * @param {string} expression Method expression
@@ -2153,11 +2116,9 @@
       // -- binding ----------------------------------------------
 
       /**
-       * Parses the provided template to ensure binding effects are created
-       * for them, and then ensures property accessors are created for any
-       * dependent properties in the template.  Binding effects for bound
-       * templates are stored in a linked list on the instance so that
-       * templates can be efficiently stamped and unstamped.
+       * Equivalent to static `bindTemplate` API but can be called on
+       * an instance to add effects at runtime.  See that method for
+       * full API docs.
        *
        * This method may be called on the prototype (for prototypical template
        * binding, to avoid creating accessors every instance) once per prototype,

From 4223043748b9cccc167e114df54002a2f4bc9504 Mon Sep 17 00:00:00 2001
From: Kevin Schaaf <kschaaf@google.com>
Date: Thu, 11 May 2017 16:36:39 -0700
Subject: [PATCH 12/31] Null the links when unbinding.

---
 lib/mixins/property-effects.html | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/mixins/property-effects.html b/lib/mixins/property-effects.html
index d81f682fff..1cf772869a 100644
--- a/lib/mixins/property-effects.html
+++ b/lib/mixins/property-effects.html
@@ -2246,6 +2246,7 @@
         if (this.__templateInfoLast == templateInfo) {
           this.__templateInfoLast = templateInfo.previousTemplateInfo;
         }
+        templateInfo.previousTemplateInfo = templateInfo.nextTemplateInfo = null;
         // Remove stamped nodes
         let nodes = templateInfo.childNodes;
         for (let i=0; i<nodes.length; i++) {

From d9b5b8f917684ffe12b12407573aa74e0342f1a2 Mon Sep 17 00:00:00 2001
From: Daniel Freedman <dfreedm@google.com>
Date: Thu, 11 May 2017 16:54:49 -0700
Subject: [PATCH 13/31] update dependencies for v1 polyfills

---
 bower.json   | 4 ++--
 package.json | 8 +++++---
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/bower.json b/bower.json
index 9baa9c0ffd..ed93844022 100644
--- a/bower.json
+++ b/bower.json
@@ -20,8 +20,8 @@
     "url": "https://github.com/Polymer/polymer.git"
   },
   "dependencies": {
-    "shadycss": "webcomponents/shadycss#^v1.0.0-rc.1",
-    "webcomponentsjs": "^v1.0.0-rc.5"
+    "shadycss": "webcomponents/shadycss#^v1.0.0",
+    "webcomponentsjs": "^v1.0.0"
   },
   "devDependencies": {
     "web-component-tester": "^v6.0.0-prerelease.10",
diff --git a/package.json b/package.json
index 1fad2a2ce0..6c9c762042 100644
--- a/package.json
+++ b/package.json
@@ -8,8 +8,8 @@
     "test": "test"
   },
   "devDependencies": {
-    "@webcomponents/shadycss": "^1.0.0-rc.6",
-    "@webcomponents/webcomponentsjs": "^1.0.0-rc.12",
+    "@webcomponents/shadycss": "^1.0.0",
+    "@webcomponents/webcomponentsjs": "^1.0.0",
     "babel-preset-babili": "0.0.12",
     "del": "^2.2.1",
     "dom5": "^1.3.1",
@@ -43,5 +43,7 @@
     "url": "https://github.com/Polymer/polymer/issues"
   },
   "homepage": "https://github.com/Polymer/polymer",
-  "publishConfig": {"access": "public"}
+  "publishConfig": {
+    "access": "public"
+  }
 }

From f197ce240eaa7c694271b8151baf2e11c7216e6f Mon Sep 17 00:00:00 2001
From: Kevin Schaaf <kschaaf@google.com>
Date: Thu, 11 May 2017 16:58:50 -0700
Subject: [PATCH 14/31] Accept boolean or object map for dynamicFns

---
 lib/mixins/property-effects.html | 43 ++++++++++++++++----------------
 1 file changed, 22 insertions(+), 21 deletions(-)

diff --git a/lib/mixins/property-effects.html b/lib/mixins/property-effects.html
index 1cf772869a..7c8c16ceba 100644
--- a/lib/mixins/property-effects.html
+++ b/lib/mixins/property-effects.html
@@ -718,13 +718,14 @@
    * @param {Function} effectFn Function to run when arguments change
    * @param {*=} methodInfo Effect-specific information to be included in
    *   method effect metadata
-   * @param {Object=} dynamicFns Map indicating whether method names should
-   *   be included as a dependency to the effect. Note, defaults to true
-   *   if the signature is statci (sig.static is true).
+   * @param {boolean|Object=} dynamicFn Boolean or object map indicating whether
+   *   method names should be included as a dependency to the effect. Note,
+   *   defaults to true if the signature is static (sig.static is true).
    * @private
    */
-  function createMethodEffect(model, sig, type, effectFn, methodInfo, dynamicFns) {
-    let dynamicFn = sig.static || dynamicFns && dynamicFns[sig.methodName];
+  function createMethodEffect(model, sig, type, effectFn, methodInfo, dynamicFn) {
+    dynamicFn = sig.static || (dynamicFn &&
+      (typeof dynamicFn !== 'object' || dynamicFn[sig.methodName]));
     let info = {
       methodName: sig.methodName,
       args: sig.args,
@@ -1897,16 +1898,16 @@
        * full API docs.
        *
        * @param {string} expression Method expression
-       * @param {Object=} dynamicFns Map indicating whether method names should
-       *   be included as a dependency to the effect.
+       * @param {boolean|Object=} dynamicFn Boolean or object map indicating
+       *   whether method names should be included as a dependency to the effect.
        * @protected
        */
-      _createMethodObserver(expression, dynamicFns) {
+      _createMethodObserver(expression, dynamicFn) {
         let sig = parseMethod(expression);
         if (!sig) {
           throw new Error("Malformed observer expression '" + expression + "'");
         }
-        createMethodEffect(this, sig, TYPES.OBSERVE, runMethodEffect, null, dynamicFns);
+        createMethodEffect(this, sig, TYPES.OBSERVE, runMethodEffect, null, dynamicFn);
       }
 
       /**
@@ -1957,16 +1958,16 @@
        *
        * @param {string} property Name of computed property to set
        * @param {string} expression Method expression
-       * @param {Object=} dynamicFns Map indicating whether method names should
-       *   be included as a dependency to the effect.
+       * @param {boolean|Object=} dynamicFn Boolean or object map indicating
+       *   whether method names should be included as a dependency to the effect.
        * @protected
        */
-      _createComputedProperty(property, expression, dynamicFns) {
+      _createComputedProperty(property, expression, dynamicFn) {
         let sig = parseMethod(expression);
         if (!sig) {
           throw new Error("Malformed computed expression '" + expression + "'");
         }
-        createMethodEffect(this, sig, TYPES.COMPUTE, runComputedEffect, property, dynamicFns);
+        createMethodEffect(this, sig, TYPES.COMPUTE, runComputedEffect, property, dynamicFn);
       }
 
       // -- static class methods ------------
@@ -2031,12 +2032,12 @@
        * prototype (or instance), or may be a literal string or number.
        *
        * @param {string} expression Method expression
-       * @param {Object=} dynamicFns Map indicating whether method names should
-       *   be included as a dependency to the effect.
+       * @param {boolean|Object=} dynamicFn Boolean or object map indicating
+       *   whether method names should be included as a dependency to the effect.
        * @protected
        */
-      static createMethodObserver(expression, dynamicFns) {
-        this.prototype._createMethodObserver(expression, dynamicFns);
+      static createMethodObserver(expression, dynamicFn) {
+        this.prototype._createMethodObserver(expression, dynamicFn);
       }
 
       /**
@@ -2089,12 +2090,12 @@
        *
        * @param {string} property Name of computed property to set
        * @param {string} expression Method expression
-       * @param {Object=} dynamicFns Map indicating whether method names should
-       *   be included as a dependency to the effect.
+       * @param {boolean|Object=} dynamicFn Boolean or object map indicating whether
+       *   method names should be included as a dependency to the effect.
        * @protected
        */
-      static createComputedProperty(property, expression, dynamicFns) {
-        this.prototype._createComputedProperty(property, expression, dynamicFns);
+      static createComputedProperty(property, expression, dynamicFn) {
+        this.prototype._createComputedProperty(property, expression, dynamicFn);
       }
 
       /**

From 03d21ce8b41ef45d0c5eca97dc7a9406b2018d2b Mon Sep 17 00:00:00 2001
From: Kevin Schaaf <kschaaf@google.com>
Date: Thu, 11 May 2017 17:17:40 -0700
Subject: [PATCH 15/31] Add test for boolean dynamicFn

---
 test/unit/property-effects.html | 26 ++++++++++++++++----------
 1 file changed, 16 insertions(+), 10 deletions(-)

diff --git a/test/unit/property-effects.html b/test/unit/property-effects.html
index c9c3c1355a..c1be29da2d 100644
--- a/test/unit/property-effects.html
+++ b/test/unit/property-effects.html
@@ -1621,27 +1621,33 @@
         this.observer = sinon.spy();
       }
     }
-    TestClass.createMethodObserver('observer(a, b.c)');
+    TestClass.createMethodObserver('observer(a, b.c)', true);
     customElements.define('pe-method-observer', TestClass);
     let el = document.createElement('pe-method-observer');
     document.body.appendChild(el);
-    assert.equal(el.observer.callCount, 0);
-    assert.equal(el.pcSpy.callCount, 0);
-    el.a = 'a';
     assert.equal(el.observer.callCount, 1);
-    assert.deepEqual(el.observer.getCall(0).args, ['a', undefined]);
+    assert.deepEqual(el.observer.getCall(0).args, [undefined, undefined]);
     assert.equal(el.pcSpy.callCount, 1);
-    el.b = {c: 'c'};
+    el.a = 'a';
     assert.equal(el.observer.callCount, 2);
-    assert.deepEqual(el.observer.getCall(1).args, ['a', 'c']);
+    assert.deepEqual(el.observer.getCall(1).args, ['a', undefined]);
     assert.equal(el.pcSpy.callCount, 2);
+    el.b = {c: 'c'};
+    assert.equal(el.observer.callCount, 3);
+    assert.deepEqual(el.observer.getCall(2).args, ['a', 'c']);
+    assert.equal(el.pcSpy.callCount, 3);
     el.setProperties({
       a: 'A',
       b: {c: 'C'}
     })
-    assert.equal(el.observer.callCount, 3);
-    assert.deepEqual(el.observer.getCall(2).args, ['A', 'C']);
-    assert.equal(el.pcSpy.callCount, 3);
+    assert.equal(el.observer.callCount, 4);
+    assert.deepEqual(el.observer.getCall(3).args, ['A', 'C']);
+    assert.equal(el.pcSpy.callCount, 4);
+
+    el.observer = sinon.spy();
+    assert.equal(el.observer.callCount, 1);
+    assert.deepEqual(el.observer.getCall(0).args, ['A', 'C']);
+    assert.equal(el.pcSpy.callCount, 5);
     document.body.removeChild(el);
   });
 

From 8456806cf7d116b5b85607835e8cdccf3bfcd07f Mon Sep 17 00:00:00 2001
From: Daniel Freedman <dfreedm@google.com>
Date: Thu, 11 May 2017 17:45:17 -0700
Subject: [PATCH 16/31] 2.0.0-rc.8

---
 package.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package.json b/package.json
index 6c9c762042..d016053556 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@polymer/polymer",
-  "version": "2.0.0-rc.7",
+  "version": "2.0.0-rc.8",
   "description": "The Polymer library makes it easy to create your own web components. Give your element some markup and properties, and then use it on a site. Polymer provides features like dynamic templates and data binding to reduce the amount of boilerplate you need to write",
   "main": "polymer.html",
   "directories": {

From 448149d2109cc62e61c77a30b4ecb2315e329f38 Mon Sep 17 00:00:00 2001
From: Daniel Freedman <dfreedm@google.com>
Date: Thu, 11 May 2017 17:58:23 -0700
Subject: [PATCH 17/31] [ci skip] Update Changelog

---
 CHANGELOG.md | 351 +++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 351 insertions(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 7747fca641..6808cf0c2c 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,5 +1,356 @@
 # Change Log
 
+## [v2.0.0-rc.8](https://github.com/Polymer/polymer/tree/v2.0.0-rc.8) (2017-05-11)
+- Add test for boolean dynamicFn ([commit](https://github.com/Polymer/polymer/commit/03d21ce8))
+
+- Accept boolean or object map for dynamicFns ([commit](https://github.com/Polymer/polymer/commit/f197ce24))
+
+- update dependencies for v1 polyfills ([commit](https://github.com/Polymer/polymer/commit/d9b5b8f9))
+
+- Null the links when unbinding. ([commit](https://github.com/Polymer/polymer/commit/42230437))
+
+- Dedupe API docs. ([commit](https://github.com/Polymer/polymer/commit/e97a6eb7))
+
+- Move setup to suiteSetup ([commit](https://github.com/Polymer/polymer/commit/d5b282fa))
+
+- Uncomment previous tests ([commit](https://github.com/Polymer/polymer/commit/55b2d160))
+
+- Add tests ([commit](https://github.com/Polymer/polymer/commit/0f4ebf62))
+
+- [ci skip] port gen-changelog from 1.x ([commit](https://github.com/Polymer/polymer/commit/24dd897d))
+
+- Add static API for creating property fx and minor code refactoring. ([commit](https://github.com/Polymer/polymer/commit/7497065a))
+
+- [ci skip] remove bower.json version, add npm devDependencies & np publish config ([commit](https://github.com/Polymer/polymer/commit/6b6092e0))
+
+- Fix comment. ([commit](https://github.com/Polymer/polymer/commit/6f1dde76))
+
+- Fixes #4585. Data notifications do not flush host if host has not initialized clients. This preserves the Polymer 1.x guarantee that client dom is fully “readied” when data observers run. ([commit](https://github.com/Polymer/polymer/commit/3b6981d4))
+
+- Ensure no warnings for dynamic fns. Fixes #4575 ([commit](https://github.com/Polymer/polymer/commit/d72baf9d))
+
+- Corrected minor Method comments ([commit](https://github.com/Polymer/polymer/commit/8a2aeb65))
+
+- Removes the `disable-upgrade` feature from Polymer 2.0. Due to #4550, the feature has a flaw for native ES6 classes and would be better implemented as either a mixin or patch to `customElements.define`. ([commit](https://github.com/Polymer/polymer/commit/972b2bab))
+
+- Fix jsBin link. ([commit](https://github.com/Polymer/polymer/commit/811c334e))
+
+- Ensure tags in markdown are backtracked. Short-term stopgap to ensure they are not rendered in HTML. ([commit](https://github.com/Polymer/polymer/commit/e90ef30d))
+
+- Clean up gulpfile ([commit](https://github.com/Polymer/polymer/commit/764448c9))
+
+- bump wct version ([commit](https://github.com/Polymer/polymer/commit/bafa1ecd))
+
+- Disabling `lint-closure` until the error count is driven to 0 ([commit](https://github.com/Polymer/polymer/commit/c98e3799))
+
+- fix test failures on safari 9 and chrome 41 w/focus event ([commit](https://github.com/Polymer/polymer/commit/0b00f2d9))
+
+- update debounce example. ([commit](https://github.com/Polymer/polymer/commit/5be7ec99))
+
+- Fixes #4553, #4554 ([commit](https://github.com/Polymer/polymer/commit/36792f94))
+
+- save closure warnings to "closure.log" file ([commit](https://github.com/Polymer/polymer/commit/25cfc882))
+
+- use shadycss externs directly, now only 498 warnings ([commit](https://github.com/Polymer/polymer/commit/c21a63db))
+
+- add gulp task to lint for closure warnings ([commit](https://github.com/Polymer/polymer/commit/4e782741))
+
+## [v2.0.0-rc.7](https://github.com/Polymer/polymer/tree/v2.0.0-rc.7) (2017-04-19)
+- Add more tests. ([commit](https://github.com/Polymer/polymer/commit/73df8c5b))
+
+- Update jsBin template for 2.0 ([commit](https://github.com/Polymer/polymer/commit/4a2db9ca))
+
+- [ci skip] Update link to jsBin template for 2.0. ([commit](https://github.com/Polymer/polymer/commit/0aeb3170))
+
+- Move computeLinkedPaths out of hot path and into sync setter. ([commit](https://github.com/Polymer/polymer/commit/d722cb9c))
+
+- [ci skip] Add note re: purpose of test ([commit](https://github.com/Polymer/polymer/commit/7ecbf258))
+
+- Fix test for fallback \_readyClients. Fixes #4547 ([commit](https://github.com/Polymer/polymer/commit/85184e8b))
+
+- Process paths regardless of accessor, & loop on computeLinkedPaths. Fixes #4542 ([commit](https://github.com/Polymer/polymer/commit/e2d17020))
+
+## [v2.0.0-rc.6](https://github.com/Polymer/polymer/tree/v2.0.0-rc.6) (2017-04-17)
+- [ci skip] Fix API docs ([commit](https://github.com/Polymer/polymer/commit/5a4427bf))
+
+- Guard against overwriting bound values with hasOwnProperty. Fixes #4540 ([commit](https://github.com/Polymer/polymer/commit/4c023740))
+
+- [ci skip] reduce warnings ([commit](https://github.com/Polymer/polymer/commit/00f9e3eb))
+
+- fix globals for goog.reflect.objectProperty -> JSCompiler_renameProperty swap ([commit](https://github.com/Polymer/polymer/commit/8867fde5))
+
+- [ci skip] remove outdated externs file ([commit](https://github.com/Polymer/polymer/commit/626a085d))
+
+- lint and compile successfully ([commit](https://github.com/Polymer/polymer/commit/a2fa1005))
+
+- update dependencies ([commit](https://github.com/Polymer/polymer/commit/36603bc4))
+
+- Rename `setPrivate` -> `setReadOnly` ([commit](https://github.com/Polymer/polymer/commit/521ed3de))
+
+- Add `setPrivate` arg to `setProperties` ([commit](https://github.com/Polymer/polymer/commit/e6e4803f))
+
+- Never accidental test change ([commit](https://github.com/Polymer/polymer/commit/28c15caa))
+
+- Remove unused @method ([commit](https://github.com/Polymer/polymer/commit/6d636138))
+
+- Standardize @return, @param, type case. ([commit](https://github.com/Polymer/polymer/commit/8cab18b1))
+
+- Fix jsdoc warnings. ([commit](https://github.com/Polymer/polymer/commit/dab794b2))
+
+- jsdoc fixes. ([commit](https://github.com/Polymer/polymer/commit/38a13f66))
+
+- Fix jsdoc issues. ([commit](https://github.com/Polymer/polymer/commit/86d2eebc))
+
+- Fix jsdoc issues. ([commit](https://github.com/Polymer/polymer/commit/8a11c8c3))
+
+- Enable error on jsdoc mistake. ([commit](https://github.com/Polymer/polymer/commit/72a454e9))
+
+- fix @license comments & shadycss imports. Remove custom style from externs ([commit](https://github.com/Polymer/polymer/commit/59350ad4))
+
+- closure advanced compilation ([commit](https://github.com/Polymer/polymer/commit/eea1ca23))
+
+## [v2.0.0-rc.5](https://github.com/Polymer/polymer/tree/v2.0.0-rc.5) (2017-04-13)
+- Eliminate rest args for better perf on stable chrome. ([commit](https://github.com/Polymer/polymer/commit/fa67457c))
+
+- Fix perf regressions. ([commit](https://github.com/Polymer/polymer/commit/86e35e3a))
+
+- Move second tap test to the correct spot. ([commit](https://github.com/Polymer/polymer/commit/6e4b87c1))
+
+- Add GestureEventListeners to dom-bind. ([commit](https://github.com/Polymer/polymer/commit/4f628fd9))
+
+- Add more comments ([commit](https://github.com/Polymer/polymer/commit/d0bd96d4))
+
+- [ci skip] Fix comment. ([commit](https://github.com/Polymer/polymer/commit/becd1d3b))
+
+- alias another way ([commit](https://github.com/Polymer/polymer/commit/d297047e))
+
+- use chrome beta ([commit](https://github.com/Polymer/polymer/commit/0724f187))
+
+- Add more HTMLImports.whenReady ([commit](https://github.com/Polymer/polymer/commit/bc713187))
+
+- Address feedback from review: * Refactor `_bindTemplate` to remove problematic `hasCreatedAccessors` * Remove vestigial `dom` from `_bindTemplate` call * Rename `_unstampTemplate` to `_removeBoundDom` * Add `infoIndex` to `nodeInfo` (and renamed parent & index) * Add test to ensure runtime accessors created for new props in runtime stamped template * Changed custom binding test to use different prop names * Added test for #first count after removing bound dom ([commit](https://github.com/Polymer/polymer/commit/b9fafb7e))
+
+- Fix lint error. ([commit](https://github.com/Polymer/polymer/commit/dff5f2bc))
+
+- Ensure prototype wasn't affected by runtime effects. ([commit](https://github.com/Polymer/polymer/commit/bf2dbe0a))
+
+- Add tests for adding/removing runtime property effects. ([commit](https://github.com/Polymer/polymer/commit/14711067))
+
+- Added tests for custom parsing, effects, and binding. ([commit](https://github.com/Polymer/polymer/commit/1cf955b9))
+
+- Add initial runtime stamping tests. ([commit](https://github.com/Polymer/polymer/commit/eb6ab63e))
+
+- Fix changelog generation ([commit](https://github.com/Polymer/polymer/commit/8c103d98))
+
+- Address feedback based on review. * PropertyAccessors must call `_flushProperties` to enable * Avoid tearing off oldProps (unnecessary) * Add `addBinding` docs * Merge notifyListeners into `setupBindings` * Add comment re: path-bindings not being overridable * Remove `dom` argument from `_bindTemplate` * Rename `_stampBoundTemplate` back to `_stampTemplate` ([commit](https://github.com/Polymer/polymer/commit/6af84c45))
+
+- Put $ on dom, and assign to element as needed. Eliminate _templateInfo reference. ([commit](https://github.com/Polymer/polymer/commit/03bed19d))
+
+- Fix _hasAccessor for readOnly. Collapse addBinding & addBindingEffects ([commit](https://github.com/Polymer/polymer/commit/396c102c))
+
+- Improvements to binding API: - Adds override points for _parseBindings and _evaluateBinding - Adds support for runtime template binding - Moves ready(), _hasAccessor tracking, and instance property swizzle at ready time to PropertyAccessors ([commit](https://github.com/Polymer/polymer/commit/ea4e7d97))
+
+## [v2.0.0-rc.4](https://github.com/Polymer/polymer/tree/v2.0.0-rc.4) (2017-04-12)
+- fix lint error ([commit](https://github.com/Polymer/polymer/commit/e397c434))
+
+- Only style elements with templates ([commit](https://github.com/Polymer/polymer/commit/2356f7b8))
+
+- [ci skip] note safari bugs ([commit](https://github.com/Polymer/polymer/commit/ef90168b))
+
+- Various Safari 10.1 fixes ([commit](https://github.com/Polymer/polymer/commit/dea052a2))
+
+- Add `@memberof` annotation for Polymer.Debouncer ([commit](https://github.com/Polymer/polymer/commit/352878d5))
+
+- Import mutable-data.html in dom-bind ([commit](https://github.com/Polymer/polymer/commit/bbc0373c))
+
+- Correct changelog version title ([commit](https://github.com/Polymer/polymer/commit/9555ca34))
+
+- Fix readme. ([commit](https://github.com/Polymer/polymer/commit/bbfea905))
+
+- tighten up custom-style-late test ([commit](https://github.com/Polymer/polymer/commit/2106f656))
+
+- Fixes #4478 by adding a better warning for attributes that cannot deserialize from JSON. ([commit](https://github.com/Polymer/polymer/commit/dba28c06))
+
+- Adds back the `beforeRegister` method. Users can no longer set the `is` property in this method; however, dynamic property effects can still be installed here. ([commit](https://github.com/Polymer/polymer/commit/7639cf81))
+
+- Fixes #4447. Re-introduce the `hostStack` in order to maintain “client before host” ordering when `_flushProperties` is called before `connectedCallback` (e.g. as Templatize does). ([commit](https://github.com/Polymer/polymer/commit/8467a696))
+
+- Fix custom-style-late tests ([commit](https://github.com/Polymer/polymer/commit/caafef79))
+
+- Add test for ensuring complicated mixin ordering is correct ([commit](https://github.com/Polymer/polymer/commit/6d663354))
+
+- move lazy-upgrade out to separate mixins repo ([commit](https://github.com/Polymer/polymer/commit/deb5a9a5))
+
+- Only check bounding client rect on clicks that target elements ([commit](https://github.com/Polymer/polymer/commit/af37d04c))
+
+- Adds tests from https://github.com/Polymer/polymer/pull/4099. The other changes from the PR are no longer needed. ([commit](https://github.com/Polymer/polymer/commit/c5710666))
+
+- clean up code, factor processing lazy candidates, better docs ([commit](https://github.com/Polymer/polymer/commit/189a2083))
+
+- Update templatize.html ([commit](https://github.com/Polymer/polymer/commit/2abfe09e))
+
+- Doc fix (correct callback name) ([commit](https://github.com/Polymer/polymer/commit/57d22f4c))
+
+- Fixed tempaltize -> templatize typo ([commit](https://github.com/Polymer/polymer/commit/b6b43f36))
+
+- Work around IE/Edge bug with :not([attr]) selectors ([commit](https://github.com/Polymer/polymer/commit/c3036232))
+
+- Remove support for lazy-upgrade inside dom-if and dom-repeat ([commit](https://github.com/Polymer/polymer/commit/1b4a9781))
+
+- Fix image in README ([commit](https://github.com/Polymer/polymer/commit/b860594a))
+
+- Remove useless id check on mixins ([commit](https://github.com/Polymer/polymer/commit/8c1a5765))
+
+- move dom-change listener for lazy-upgrade before `super.ready()` ([commit](https://github.com/Polymer/polymer/commit/ba60b820))
+
+- [ci skip] Update doc ([commit](https://github.com/Polymer/polymer/commit/f87790d6))
+
+- [ci skip] Update doc ([commit](https://github.com/Polymer/polymer/commit/b9774801))
+
+- Add API docs. ([commit](https://github.com/Polymer/polymer/commit/1eb0df49))
+
+- nodeInfo -> nodeInfoList ([commit](https://github.com/Polymer/polymer/commit/eed67504))
+
+- Updates based on PR feedback. API docs in progress. ([commit](https://github.com/Polymer/polymer/commit/627352db))
+
+- * ensure element cannot return to “disabled” state after upgrading. * ensure nested `beforeNextRender` calls always go before the next render * ensure nested `afterNextRender` are called after additional renders ([commit](https://github.com/Polymer/polymer/commit/e9c58add))
+
+- Fixes #4437. Ensure `_registered` is called 1x for each element class using `LegacyElementMixin`. Ensure that a behaviors’s `registered` method is called for any extending class. ([commit](https://github.com/Polymer/polymer/commit/de09d730))
+
+- Separate binding-specific code from template stamp. Expose override points. ([commit](https://github.com/Polymer/polymer/commit/e95afeb1))
+
+- Use webcomponents-lite for test ([commit](https://github.com/Polymer/polymer/commit/50ae3bb7))
+
+- add lazy-upgrade tests ([commit](https://github.com/Polymer/polymer/commit/71b70aaa))
+
+- make a mixin for lazy upgrading ([commit](https://github.com/Polymer/polymer/commit/9891e484))
+
+- implements `disable-upgrade` attribute which prevents readying an element until the attribute is removed. ([commit](https://github.com/Polymer/polymer/commit/a222078e))
+
+## [v2.0.0-rc.3](https://github.com/Polymer/polymer/tree/v2.0.0-rc.3) (2017-03-15)
+- add properties, behaviors, observers, hostAttributes, listeners on prototype ([commit](https://github.com/Polymer/polymer/commit/93cf3246))
+
+- [skip ci] update test comments ([commit](https://github.com/Polymer/polymer/commit/bb52071b))
+
+- better comment ([commit](https://github.com/Polymer/polymer/commit/a081e669))
+
+- get behaviors only from prototypes ([commit](https://github.com/Polymer/polymer/commit/8bac5c60))
+
+- behaviors ONLY on the prototype ([commit](https://github.com/Polymer/polymer/commit/444c043c))
+
+- add instance behaviors ([commit](https://github.com/Polymer/polymer/commit/4bf7bdd7))
+
+- [ci skip] minor doc edits. ([commit](https://github.com/Polymer/polymer/commit/4ae65ba2))
+
+- [ci skip] expand range of dependencies to all rcs ([commit](https://github.com/Polymer/polymer/commit/46c10465))
+
+## [v2.0.0-rc.2](https://github.com/Polymer/polymer/tree/v2.0.0-rc.2) (2017-03-07)
+- another test fix. ([commit](https://github.com/Polymer/polymer/commit/d9418e1a))
+
+- fix behavior warn test. ([commit](https://github.com/Polymer/polymer/commit/4439436f))
+
+- update to latest webcompnents rc. ([commit](https://github.com/Polymer/polymer/commit/46219a39))
+
+- move mutable data mixin to be loaded by polymer.html ([commit](https://github.com/Polymer/polymer/commit/7cebe120))
+
+- Fix 4387. Ensure `dom-change` fired with `composed: true`. ([commit](https://github.com/Polymer/polymer/commit/3e683297))
+
+- Allow hybrid elements (like iron-list) to make template instances with mutable data ([commit](https://github.com/Polymer/polymer/commit/ea392e3f))
+
+- Don't override the goog namespace if it already exists ([commit](https://github.com/Polymer/polymer/commit/b30deb22))
+
+- Use correct version ([commit](https://github.com/Polymer/polymer/commit/3b7d4484))
+
+- Fix spelling error ([commit](https://github.com/Polymer/polymer/commit/c14ea57f))
+
+- [ci skip] Fix note re: transpilation ([commit](https://github.com/Polymer/polymer/commit/8fd1b212))
+
+- [ci skip] Remove obsolete note re: pre-upgrade attribute vs. property priority ([commit](https://github.com/Polymer/polymer/commit/3dd776fe))
+
+- [ci skip] Fix note re: attached ([commit](https://github.com/Polymer/polymer/commit/b67736ec))
+
+- [ci skip] Add back intro README content from 1.x, updated to 2.x syntax. ([commit](https://github.com/Polymer/polymer/commit/1235f449))
+
+## [v2.0.0-rc.1](https://github.com/Polymer/polymer/tree/v2.0.0-rc.1) (2017-03-06)
+
+<!-- the changelog tool broke, so this is ported from https://www.polymer-project.org/2.0/docs/release-notes#v-2-0-0-rc.1 -->
+The following notable changes have been made since the 2.0 Preview announcement.
+
+-   The `config` getter on element classes has been replaced by individual `properties` and
+    `observers` getters, more closely resembling the 1.x syntax.
+
+    ```js
+    static get properties() {
+      return {
+        aProp: String,
+        bProp: Number
+      }
+    }
+    static get observers() {
+      return [
+        '_observeStuff(aProp,bProp)'
+      ]
+    }
+    ```
+
+-   1.x-style dirty checking has been reinstated for better performance. An optional mixin is
+    available for elements to skip dirty checking of objects and arrays, which may be more easy to
+    integrate with some state management systems. For details, see
+    [Using the MutableData mixin](devguide/data-system#mutable-data) in Data system concepts.
+
+-   Support for dynamically-created `custom-style` elements has been added.
+
+-   Support for the external style sheet syntax, `<link rel="import" type="css">` has
+    been added. This was deprecated in 1.x, but will be retained until an alternate solution is
+    available for importing unprocessed CSS.
+
+-   New properties `rootPath` and `basePath` were added to `Polymer.Element` to allow authors
+    to configure how URLs are rewritten inside templates. For details, see the
+    [Update URLs in templates](./upgrade#urls-in-templates) in the Upgrade guide.
+
+
+## [v1.9.1-dev](https://github.com/Polymer/polymer/tree/v1.9.1-dev) (2017-04-17)
+- Remove use of ES6 API. ([commit](https://github.com/Polymer/polymer/commit/96010657))
+
+- Remove use of ES6 API. ([commit](https://github.com/Polymer/polymer/commit/646dce69))
+
+- Ensure optimization uses hybrid parentNode ([commit](https://github.com/Polymer/polymer/commit/b7f00992))
+
+- Use local `parentNode` ([commit](https://github.com/Polymer/polymer/commit/2e4290f8))
+
+- Capture hybridDomRepeat. ([commit](https://github.com/Polymer/polymer/commit/ee3b9a69))
+
+- Fix dom-if detachment ([commit](https://github.com/Polymer/polymer/commit/2722532b))
+
+- Add dom-if test for add/remove. ([commit](https://github.com/Polymer/polymer/commit/a2825650))
+
+- Add test for add & remove ([commit](https://github.com/Polymer/polymer/commit/4c87e1d9))
+
+- Add 2.x hybrid affordances for stamping template content. Fixes #4536 ([commit](https://github.com/Polymer/polymer/commit/53053eb4))
+
+- Fix lint ([commit](https://github.com/Polymer/polymer/commit/f29104f2))
+
+- Make tests more strict. ([commit](https://github.com/Polymer/polymer/commit/ea65a6d0))
+
+- Use `_importPath` in `resolveUrl` so it available early. Fixes #4532 ([commit](https://github.com/Polymer/polymer/commit/1a7d3b11))
+
+- [ci skip] update Changelog ([commit](https://github.com/Polymer/polymer/commit/3ce4e176))
+
+## [v1.9.0-dev](https://github.com/Polymer/polymer/tree/v1.9.0-dev) (2017-04-13)
+- [ci skip] skip looking in build log, again ([commit](https://github.com/Polymer/polymer/commit/1d282c7f))
+
+- [ci skip] backport changelog fixes ([commit](https://github.com/Polymer/polymer/commit/d6a7ac71))
+
+- * allow setting `rootPath` * disallow setting `importPath` (this is supported in 2.x but not 1.x) ([commit](https://github.com/Polymer/polymer/commit/ac067652))
+
+- Add `importPath` and `rootPath` to support 2.x hybrid compatible elements. ([commit](https://github.com/Polymer/polymer/commit/daaf460a))
+
+- [ci skip] Update Changelog ([commit](https://github.com/Polymer/polymer/commit/80c899f4))
+
+- Add missing semicolon after variable assignment ([commit](https://github.com/Polymer/polymer/commit/afb21c8f))
+
+- Update PRIMER.md ([commit](https://github.com/Polymer/polymer/commit/4d66a353))
+
 ## [v1.8.1-dev](https://github.com/Polymer/polymer/tree/v1.8.1-dev) (2017-02-27)
 - Exclude SD polyfill tests for Edge due to lack of workarounds for Edge DocFrag bugs. ([commit](https://github.com/Polymer/polymer/commit/de45ba02))
 

From 90e8cd9502bc2f442a2552d9f8d802eab00bd035 Mon Sep 17 00:00:00 2001
From: Daniel Freedman <dfreedm@google.com>
Date: Fri, 12 May 2017 11:47:21 -0700
Subject: [PATCH 18/31] [ci skip] Fix doc createPropertyEffect ->
 addPropertyEffect

---
 lib/mixins/property-effects.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/mixins/property-effects.html b/lib/mixins/property-effects.html
index 7c8c16ceba..b45e7453b9 100644
--- a/lib/mixins/property-effects.html
+++ b/lib/mixins/property-effects.html
@@ -1029,7 +1029,7 @@
    *
    * This mixin uses provides the following key static methods for adding
    * property effects to an element class:
-   * - `createPropertyEffect`
+   * - `addPropertyEffect`
    * - `createPropertyObserver`
    * - `createMethodObserver`
    * - `createNotifyingProperty`

From c6f9b31578fd3b0da2c8feca46939cd679a9859c Mon Sep 17 00:00:00 2001
From: Steven Orvell <sorvell@google.com>
Date: Fri, 12 May 2017 11:50:27 -0700
Subject: [PATCH 19/31] Adds `_enableProperties` as a new entry point that must
 be called to turn on properties. Prevents a bug where `_readyClients` can be
 called twice.

---
 lib/elements/dom-bind.html         |  2 +-
 lib/mixins/element-mixin.html      |  4 +---
 lib/mixins/property-accessors.html | 22 +++++++++++++---------
 lib/mixins/property-effects.html   | 17 ++++++++++-------
 lib/utils/templatize.html          |  4 ++--
 test/unit/property-accessors.html  |  2 +-
 test/unit/property-effects.html    |  2 +-
 7 files changed, 29 insertions(+), 24 deletions(-)

diff --git a/lib/elements/dom-bind.html b/lib/elements/dom-bind.html
index 436791d85c..19497e0d32 100644
--- a/lib/elements/dom-bind.html
+++ b/lib/elements/dom-bind.html
@@ -103,7 +103,7 @@
           for (let n=this.root.firstChild; n; n=n.nextSibling) {
             this.__children[this.__children.length] = n;
           }
-          this._flushProperties();
+          this._enableProperties();
         }
         this.__insertChildren();
         this.dispatchEvent(new CustomEvent('dom-change', {
diff --git a/lib/mixins/element-mixin.html b/lib/mixins/element-mixin.html
index 9465d1d034..41d7551767 100644
--- a/lib/mixins/element-mixin.html
+++ b/lib/mixins/element-mixin.html
@@ -631,9 +631,7 @@
         if (window.ShadyCSS && this._template) {
           window.ShadyCSS.styleElement(this);
         }
-        if (!this.__dataInitialized) {
-          this._flushProperties();
-        }
+        this._enableProperties();
       }
 
       /**
diff --git a/lib/mixins/property-accessors.html b/lib/mixins/property-accessors.html
index a586f31a2d..7104d229f8 100644
--- a/lib/mixins/property-accessors.html
+++ b/lib/mixins/property-accessors.html
@@ -475,6 +475,18 @@
         }
       }
 
+      // TODO(kschaaf): document.
+      _enableProperties() {
+        if (!this.__dataPropertiesEnabled) {
+          this.__dataPropertiesEnabled = true;
+          if (this.__dataInstanceProps) {
+            this._initializeInstanceProperties(this.__dataInstanceProps);
+            this.__dataInstanceProps = null;
+          }
+          this.ready()
+        }
+      }
+
       /**
        * Calls the `_propertiesChanged` callback with the current set of
        * pending changes (and old values recorded when pending changes were
@@ -487,9 +499,7 @@
        * @protected
        */
       _flushProperties() {
-        if (!this.__dataInitialized) {
-          this.ready()
-        } else if (this.__dataPending) {
+        if (this.__dataPending) {
           let changedProps = this.__dataPending;
           this.__dataPending = null;
           this.__dataCounter++;
@@ -513,12 +523,6 @@
        * @public
        */
       ready() {
-        // Update instance properties that shadowed proto accessors; these take
-        // priority over any defaults set in constructor or attributeChangedCallback
-        if (this.__dataInstanceProps) {
-          this._initializeInstanceProperties(this.__dataInstanceProps);
-          this.__dataInstanceProps = null;
-        }
         this.__dataInitialized = true;
         // Run normal flush
         this._flushProperties();
diff --git a/lib/mixins/property-effects.html b/lib/mixins/property-effects.html
index b45e7453b9..4bb5ea43b4 100644
--- a/lib/mixins/property-effects.html
+++ b/lib/mixins/property-effects.html
@@ -230,9 +230,8 @@
     // And the host has already initialized clients; this prevents
     // an issue with a host observing data changes before clients are ready.
     let host;
-    if (notified && (host = inst.__dataHost) && host._flushProperties
-      && host.__dataClientsInitialized) {
-      host._flushProperties();
+    if (notified && (host = inst.__dataHost) && host._invalidateProperties) {
+      host._invalidateProperties();
     }
   }
 
@@ -1430,6 +1429,7 @@
        */
       _flushClients() {
         if (!this.__dataClientsInitialized) {
+          this.__dataClientsInitialized = true;
           this._readyClients();
         }
         // Flush all clients
@@ -1438,7 +1438,10 @@
           this.__dataPendingClients = null;
           for (let i=0; i < clients.length; i++) {
             let client = clients[i];
-            if (!client.__dataInitialized || client.__dataPending) {
+            // boot up client if necessary, otherwise flush properties
+            if (!client.__dataPropertiesEnabled) {
+              client._enableProperties();
+            } else if (client.__dataPending) {
               client._flushProperties();
             }
           }
@@ -1479,9 +1482,9 @@
        * @override
        */
       ready() {
-        super.ready();
+        this._flushProperties();
         if (!this.__dataClientsInitialized) {
-          this._readyClients();
+          this._flushClients();
         }
         // Before ready, client notifications do not trigger _flushProperties.
         // Therefore a flush is necessary here if data has been set.
@@ -1498,7 +1501,7 @@
        * @protected
        */
       _readyClients() {
-        this.__dataClientsInitialized = true;
+        this.__dataInitialized = true;
       }
 
       /**
diff --git a/lib/utils/templatize.html b/lib/utils/templatize.html
index 456c01510f..31f792ec55 100644
--- a/lib/utils/templatize.html
+++ b/lib/utils/templatize.html
@@ -63,7 +63,7 @@
         // or when there isn't instance props.
         let options = this.__templatizeOptions;
         if ((props && options.instanceProps) || !options.instanceProps) {
-          this._flushProperties();
+          this._enableProperties();
         }
       }
       /**
@@ -251,7 +251,7 @@
         template.__dataTemp = {};
         template.__dataPending = null;
         template.__dataOld = null;
-        template._flushProperties();
+        template._enableProperties();
       }
     }
 
diff --git a/test/unit/property-accessors.html b/test/unit/property-accessors.html
index 9fb9a4f61c..8af5eeb265 100644
--- a/test/unit/property-accessors.html
+++ b/test/unit/property-accessors.html
@@ -29,7 +29,7 @@
         this._propertiesChanged = sinon.spy();
       }
       connectedCallback() {
-        this._flushProperties();
+        this._enableProperties();
       }
     }
     XFoo.createPropertiesForAttributes();
diff --git a/test/unit/property-effects.html b/test/unit/property-effects.html
index c1be29da2d..b236897d5b 100644
--- a/test/unit/property-effects.html
+++ b/test/unit/property-effects.html
@@ -1514,7 +1514,7 @@
     BaseClass = class extends Polymer.PropertyEffects(HTMLElement) {
       connectedCallback() {
         this.pcSpy = sinon.spy();
-        this._flushProperties();
+        this._enableProperties();
       }
       _propertiesChanged(props, changedProps, oldProps) {
         this.pcSpy(props, changedProps, oldProps);

From 2f1e964c1ff7d622bc0e8965b031875e0bbc5e32 Mon Sep 17 00:00:00 2001
From: Steven Orvell <sorvell@google.com>
Date: Fri, 12 May 2017 12:30:59 -0700
Subject: [PATCH 20/31] Turn on accessors (via __dataInitialized) only after
 clients have completely flushed.

---
 lib/mixins/property-effects.html | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/lib/mixins/property-effects.html b/lib/mixins/property-effects.html
index 4bb5ea43b4..adfe6e26fc 100644
--- a/lib/mixins/property-effects.html
+++ b/lib/mixins/property-effects.html
@@ -1446,6 +1446,7 @@
             }
           }
         }
+        this.__dataInitialized = true;
       }
 
       /**
@@ -1500,9 +1501,7 @@
        *
        * @protected
        */
-      _readyClients() {
-        this.__dataInitialized = true;
-      }
+      _readyClients() {}
 
       /**
        * Implements `PropertyAccessors`'s properties changed callback.

From c7a81ea8a52e748a8ebd0ad321cd0b9ce9723d72 Mon Sep 17 00:00:00 2001
From: Kevin Schaaf <kschaaf@google.com>
Date: Fri, 12 May 2017 13:06:50 -0700
Subject: [PATCH 21/31] Move hostStack to property-effects and make
 readyClients explicit

---
 lib/mixins/element-mixin.html    | 50 ------------------
 lib/mixins/property-effects.html | 87 +++++++++++++++++++++++++++-----
 2 files changed, 73 insertions(+), 64 deletions(-)

diff --git a/lib/mixins/element-mixin.html b/lib/mixins/element-mixin.html
index 41d7551767..9f2733d234 100644
--- a/lib/mixins/element-mixin.html
+++ b/lib/mixins/element-mixin.html
@@ -576,7 +576,6 @@
        */
       _initializeProperties() {
         Polymer.telemetry.instanceCount++;
-        hostStack.registerHost(this);
         this.constructor.finalize();
         const importPath = this.constructor.importPath;
         // note: finalize template when we have access to `localName` to
@@ -649,9 +648,7 @@
        */
       ready() {
         if (this._template) {
-          hostStack.beginHosting(this);
           this.root = this._stampTemplate(this._template);
-          hostStack.endHosting(this);
           this.$ = this.root.$;
         }
         super.ready();
@@ -785,53 +782,6 @@
     return PolymerElement;
   });
 
-  /**
-   * Helper api for enqueing client dom created by a host element.
-   *
-   * By default elements are flushed via `_flushProperties` when
-   * `connectedCallback` is called. Elements attach their client dom to
-   * themselves at `ready` time which results from this first flush.
-   * This provides an ordering guarantee that the client dom an element
-   * creates is flushed before the element itself (i.e. client `ready`
-   * fires before host `ready`).
-   *
-   * However, if `_flushProperties` is called *before* an element is connected,
-   * as for example `Templatize` does, this ordering guarantee cannot be
-   * satisfied because no elements are connected. (Note: Bound elements that
-   * receive data do become enqueued clients and are properly ordered but
-   * unbound elements are not.)
-   *
-   * To maintain the desired "client before host" ordering guarantee for this
-   * case we rely on the "host stack. Client nodes registers themselves with
-   * the creating host element when created. This ensures that all client dom
-   * is readied in the proper order, maintaining the desired guarantee.
-   *
-   * @private
-   */
-  let hostStack = {
-
-    stack: [],
-
-    registerHost(inst) {
-      if (this.stack.length) {
-        let host = this.stack[this.stack.length-1];
-        host._enqueueClient(inst);
-      }
-    },
-
-    beginHosting(inst) {
-      this.stack.push(inst);
-    },
-
-    endHosting(inst) {
-      let stackLen = this.stack.length;
-      if (stackLen && this.stack[stackLen-1] == inst) {
-        this.stack.pop();
-      }
-    }
-
-  }
-
   /**
    * Provides basic tracking of element definitions (registrations) and
    * instance counts.
diff --git a/lib/mixins/property-effects.html b/lib/mixins/property-effects.html
index adfe6e26fc..917f29fa03 100644
--- a/lib/mixins/property-effects.html
+++ b/lib/mixins/property-effects.html
@@ -1086,6 +1086,7 @@
        */
       _initializeProperties() {
         super._initializeProperties();
+        hostStack.registerHost(this);
         this.__dataClientsInitialized = false;
         this.__dataPendingClients = null;
         this.__dataToNotify = null;
@@ -1431,22 +1432,40 @@
         if (!this.__dataClientsInitialized) {
           this.__dataClientsInitialized = true;
           this._readyClients();
+          this.__dataInitialized = true;
+        } else {
+          // Flush all clients
+          let clients = this.__dataPendingClients;
+          if (clients) {
+            this.__dataPendingClients = null;
+            for (let i=0; i < clients.length; i++) {
+              let client = clients[i];
+              if (client.__dataPending) {
+                client._flushProperties();
+              }
+            }
+          }
         }
-        // Flush all clients
+      }
+
+      /**
+       * Perform any initial setup on client dom. Called before the first
+       * `_flushProperties` call on client dom and before any element
+       * observers are called.
+       *
+       * @protected
+       */
+      _readyClients() {
         let clients = this.__dataPendingClients;
         if (clients) {
           this.__dataPendingClients = null;
           for (let i=0; i < clients.length; i++) {
             let client = clients[i];
-            // boot up client if necessary, otherwise flush properties
             if (!client.__dataPropertiesEnabled) {
               client._enableProperties();
-            } else if (client.__dataPending) {
-              client._flushProperties();
             }
           }
         }
-        this.__dataInitialized = true;
       }
 
       /**
@@ -1494,15 +1513,6 @@
         }
       }
 
-      /**
-       * Perform any initial setup on client dom. Called before the first
-       * `_flushProperties` call on client dom and before any element
-       * observers are called.
-       *
-       * @protected
-       */
-      _readyClients() {}
-
       /**
        * Implements `PropertyAccessors`'s properties changed callback.
        *
@@ -2205,7 +2215,9 @@
        * @protected
        */
       _stampTemplate(template) {
+        hostStack.beginHosting(this);
         let dom = super._stampTemplate(template);
+        hostStack.endHosting(this);
         let templateInfo = this._bindTemplate(template, true);
         // Add template-instance-specific data to instanced templateInfo
         templateInfo.nodeList = dom.nodeList;
@@ -2505,5 +2517,52 @@
     return PropertyEffects;
   });
 
+  /**
+   * Helper api for enqueing client dom created by a host element.
+   *
+   * By default elements are flushed via `_flushProperties` when
+   * `connectedCallback` is called. Elements attach their client dom to
+   * themselves at `ready` time which results from this first flush.
+   * This provides an ordering guarantee that the client dom an element
+   * creates is flushed before the element itself (i.e. client `ready`
+   * fires before host `ready`).
+   *
+   * However, if `_flushProperties` is called *before* an element is connected,
+   * as for example `Templatize` does, this ordering guarantee cannot be
+   * satisfied because no elements are connected. (Note: Bound elements that
+   * receive data do become enqueued clients and are properly ordered but
+   * unbound elements are not.)
+   *
+   * To maintain the desired "client before host" ordering guarantee for this
+   * case we rely on the "host stack. Client nodes registers themselves with
+   * the creating host element when created. This ensures that all client dom
+   * is readied in the proper order, maintaining the desired guarantee.
+   *
+   * @private
+   */
+  let hostStack = {
+
+    stack: [],
+
+    registerHost(inst) {
+      if (this.stack.length) {
+        let host = this.stack[this.stack.length-1];
+        host._enqueueClient(inst);
+      }
+    },
+
+    beginHosting(inst) {
+      this.stack.push(inst);
+    },
+
+    endHosting(inst) {
+      let stackLen = this.stack.length;
+      if (stackLen && this.stack[stackLen-1] == inst) {
+        this.stack.pop();
+      }
+    }
+
+  }
+
 })();
 </script>

From 1f83fd7ce0229225e647bc843da2b0399caed36a Mon Sep 17 00:00:00 2001
From: Steven Orvell <sorvell@google.com>
Date: Fri, 12 May 2017 15:12:52 -0700
Subject: [PATCH 22/31] Add tests.

---
 test/unit/property-effects-elements.html | 33 ++++++++++++++++++++++++
 test/unit/property-effects.html          | 31 ++++++++++++++++++++++
 2 files changed, 64 insertions(+)

diff --git a/test/unit/property-effects-elements.html b/test/unit/property-effects-elements.html
index aeb74816c1..0d9853cde0 100644
--- a/test/unit/property-effects-elements.html
+++ b/test/unit/property-effects-elements.html
@@ -421,6 +421,39 @@
   </script>
 </dom-module>
 
+<dom-module id="x-handle-notify-event">
+  <template>
+    <slot name="drawer"></slot>
+    <div id="before"></div>
+    <x-basic id="basic1"
+      on-notifyingvalue-with-default-changed="handleNotify">
+    </x-basic>
+    <div id="later"></div>
+  </template>
+  <script>
+    Polymer({
+      is: 'x-handle-notify-event',
+      properties: {
+        prop: {
+          observer: 'propChanged'
+        }
+      },
+      created: function() {
+        this.readySpy = sinon.spy();
+        this.afterSettingProp = sinon.spy();
+        this.propChanged = sinon.spy();
+        this.handleNotify = sinon.spy(function() {
+          this.prop = 'prop';
+          this.afterSettingProp();
+        });
+      },
+      ready: function() {
+        this.readySpy();
+      }
+    });
+  </script>
+</dom-module>
+
 <script>
   Polymer({
     is: 'x-reflect',
diff --git a/test/unit/property-effects.html b/test/unit/property-effects.html
index b236897d5b..bc6404e0c0 100644
--- a/test/unit/property-effects.html
+++ b/test/unit/property-effects.html
@@ -633,6 +633,37 @@
 
 });
 
+suite('handling notifying evevnts', function() {
+
+  test('handle notifcation event and set property with observer when connected', function() {
+    var el = document.createElement('x-handle-notify-event');
+    document.body.appendChild(el);
+    assert.ok(el.shadowRoot.querySelector('#before'), 'element not found before default notifying elmeent');
+    assert.ok(el.shadowRoot.querySelector('#later'), 'element not found after default notifying elmeent');
+    assert.isTrue(el.readySpy.calledOnce, 'ready called more than once');
+    assert.isTrue(el.handleNotify.calledOnce, 'listener called more than once');
+    assert.isTrue(el.propChanged.calledOnce, 'observer called more than once');
+    assert.isTrue(el.handleNotify.calledBefore(el.propChanged), 'observer called before event');
+    assert.isTrue(el.afterSettingProp.calledBefore(el.propChanged), 'accessor side effect processed during notifying event (before clients ready)');
+    assert.isTrue(el.propChanged.calledBefore(el.readySpy), 'observer called before ready');
+    document.body.removeChild(el);
+  });
+
+  test('handle notifcation event and set property with observer when *not* connected and _enableProperties called', function() {
+    var el = document.createElement('x-handle-notify-event');
+    el._enableProperties();
+    assert.ok(el.shadowRoot.querySelector('#before'), 'element not found before default notifying elmeent');
+    assert.ok(el.shadowRoot.querySelector('#later'), 'element not found after default notifying elmeent');
+    assert.isTrue(el.readySpy.calledOnce, 'ready called more than once');
+    assert.isTrue(el.handleNotify.calledOnce, 'listener called more than once');
+    assert.isTrue(el.propChanged.calledOnce, 'observer called more than once');
+    assert.isTrue(el.handleNotify.calledBefore(el.propChanged), 'observer called before event');
+    assert.isTrue(el.afterSettingProp.calledBefore(el.propChanged), 'accessor side effect processed during notifying event (before clients ready)');
+    assert.isTrue(el.propChanged.calledBefore(el.readySpy), 'observer called before ready');
+  });
+
+});
+
 suite('1-way binding effects between elements', function() {
 
   var el;

From 4eb252fefd74cdcdc2f6ecd12deb5087367e50a2 Mon Sep 17 00:00:00 2001
From: Steven Orvell <sorvell@google.com>
Date: Fri, 12 May 2017 15:29:55 -0700
Subject: [PATCH 23/31] Docs and slight renaming.

---
 lib/mixins/property-accessors.html | 19 ++++++++++++-------
 lib/mixins/property-effects.html   | 16 +++++++++++++---
 2 files changed, 25 insertions(+), 10 deletions(-)

diff --git a/lib/mixins/property-accessors.html b/lib/mixins/property-accessors.html
index 7104d229f8..bddf9d4fca 100644
--- a/lib/mixins/property-accessors.html
+++ b/lib/mixins/property-accessors.html
@@ -137,6 +137,7 @@
       _initializeProperties() {
         this.__serializing = false;
         this.__dataCounter = 0;
+        this.__dataEnabled = false;
         this.__dataInitialized = false;
         this.__dataInvalid = false;
         // initialize data with prototype values saved when creating accessors
@@ -475,10 +476,16 @@
         }
       }
 
-      // TODO(kschaaf): document.
+      /**
+       * Call to enable property accessors. This method must be called
+       * for any side effects of setting properties to occur. For elements,
+       * generally `connectedCallback` is a normal spot to do so.
+       * It is safe to call this method multiple times as it only turns
+       * on property accessors once.
+       */
       _enableProperties() {
-        if (!this.__dataPropertiesEnabled) {
-          this.__dataPropertiesEnabled = true;
+        if (!this.__dataEnabled) {
+          this.__dataEnabled = true;
           if (this.__dataInstanceProps) {
             this._initializeInstanceProperties(this.__dataInstanceProps);
             this.__dataInstanceProps = null;
@@ -490,11 +497,9 @@
       /**
        * Calls the `_propertiesChanged` callback with the current set of
        * pending changes (and old values recorded when pending changes were
-       * set), and resets the pending set of changes.
+       * set), and resets the pending set of changes. Generally, this method
+       * should not be called in user code.
        *
-       * Note that this method must be called once to enable the property
-       * accessors system.  For elements, generally `connectedCallback`
-       * is a normal spot to do so.
        *
        * @protected
        */
diff --git a/lib/mixins/property-effects.html b/lib/mixins/property-effects.html
index 917f29fa03..0591094250 100644
--- a/lib/mixins/property-effects.html
+++ b/lib/mixins/property-effects.html
@@ -1461,7 +1461,7 @@
           this.__dataPendingClients = null;
           for (let i=0; i < clients.length; i++) {
             let client = clients[i];
-            if (!client.__dataPropertiesEnabled) {
+            if (!client.__dataEnabled) {
               client._enableProperties();
             }
           }
@@ -1496,13 +1496,21 @@
       }
 
       /**
-       * Overrides `PropertyAccessors` to call `_readyClients` callback
-       * if it was not called as a result of flushing properties.
+       * Overrides `PropertyAccessors` so that property accessor
+       * side effects are not enabled until after client dom is fully ready.
+       * Also calls `_flushClients` callback to ensure client dom is enabled
+       * that was not enabled as a result of flushing properties.
        *
        * @override
        */
       ready() {
+        // It is important that `super.ready()` is not called here as it
+        // immediately turns on accessors. Instead, we wait until `readyClients`
+        // to enable accessors to provide a guarantee that clients are ready
+        // before processing any accessors side effects.
         this._flushProperties();
+        // If no data was pending, `_flushProperties` will not `flushClients`
+        // so ensure this is done.
         if (!this.__dataClientsInitialized) {
           this._flushClients();
         }
@@ -2215,6 +2223,8 @@
        * @protected
        */
       _stampTemplate(template) {
+        // Ensures that created dom is `_enqueueClient`'d to this element so
+        // that it can be flushed on next call to `_flushProperties`
         hostStack.beginHosting(this);
         let dom = super._stampTemplate(template);
         hostStack.endHosting(this);

From b943aa0d0bc8946562eeaa7f93bc6736efbe4a1a Mon Sep 17 00:00:00 2001
From: Steven Orvell <sorvell@google.com>
Date: Fri, 12 May 2017 19:52:57 -0700
Subject: [PATCH 24/31] [skip ci] doc fixes

---
 lib/mixins/property-accessors.html | 11 ++++++-----
 lib/mixins/property-effects.html   |  3 +++
 2 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/lib/mixins/property-accessors.html b/lib/mixins/property-accessors.html
index bddf9d4fca..b429459c05 100644
--- a/lib/mixins/property-accessors.html
+++ b/lib/mixins/property-accessors.html
@@ -477,11 +477,12 @@
       }
 
       /**
-       * Call to enable property accessors. This method must be called
-       * for any side effects of setting properties to occur. For elements,
-       * generally `connectedCallback` is a normal spot to do so.
-       * It is safe to call this method multiple times as it only turns
-       * on property accessors once.
+       * Call to enable property accessor processing. Before this method is
+       * called accessor values will be set but side effects are
+       * queued. When called, any pending side effects occur immediately.
+       * For elements, generally `connectedCallback` is a normal spot to do so.
+       * It is safe to call this method multiple times as it only turns on
+       * property accessors once.
        */
       _enableProperties() {
         if (!this.__dataEnabled) {
diff --git a/lib/mixins/property-effects.html b/lib/mixins/property-effects.html
index 0591094250..59ef27e49e 100644
--- a/lib/mixins/property-effects.html
+++ b/lib/mixins/property-effects.html
@@ -1432,6 +1432,9 @@
         if (!this.__dataClientsInitialized) {
           this.__dataClientsInitialized = true;
           this._readyClients();
+          // Override point where accessors are turned on; importantly,
+          // this is after clients have fully readied, providing a guarantee
+          // that any property effects occur only after all clients are ready.
           this.__dataInitialized = true;
         } else {
           // Flush all clients

From e54bc5f88cd61a28e06301641cc094d24e925646 Mon Sep 17 00:00:00 2001
From: Kevin Schaaf <kschaaf@google.com>
Date: Fri, 12 May 2017 20:30:53 -0700
Subject: [PATCH 25/31] [ci skip] Add alacarte usage smoke tests.

---
 test/smoke/alacarte-property-accessors.html   |  57 ++++++++
 .../alacarte-property-effects-ordering.html   | 129 ++++++++++++++++++
 test/smoke/alacarte-property-effects.html     |  86 ++++++++++++
 test/smoke/alacarte-template-stamp.html       |  94 +++++++++++++
 4 files changed, 366 insertions(+)
 create mode 100644 test/smoke/alacarte-property-accessors.html
 create mode 100644 test/smoke/alacarte-property-effects-ordering.html
 create mode 100644 test/smoke/alacarte-property-effects.html
 create mode 100644 test/smoke/alacarte-template-stamp.html

diff --git a/test/smoke/alacarte-property-accessors.html b/test/smoke/alacarte-property-accessors.html
new file mode 100644
index 0000000000..4f9cce6136
--- /dev/null
+++ b/test/smoke/alacarte-property-accessors.html
@@ -0,0 +1,57 @@
+<!--
+@license
+Copyright (c) 2017 The Polymer Project Authors. All rights reserved.
+This code may only be used under the BSD style license found at http://polymer.github.io/LICENSE.txt
+The complete set of authors may be found at http://polymer.github.io/AUTHORS.txt
+The complete set of contributors may be found at http://polymer.github.io/CONTRIBUTORS.txt
+Code distributed by Google as part of the polymer project is also
+subject to an additional IP rights grant found at http://polymer.github.io/PATENTS.txt
+-->
+<!DOCTYPE html>
+<html>
+<head>
+  <meta charset="utf-8">
+  <meta name="viewport" content="width=device-width">
+  <script src="../../../webcomponentsjs/webcomponents-lite.js"></script>
+  <link rel="import" href="../../lib/mixins/property-accessors.html">
+</head>
+<body>
+
+<script>
+
+  // Apply mixins to base class
+  class MyElement extends Polymer.PropertyAccessors(HTMLElement) {
+
+    // Declare observed attributes
+    static get observedAttributes() { return ['foo', 'bar']; }
+
+    // Enable accessors and flush any queued property changes
+    connectedCallback() {
+      this._enableProperties();
+    }
+
+    // React to changes
+    _propertiesChanged(currentProps, changedProps, oldProps) {
+      for (let p in changedProps) {
+        this.innerHTML += `${p}: ${changedProps[p]}<br>`;
+      }
+    }
+
+  }
+
+  // Generate property accessors for all observed attributes
+  MyElement.createPropertiesForAttributes();
+
+  // Register element
+  customElements.define('my-element', MyElement);
+
+</script>
+
+<my-element foo="5" bar="10"></my-element>
+
+<script>
+  document.querySelector('my-element').foo = 20;
+</script>
+
+</body>
+</html>
\ No newline at end of file
diff --git a/test/smoke/alacarte-property-effects-ordering.html b/test/smoke/alacarte-property-effects-ordering.html
new file mode 100644
index 0000000000..d88f9f90cb
--- /dev/null
+++ b/test/smoke/alacarte-property-effects-ordering.html
@@ -0,0 +1,129 @@
+<!--
+@license
+Copyright (c) 2017 The Polymer Project Authors. All rights reserved.
+This code may only be used under the BSD style license found at http://polymer.github.io/LICENSE.txt
+The complete set of authors may be found at http://polymer.github.io/AUTHORS.txt
+The complete set of contributors may be found at http://polymer.github.io/CONTRIBUTORS.txt
+Code distributed by Google as part of the polymer project is also
+subject to an additional IP rights grant found at http://polymer.github.io/PATENTS.txt
+-->
+<!DOCTYPE html>
+<html>
+<head>
+  <meta charset="utf-8">
+  <meta name="viewport" content="width=device-width">
+  <script src="../../../webcomponentsjs/webcomponents-lite.js"></script>
+  <link rel="import" href="../../polymer-element.html">
+</head>
+<body>
+
+<template id="my-element-template">
+  <style>
+     :host {
+       display: block;
+     }
+    #counter {
+      padding: 10px;
+      background: lightblue;
+    }
+  </style>
+  <!-- can use declarative event listeners -->
+  <button on-click="handleIncrement">Increment!</button>
+  <span id="counter">[[limited]]</span>
+  <x-a prop="[[limited]]"></x-a>
+  <x-b></x-b>
+</template>
+
+<script>
+
+  customElements.define('x-a', class extends Polymer.Element {
+    static get observers() { return ['propChanged(prop)']; }
+    constructor() {
+      super();
+      this.prop = 99;
+    }
+    propChanged(prop) {
+      console.log(this.localName, 'propChanged', prop);
+      this.textContent = prop;
+    }
+    ready() {
+      super.ready();
+      console.log(this.localName, 'ready');
+    }
+  });
+
+  customElements.define('x-b', class extends Polymer.Element {
+    static get observers() { return ['propChanged(prop)']; }
+    constructor() {
+      super();
+      this.prop = 77;
+    }
+    propChanged(prop) {
+      console.log(this.localName, 'propChanged', prop);
+      this.textContent = prop;
+    }
+    ready() {
+      super.ready();
+      console.log(this.localName, 'ready');
+    }
+  });
+
+  let template = document.getElementById('my-element-template');
+
+  // Apply mixins to base class
+  let MyBaseClass = Polymer.PropertyEffects(HTMLElement);
+
+  class MyElement extends MyBaseClass {
+
+    // Declare observed attributes
+    static get observedAttributes() { return ['counter', 'limit']; }
+
+    constructor() {
+      super();
+      this.counter = 0;
+      this.limit = Infinity;
+    }
+
+    // Enable accessors and flush any queued property changes
+    connectedCallback() {
+      this._enableProperties();
+    }
+
+    // Called once by PropertyAccessors during first property flush
+    // Do one-time work like setting up Shadow DOM
+    ready() {
+      console.log(this.localName, 'before ready');
+      this.dom = this._stampTemplate(template);
+      super.ready();
+      console.log(this.localName, 'after ready');
+    }
+
+    _readyClients() {
+      this.attachShadow({mode: 'open'}).appendChild(this.dom);
+      super._readyClients();
+    }
+
+    computeLimited(counter, limit) {
+      return Math.min(counter, limit);
+    }
+
+    handleIncrement() {
+      this.counter++;
+    }
+
+  }
+
+  // Generate property accessors for all observed attributes
+  MyElement.createComputedProperty('limited', 'computeLimited(counter, limit)');
+  MyElement.bindTemplate(template);
+
+  // Register element
+  customElements.define('my-element', MyElement);
+
+</script>
+
+
+<my-element counter="10" limit="20"></my-element>
+
+</body>
+</html>
\ No newline at end of file
diff --git a/test/smoke/alacarte-property-effects.html b/test/smoke/alacarte-property-effects.html
new file mode 100644
index 0000000000..8e697f4b7a
--- /dev/null
+++ b/test/smoke/alacarte-property-effects.html
@@ -0,0 +1,86 @@
+<!--
+@license
+Copyright (c) 2017 The Polymer Project Authors. All rights reserved.
+This code may only be used under the BSD style license found at http://polymer.github.io/LICENSE.txt
+The complete set of authors may be found at http://polymer.github.io/AUTHORS.txt
+The complete set of contributors may be found at http://polymer.github.io/CONTRIBUTORS.txt
+Code distributed by Google as part of the polymer project is also
+subject to an additional IP rights grant found at http://polymer.github.io/PATENTS.txt
+-->
+<!DOCTYPE html>
+<html>
+<head>
+  <meta charset="utf-8">
+  <meta name="viewport" content="width=device-width">
+  <script src="../../../webcomponentsjs/webcomponents-lite.js"></script>
+  <link rel="import" href="../../lib/mixins/property-effects.html">
+</head>
+<body>
+
+<template id="my-element-template">
+  <style>
+     :host {
+       display: block;
+     }
+    #counter {
+      padding: 10px;
+      background: lightblue;
+    }
+  </style>
+  <!-- can use declarative event listeners -->
+  <button on-click="handleIncrement">Increment!</button>
+  <span id="counter">[[limited]]</span>
+</template>
+
+<script>
+
+  let template = document.getElementById('my-element-template');
+
+  class MyElement extends Polymer.PropertyEffects(HTMLElement) {
+
+    // Declare observed attributes
+    static get observedAttributes() { return ['counter', 'limit']; }
+
+    constructor() {
+      super();
+      this.counter = 0;
+      this.limit = Infinity;
+    }
+
+    // Enable accessors and flush any queued property changes
+    connectedCallback() {
+      this._enableProperties();
+    }
+
+    // Called once by PropertyAccessors during first property flush
+    // Do one-time work like setting up Shadow DOM
+    ready() {
+      this.dom = this._stampTemplate(template);
+      this.attachShadow({mode: 'open'}).appendChild(this.dom);
+      super.ready();
+    }
+
+    computeLimited(counter, limit) {
+      return Math.min(counter, limit);
+    }
+
+    handleIncrement() {
+      this.counter++;
+    }
+
+  }
+
+  // Generate property accessors for all observed attributes
+  MyElement.createComputedProperty('limited', 'computeLimited(counter, limit)');
+  MyElement.bindTemplate(template);
+
+  // Register element
+  customElements.define('my-element', MyElement);
+
+</script>
+
+
+<my-element counter="10" limit="20"></my-element>
+
+</body>
+</html>
\ No newline at end of file
diff --git a/test/smoke/alacarte-template-stamp.html b/test/smoke/alacarte-template-stamp.html
new file mode 100644
index 0000000000..c8c22cbf13
--- /dev/null
+++ b/test/smoke/alacarte-template-stamp.html
@@ -0,0 +1,94 @@
+<!--
+@license
+Copyright (c) 2017 The Polymer Project Authors. All rights reserved.
+This code may only be used under the BSD style license found at http://polymer.github.io/LICENSE.txt
+The complete set of authors may be found at http://polymer.github.io/AUTHORS.txt
+The complete set of contributors may be found at http://polymer.github.io/CONTRIBUTORS.txt
+Code distributed by Google as part of the polymer project is also
+subject to an additional IP rights grant found at http://polymer.github.io/PATENTS.txt
+-->
+<!DOCTYPE html>
+<html>
+<head>
+  <meta charset="utf-8">
+  <meta name="viewport" content="width=device-width">
+  <script src="../../../webcomponentsjs/webcomponents-lite.js"></script>
+  <link rel="import" href="../../lib/mixins/property-accessors.html">
+  <link rel="import" href="../../lib/mixins/template-stamp.html">
+</head>
+<body>
+
+<template id="my-element-template">
+  <style>
+     :host {
+       display: block;
+     }
+    #counter {
+      padding: 10px;
+      background: lightblue;
+    }
+  </style>
+  <!-- can use declarative event listeners -->
+  <button on-click="handleIncrement">Increment!</button>
+  <span id="counter"></span>
+</template>
+
+<script>
+
+  // Apply mixins to base class
+  let MyBaseClass =
+    Polymer.TemplateStamp(
+      Polymer.PropertyAccessors(
+        HTMLElement));
+
+  class MyElement extends MyBaseClass {
+
+    // Declare observed attributes
+    static get observedAttributes() { return ['counter', 'limit']; }
+
+    constructor() {
+      super();
+      this.counter = 0;
+      this.limit = Infinity;
+    }
+
+    // Enable accessors and flush any queued property changes
+    connectedCallback() {
+      this._enableProperties();
+    }
+
+    // Called once by PropertyAccessors during first property flush
+    // Do one-time work like setting up Shadow DOM
+    ready() {
+      let template = document.getElementById('my-element-template');
+      this.dom = this._stampTemplate(template);
+      this.attachShadow({mode: 'open'}).appendChild(this.dom);
+      super.ready();
+    }
+
+    // React to changes
+    _propertiesChanged(currentProps, changedProps, oldProps) {
+      // Can use this.$ to access id'ed nodes in template
+      this.dom.$.counter.textContent =
+        Math.min(currentProps.counter, currentProps.limit);
+    }
+
+    handleIncrement() {
+      this.counter++;
+    }
+
+  }
+
+  // Generate property accessors for all observed attributes
+  MyElement.createPropertiesForAttributes();
+
+  // Register element
+  customElements.define('my-element', MyElement);
+
+</script>
+
+
+<my-element counter="10" limit="20"></my-element>
+
+</body>
+</html>
\ No newline at end of file

From 99abf955021d44d6ab5beab44b5b26a180986e23 Mon Sep 17 00:00:00 2001
From: Kevin Schaaf <kschaaf@google.com>
Date: Fri, 12 May 2017 20:36:45 -0700
Subject: [PATCH 26/31] v2.0.0-rc.9

---
 lib/utils/boot.html | 2 +-
 package.json        | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/utils/boot.html b/lib/utils/boot.html
index aefae138fe..d88e31591d 100644
--- a/lib/utils/boot.html
+++ b/lib/utils/boot.html
@@ -44,7 +44,7 @@
   window.Polymer._polymerFn = function(info) { // eslint-disable-line no-unused-vars
     throw new Error('Load polymer.html to use the Polymer() function.');
   }
-  window.Polymer.version = '2.0-preview';
+  window.Polymer.version = '2.0.0-rc.9';
 
   /* eslint-disable no-unused-vars */
   /*
diff --git a/package.json b/package.json
index d016053556..f414efc317 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@polymer/polymer",
-  "version": "2.0.0-rc.8",
+  "version": "2.0.0-rc.9",
   "description": "The Polymer library makes it easy to create your own web components. Give your element some markup and properties, and then use it on a site. Polymer provides features like dynamic templates and data binding to reduce the amount of boilerplate you need to write",
   "main": "polymer.html",
   "directories": {

From 21ee3b4da1904a5a7ce116fd8794a41ed09b5d90 Mon Sep 17 00:00:00 2001
From: Daniel Freedman <dfreedm@google.com>
Date: Fri, 12 May 2017 21:19:10 -0700
Subject: [PATCH 27/31] [ci skip] Update Changelog

---
 CHANGELOG.md | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 6808cf0c2c..8fa385bddf 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,5 +1,24 @@
 # Change Log
 
+## [v2.0.0-rc.9](https://github.com/Polymer/polymer/tree/v2.0.0-rc.9) (2017-05-12)
+- [ci skip] Add alacarte usage smoke tests. ([commit](https://github.com/Polymer/polymer/commit/e54bc5f8))
+
+- [skip ci] doc fixes ([commit](https://github.com/Polymer/polymer/commit/b943aa0d))
+
+- Docs and slight renaming. ([commit](https://github.com/Polymer/polymer/commit/4eb252fe))
+
+- Add tests. ([commit](https://github.com/Polymer/polymer/commit/1f83fd7c))
+
+- Move hostStack to property-effects and make readyClients explicit ([commit](https://github.com/Polymer/polymer/commit/c7a81ea8))
+
+- Turn on accessors (via __dataInitialized) only after clients have completely flushed. ([commit](https://github.com/Polymer/polymer/commit/2f1e964c))
+
+- Adds `_enableProperties` as a new entry point that must be called to turn on properties. Prevents a bug where `_readyClients` can be called twice. ([commit](https://github.com/Polymer/polymer/commit/c6f9b315))
+
+- [ci skip] Fix doc createPropertyEffect -> addPropertyEffect ([commit](https://github.com/Polymer/polymer/commit/90e8cd95))
+
+- [ci skip] Update Changelog ([commit](https://github.com/Polymer/polymer/commit/448149d2))
+
 ## [v2.0.0-rc.8](https://github.com/Polymer/polymer/tree/v2.0.0-rc.8) (2017-05-11)
 - Add test for boolean dynamicFn ([commit](https://github.com/Polymer/polymer/commit/03d21ce8))
 

From 712230fc8d6f32b05b2e00d0973216916b262d05 Mon Sep 17 00:00:00 2001
From: Daniel Freedman <dfreedm@google.com>
Date: Mon, 15 May 2017 11:24:54 -0700
Subject: [PATCH 28/31] [ci skip] bump version to 2.0.0

---
 lib/utils/boot.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/utils/boot.html b/lib/utils/boot.html
index d88e31591d..0a15f5ed1d 100644
--- a/lib/utils/boot.html
+++ b/lib/utils/boot.html
@@ -44,7 +44,7 @@
   window.Polymer._polymerFn = function(info) { // eslint-disable-line no-unused-vars
     throw new Error('Load polymer.html to use the Polymer() function.');
   }
-  window.Polymer.version = '2.0.0-rc.9';
+  window.Polymer.version = '2.0.0';
 
   /* eslint-disable no-unused-vars */
   /*

From 49537f25423c0c7f84a2a4b21ddc22f3660782a8 Mon Sep 17 00:00:00 2001
From: Daniel Freedman <dfreedm@google.com>
Date: Mon, 15 May 2017 11:25:09 -0700
Subject: [PATCH 29/31] 2.0.0

---
 package.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package.json b/package.json
index f414efc317..ce1986400e 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@polymer/polymer",
-  "version": "2.0.0-rc.9",
+  "version": "2.0.0",
   "description": "The Polymer library makes it easy to create your own web components. Give your element some markup and properties, and then use it on a site. Polymer provides features like dynamic templates and data binding to reduce the amount of boilerplate you need to write",
   "main": "polymer.html",
   "directories": {

From c4e516f6ac1ee6018bb2a91b89b3f0241696ae03 Mon Sep 17 00:00:00 2001
From: Daniel Freedman <dfreedm@google.com>
Date: Mon, 15 May 2017 11:26:07 -0700
Subject: [PATCH 30/31] [ci skip] Update Changelog

---
 CHANGELOG.md | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 8fa385bddf..58ed01bda8 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,5 +1,10 @@
 # Change Log
 
+## [v2.0.0](https://github.com/Polymer/polymer/tree/v2.0.0) (2017-05-15)
+- [ci skip] bump version to 2.0.0 ([commit](https://github.com/Polymer/polymer/commit/712230fc))
+
+- [ci skip] Update Changelog ([commit](https://github.com/Polymer/polymer/commit/21ee3b4d))
+
 ## [v2.0.0-rc.9](https://github.com/Polymer/polymer/tree/v2.0.0-rc.9) (2017-05-12)
 - [ci skip] Add alacarte usage smoke tests. ([commit](https://github.com/Polymer/polymer/commit/e54bc5f8))
 

From 6bd8dcfac2b7748165f5a43e5d155dd9a177ddf2 Mon Sep 17 00:00:00 2001
From: salvador-barboza <salvador.barboza.portillo@gmail.com>
Date: Sat, 20 May 2017 13:41:43 -0500
Subject: [PATCH 31/31] Fix typo in  runBindingEffect documentation

---
 lib/mixins/property-effects.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/mixins/property-effects.html b/lib/mixins/property-effects.html
index 59ef27e49e..04160d56ee 100644
--- a/lib/mixins/property-effects.html
+++ b/lib/mixins/property-effects.html
@@ -508,7 +508,7 @@
    * Implements the "binding" (property/path binding) effect.
    *
    * Note that binding syntax is overridable via `_parseBindings` and
-   * `_evaluateBindings`.  This method will call `_evaluateBinding` for any
+   * `_evaluateBinding`.  This method will call `_evaluateBinding` for any
    * non-literal parts returned from `_parseBindings`.  However,
    * there is no support for _path_ bindings via custom binding parts,
    * as this is specific to Polymer's path binding syntax.