Add comments re: need for mixing in before metaprogramming

Polymer · Aug 28, 2018 · d93cbfa · d93cbfa
1 parent 2d06ff5
commit d93cbfa
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/lib/legacy/class.js b/lib/legacy/class.js
@@ -336,6 +336,7 @@ function GenerateClassFromInfo(info, Base) {
  *   to become class methods.
  * @template T
  * @param {function(T):T} mixin Optional mixin to apply to legacy base class
+ *   before extending with Polymer metaprogramming.
  * @return {function(new:HTMLElement)} Generated class
  */
 export const Class = function(info, mixin) {

diff --git a/lib/legacy/legacy-data-mixin.js b/lib/legacy/legacy-data-mixin.js
@@ -140,6 +140,9 @@ export const LegacyDataMixin = dedupingMixin(superClass => {
 
 });
 
+// LegacyDataMixin is applied to base class _before_ metaprogramming, to
+// ensure override of _addPropertyEffect et.al. are used by metaprogramming
+// performed in _finalizeClass
 Polymer.Class = (info, mixin) => Class(info, 
   superClass => mixin ? 
     mixin(LegacyDataMixin(superClass)) :