Fix TypeScript breakages by specifying types for overridden `setAttri…

…bute` and `getAttribute`.
Polymer · Apr 28, 2020 · c8715b5 · c8715b5
1 parent 282bd34
commit c8715b5
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/lib/legacy/legacy-element-mixin.js b/lib/legacy/legacy-element-mixin.js
@@ -143,7 +143,11 @@ export const LegacyElementMixin = dedupingMixin((base) => {
       }
     }
 
-    /** @override */
+    /**
+     * @override
+     * @param {string} name
+     * @param {string} value
+     */
     setAttribute(name, value) {
       if (legacyNoObservedAttributes && !this._legacyForceObservedAttributes) {
         const oldValue = this.getAttribute(name);
@@ -155,7 +159,10 @@ export const LegacyElementMixin = dedupingMixin((base) => {
       }
     }
 
-    /** @override */
+    /**
+     * @override
+     * @param {string} name
+     */
     removeAttribute(name) {
       if (legacyNoObservedAttributes && !this._legacyForceObservedAttributes) {
         const oldValue = this.getAttribute(name);