Merge pull request #5464 from Polymer/copy-properties

Allow `Polymer({})` calls with ES6 class
Polymer · Jan 29, 2019 · c22b87c · c22b87c
2 parents 038af2a + 3ff4ed1
commit c22b87c
Show file tree

Hide file tree

Showing 5 changed files with 735 additions and 940 deletions.
diff --git a/lib/legacy/class.js b/lib/legacy/class.js
@@ -44,18 +44,21 @@ const excludeOnBehaviors = Object.assign({
 
 function copyProperties(source, target, excludeProps) {
   const noAccessors = source._noAccessors;
-  for (let p in source) {
-    if (!(p in excludeProps)) {
-      if (noAccessors) {
-        target[p] = source[p];
-      } else {
-        let pd = Object.getOwnPropertyDescriptor(source, p);
-        if (pd) {
-          // ensure property is configurable so that a later behavior can
-          // re-configure it.
-          pd.configurable = true;
-          Object.defineProperty(target, p, pd);
-        }
+  const propertyNames = Object.getOwnPropertyNames(source);
+  for (let i = 0; i < propertyNames.length; i++) {
+    let p = propertyNames[i];
+    if (p in excludeProps) {
+      continue;
+    }
+    if (noAccessors) {
+      target[p] = source[p];
+    } else {
+      let pd = Object.getOwnPropertyDescriptor(source, p);
+      if (pd) {
+        // ensure property is configurable so that a later behavior can
+        // re-configure it.
+        pd.configurable = true;
+        Object.defineProperty(target, p, pd);
       }
     }
   }