Add support for properties defined in a behavior.

For correctness this is implemented using `getPropertyInfo()` though this is not optimized at all. Note that `_propertyInfo` is not ready when we parse the annotations (which is the earliest call to `_parseMethod` right now). There are several options to make this right, but these are not part of this feature PR.
Polymer · Feb 12, 2016 · b6abf26 · b6abf26
1 parent f4486a2
commit b6abf26
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 22 deletions.
diff --git a/src/standard/effectBuilder.html b/src/standard/effectBuilder.html
@@ -227,7 +227,8 @@
       var m = expression.match(/([^\s]+?)\(([\s\S]*)\)/);
       if (m) {
         var sig = { method: m[1], static: true };
-        if (this.properties[sig.method]) {
+        // TODO(kaste): Optimize/memoize `getPropertyInfo`.
+        if (this.getPropertyInfo(sig.method) !== Polymer.nob) {
           sig.static = false;
           sig.dynamicFn = true;
         }

diff --git a/test/unit/bind-elements.html b/test/unit/bind-elements.html
@@ -588,29 +588,36 @@
     <div id="check">[[translate('Hello World.')]]</div>
   </template>
   <script>
-    Polymer({
-      is: 'x-bind-computed-property',
-      properties: {
-        translate: {
-          type: Function,
-          computed: '_computeTranslateFn(translator)'
-        },
-        translator: {
-          type: Function,
-          value: function() {
-            return function(message) {
-              return 'translated: ' + message;
-            }
+    (function(){
+      var TranslateBehavior = {
+        properties: {
+          translate: {
+            type: Function,
+            computed: '_computeTranslateFn(translator)'
           }
+        }
+      };
+      Polymer({
+        is: 'x-bind-computed-property',
+        behaviors: [TranslateBehavior],
+        properties: {
+          translator: {
+            type: Function,
+            value: function() {
+              return function(message) {
+                return 'translated: ' + message;
+              }
+            }
+          },
         },
-      },
 
-      _computeTranslateFn: function(translator) {
-        return function(message) {
-          return translator(message);
-        }
-      },
+        _computeTranslateFn: function(translator) {
+          return function(message) {
+            return translator(message);
+          }
+        },
 
-    });
+      });
+    })();
   </script>
-</dom-module>
+</dom-module>