Do not assign to a readonly property on window

If `window.customElements` exists there's a good chance that it's a readonly property as per spec, and assigning to readonly properties throws an exception in strict mode.
Polymer · Jul 23, 2017 · b64e486 · b64e486
1 parent e03b2cc
commit b64e486
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/test/unit/shady-content.html b/test/unit/shady-content.html
@@ -12,7 +12,9 @@
 <head>
   <meta charset="utf-8">
   <script>
-    window.customElements = window.customElements || {};
+    if (!window.customElements) {
+      window.customElements = {};
+    }
     customElements.forcePolyfill = true;
     window.ShadyDOM = {
       force: true

diff --git a/test/unit/shady-dynamic.html b/test/unit/shady-dynamic.html
@@ -12,7 +12,9 @@
 <head>
   <meta charset="utf-8">
   <script>
-    window.customElements = window.customElements || {};
+    if (!window.customElements) {
+      window.customElements = {};
+    }
     customElements.forcePolyfill = true;
     window.ShadyDOM = {
       force: true

diff --git a/test/unit/shady-events.html b/test/unit/shady-events.html
@@ -11,7 +11,9 @@
 <html>
 <head>
 <script>
-  window.customElements = window.customElements || {};
+  if (!window.customElements) {
+    window.customElements = {};
+  }
   customElements.forcePolyfill = true;
   window.ShadyDOM = {
     force: true