Merge with master

.eslintrc.json

@@ -19,9 +19,11 @@
         "Boolean": "boolean",
         "Number": "number",
         "String": "string",
-        "object": "Object"
+        "object": "Object",
+        "array": "Array"
       }
-    }]
+    }],
+    "no-useless-escape": "off"
   },
   "env": {
     "browser": true,

CHANGELOG.md

@@ -1,5 +1,101 @@
 # Change Log
 
+## [v2.3.0](https://github.com/Polymer/polymer/tree/v2.3.0) (2017-12-05)
+- [ci skip] update changelog ([commit](https://github.com/Polymer/polymer/commit/c727d35d))
+
+## [v2.2.1](https://github.com/Polymer/polymer/tree/v2.2.1) (2017-12-05)
+- [ci skip] commit new version in lib/utils/boot.html when using npm version ([commit](https://github.com/Polymer/polymer/commit/71fbf6ef))
+
+- change PolymerElement extern to var ([commit](https://github.com/Polymer/polymer/commit/5c3d58aa))
+
+- update node devDependencies ([commit](https://github.com/Polymer/polymer/commit/a39f3f41))
+
+- fix lint error ([commit](https://github.com/Polymer/polymer/commit/f242e197))
+
+- Fix :dir selectors with nested custom elements ([commit](https://github.com/Polymer/polymer/commit/3b76e86f))
+
+- Update test to be more descriptive ([commit](https://github.com/Polymer/polymer/commit/86a64b6c))
+
+- Annotate Polymer function with @global. (#4967) ([commit](https://github.com/Polymer/polymer/commit/b124b707))
+
+- make PASSIVE_TOUCH take an argument ([commit](https://github.com/Polymer/polymer/commit/c5407a8b))
+
+- Do not set touchend listeners to passive ([commit](https://github.com/Polymer/polymer/commit/84fa3bf3))
+
+- Add some @function annotations to APIs that are defined by assignment. ([commit](https://github.com/Polymer/polymer/commit/29f2a0e7))
+
+- add return jsdoc to void functions ([commit](https://github.com/Polymer/polymer/commit/a8105e55))
+
+- Update CONTRIBUTING.md ([commit](https://github.com/Polymer/polymer/commit/14fd53c3))
+
+- Fix typo. ([commit](https://github.com/Polymer/polymer/commit/581483f2))
+
+- Comment reworded based on feedback. ([commit](https://github.com/Polymer/polymer/commit/80a7f1e5))
+
+- Semantic issue (proposal) plus minor fixes ([commit](https://github.com/Polymer/polymer/commit/42ec14bf))
+
+- Depend on webcomponents and shadycss with shady-unscoped support ([commit](https://github.com/Polymer/polymer/commit/8241b887))
+
+- Also clarify `delay` units. Fixes #4707 ([commit](https://github.com/Polymer/polymer/commit/348ed92c))
+
+- Ensure re-sort/filter always happens after array item set. Fixes #3626 ([commit](https://github.com/Polymer/polymer/commit/f6d4771c))
+
+- Clarify docs on target-framerate. Fixes #4897 ([commit](https://github.com/Polymer/polymer/commit/c18a5349))
+
+- move test after ([commit](https://github.com/Polymer/polymer/commit/45598302))
+
+- test more permutations ([commit](https://github.com/Polymer/polymer/commit/f03e8d1b))
+
+- Fix missing comma in `Path.translate` JSDoc ([commit](https://github.com/Polymer/polymer/commit/41616c6f))
+
+- fix(bower): standardized version tagging (#4921) ([commit](https://github.com/Polymer/polymer/commit/6e3ae2e5))
+
+- Minor fixes (update URLs) ([commit](https://github.com/Polymer/polymer/commit/8e7024e6))
+
+- add license headers ([commit](https://github.com/Polymer/polymer/commit/518b4699))
+
+- Prep for processing of `shady-unscoped` moving to ShadyCSS ([commit](https://github.com/Polymer/polymer/commit/08c3a02e))
+
+- Implement type change in Polymer.ElementMixin ([commit](https://github.com/Polymer/polymer/commit/cda62d5f))
+
+- instance.$.foo should only give Elements ([commit](https://github.com/Polymer/polymer/commit/4837e4a8))
+
+- Annotate DomApi with @memberof Polymer ([commit](https://github.com/Polymer/polymer/commit/7308d8b6))
+
+- Clarify all elements between changes must apply mixing. Fixes #4914 ([commit](https://github.com/Polymer/polymer/commit/7360f42a))
+
+- add safari 11 to sauce testing ([commit](https://github.com/Polymer/polymer/commit/428ad8c2))
+
+- Fix tests on Firefox. ([commit](https://github.com/Polymer/polymer/commit/9a468335))
+
+- Update externs again. ([commit](https://github.com/Polymer/polymer/commit/1c5b731f))
+
+- Update externs. ([commit](https://github.com/Polymer/polymer/commit/8683b27c))
+
+- Lint fixes ([commit](https://github.com/Polymer/polymer/commit/092b210f))
+
+- Allow style elements to be separate in the element template. ([commit](https://github.com/Polymer/polymer/commit/819652eb))
+
+- Lint fix. ([commit](https://github.com/Polymer/polymer/commit/982d28c6))
+
+- Add support for styles with a `shady-unscoped` attribute ([commit](https://github.com/Polymer/polymer/commit/d77e073e))
+
+- [ci skip] Update CHANGELOG ([commit](https://github.com/Polymer/polymer/commit/314bada5))
+
+- [ci skip] version script did not work as expected ([commit](https://github.com/Polymer/polymer/commit/4265cba1))
+
+- adding test case for 4696 4706 ([commit](https://github.com/Polymer/polymer/commit/939ce63c))
+
+- Support property observers which are direct function references in addition to strings. Provides better static analysis and refactoring support in multiple tools. Alleviates the need for property reflection with Closure-compiler renaming. ([commit](https://github.com/Polymer/polymer/commit/4bae2b62))
+
+- removing package-lock.json from PR ([commit](https://github.com/Polymer/polymer/commit/0da00a1d))
+
+- implementing the code review suggestions ([commit](https://github.com/Polymer/polymer/commit/1b51f601))
+
+- Updating deserialize function (use of ternary operation). Fixes #4696 ([commit](https://github.com/Polymer/polymer/commit/ca139ed0))
+
+- Updating deserialize function. Fixes #4696 ([commit](https://github.com/Polymer/polymer/commit/277ca89a))
+
 ## [v2.2.0](https://github.com/Polymer/polymer/tree/v2.2.0) (2017-10-18)
 - [ci skip] Autoupdate version when releasing ([commit](https://github.com/Polymer/polymer/commit/d893d6ae))
 

externs/polymer-externs.js

@@ -96,9 +96,10 @@ PolymerTelemetry.dumpRegistrations;;
 /** @type {PolymerTelemetry} */
 Polymer.telemetry;
 
+// nb. This is explicitly 'var', as Closure Compiler checks that this is the case.
 /**
  * @constructor
  * @extends {HTMLElement}
  * @implements {Polymer_LegacyElementMixin}
  */
-let PolymerElement = Polymer.LegacyElementMixin();
+var PolymerElement = Polymer.LegacyElementMixin();

lib/elements/array-selector.html

@@ -269,6 +269,7 @@
        * Deselects the given item if it is already selected.
        *
        * @param {*} item Item from `items` array to deselect
+       * @return {void}
        */
       deselect(item) {
         let idx = this.__selectedMap.get(item);
@@ -291,6 +292,7 @@
        * Deselects the given index if it is already selected.
        *
        * @param {number} idx Index from `items` array to deselect
+       * @return {void}
        */
       deselectIndex(idx) {
         this.deselect(this.items[idx]);
@@ -301,6 +303,7 @@
        * deselect the item if already selected.
        *
        * @param {*} item Item from `items` array to select
+       * @return {void}
        */
       select(item) {
         this.selectIndex(this.items.indexOf(item));
@@ -311,6 +314,7 @@
        * deselect the item if already selected.
        *
        * @param {number} idx Index from `items` array to select
+       * @return {void}
        */
       selectIndex(idx) {
         let item = this.items[idx];

lib/elements/dom-bind.html

@@ -90,6 +90,7 @@
       /**
        * Forces the element to render its content. This is typically only
        * necessary to call if HTMLImports with the async attribute are used.
+       * @return {void}
        */
       render() {
         let template;

lib/elements/dom-if.html

@@ -140,6 +140,7 @@
      * that multiple changes trigger only a single render. The render method
      * should be called if, for example, template rendering is required to
      * validate application state.
+     * @return {void}
      */
     render() {
       Polymer.flush();

lib/elements/dom-module.html

@@ -110,6 +110,7 @@
      * when a dom-module is imperatively created. For
      * example, `document.createElement('dom-module').register('foo')`.
      * @param {string=} id The id at which to register the dom-module.
+     * @return {void}
      */
     register(id) {
       id = id || this.id;

lib/elements/dom-repeat.html

@@ -496,6 +496,7 @@
      * that multiple changes trigger only a single render. The render method
      * should be called if, for example, template rendering is required to
      * validate application state.
+     * @return {void}
      */
     render() {
       // Queue this repeater, then flush all in order

lib/legacy/legacy-element-mixin.html

@@ -250,6 +250,7 @@
        * @param {string} property Property name to reflect.
        * @param {string=} attribute Attribute name to reflect.
        * @param {*=} value Property value to reflect.
+       * @return {void}
        */
       reflectPropertyToAttribute(property, attribute, value) {
         this._propertyToAttribute(property, attribute, value);
@@ -264,6 +265,7 @@
        * @param {*} value Value to serialize.
        * @param {string} attribute Attribute name to serialize to.
        * @param {Element} node Element to set attribute to.
+       * @return {void}
        */
       serializeValueToAttribute(value, attribute, node) {
         this._valueToNodeAttribute(/** @type {Element} */ (node || this), value, attribute);
@@ -382,6 +384,7 @@
        * @param {Element} node Element to add event listener to.
        * @param {string} eventName Name of event to listen for.
        * @param {string} methodName Name of handler method on `this` to call.
+       * @return {void}
        */
       listen(node, eventName, methodName) {
         node = /** @type {!Element} */ (node || this);
@@ -407,6 +410,7 @@
        * @param {string} eventName Name of event to stop listening to.
        * @param {string} methodName Name of handler method on `this` to not call
        anymore.
+       * @return {void}
        */
       unlisten(node, eventName, methodName) {
         node = /** @type {!Element} */ (node || this);
@@ -432,6 +436,7 @@
        * Defaults to `all`.
        * @param {Element=} node Element to apply scroll direction setting.
        * Defaults to `this`.
+       * @return {void}
        */
       setScrollDirection(direction, node) {
         Polymer.Gestures.setTouchAction(/** @type {Element} */ (node || this), DIRECTION_MAP[direction] || 'auto');
@@ -465,6 +470,7 @@
        * Force this element to distribute its children to its local dom.
        * This should not be necessary as of Polymer 2.0.2 and is provided only
        * for backwards compatibility.
+       * @return {void}
        */
       distributeContent() {
         if (window.ShadyDOM && this.shadowRoot) {
@@ -677,6 +683,7 @@
        * Immediately calls the debouncer `callback` and inactivates it.
        *
        * @param {string} jobName The name of the debouncer started with `debounce`
+       * @return {void}
        */
       flushDebouncer(jobName) {
         this._debouncers = this._debouncers || {};
@@ -690,6 +697,7 @@
        * Cancels an active debouncer.  The `callback` will not be called.
        *
        * @param {string} jobName The name of the debouncer started with `debounce`
+       * @return {void}
        */
       cancelDebouncer(jobName) {
         this._debouncers = this._debouncers || {};
@@ -721,6 +729,7 @@
        *
        * @param {number} handle Handle returned from original `async` call to
        *   cancel.
+       * @return {void}
        */
       cancelAsync(handle) {
         handle < 0 ? Polymer.Async.microTask.cancel(~handle) :
@@ -833,6 +842,7 @@
        * @param {string} transformText Transform setting.
        * @param {Element=} node Element to apply the transform to.
        * Defaults to `this`
+       * @return {void}
        */
       transform(transformText, node) {
         node = /** @type {Element} */ (node || this);
@@ -849,6 +859,7 @@
        * @param {number} z Z offset.
        * @param {Element=} node Element to apply the transform to.
        * Defaults to `this`.
+       * @return {void}
        */
       translate3d(x, y, z, node) {
         node = /** @type {Element} */ (node || this);

lib/legacy/polymer-fn.html

@@ -24,6 +24,7 @@
      *
      * See `Polymer.Class` for details on valid legacy metadata format for `info`.
      *
+     * @global
      * @override
      * @function Polymer
      * @param {!PolymerInit} info Object containing Polymer metadata and functions

lib/legacy/polymer.dom.html

@@ -68,13 +68,15 @@
      *
      * @param {Polymer.FlattenedNodesObserver} observerHandle Observer instance
      *   to disconnect.
+     * @return {void}
      */
     unobserveNodes(observerHandle) {
       observerHandle.disconnect();
     }
 
     /**
      * Provided as a backwards-compatible API only.  This method does nothing.
+     * @return {void}
      */
     notifyObserver() {}
 
@@ -196,9 +198,11 @@
   function forwardMethods(proto, methods) {
     for (let i=0; i < methods.length; i++) {
       let method = methods[i];
+      /* eslint-disable valid-jsdoc */
       proto[method] = /** @this {DomApi} */ function() {
         return this.node[method].apply(this.node, arguments);
       };
+      /* eslint-enable */
     }
   }
 

lib/legacy/templatizer-behavior.html

@@ -100,6 +100,7 @@
        * @param {boolean=} mutableData When `true`, the generated class will skip
        *   strict dirty-checking for objects and arrays (always consider them to
        *   be "dirty"). Defaults to false.
+       * @return {void}
        * @this {TemplatizerUser}
        */
       templatize(template, mutableData) {

lib/mixins/dir-mixin.html

@@ -16,7 +16,7 @@
     const HOST_DIR = /:host\(:dir\((ltr|rtl)\)\)/g;
     const HOST_DIR_REPLACMENT = ':host([dir="$1"])';
 
-    const EL_DIR = /([\s\w#\.\[\]\*]*):dir\((ltr|rtl)\)/g;
+    const EL_DIR = /([\s\w-#\.\[\]\*]*):dir\((ltr|rtl)\)/g;
     const EL_DIR_REPLACMENT = ':host([dir="$2"]) $1';
 
     /**

lib/mixins/element-mixin.html

@@ -198,6 +198,7 @@
      * Supported keys:
      * @param {Object} allProps Flattened map of all properties defined in this
      *   element (including inherited properties)
+     * @return {void}
      * @private
      */
     function createPropertyFromConfig(proto, name, info, allProps) {
@@ -311,6 +312,7 @@
        * @param {Object} dynamicFns Object containing keys for any properties
        *   that are functions and should trigger the effect when the function
        *   reference is changed
+       * @return {void}
        * @protected
        */
       static createObservers(observers, dynamicFns) {
@@ -470,6 +472,7 @@
       * style scoping.
       *
       * @param {string} is Tag name (or type extension name) for this element
+      * @return {void}
       * @protected
       */
       static _finalizeTemplate(is) {
@@ -580,6 +583,7 @@
        *
        * @param {Object=} properties Bag of custom property key/values to
        *   apply to this element.
+       * @return {void}
        * @suppress {invalidCasts}
        */
       updateStyles(properties) {
@@ -687,6 +691,7 @@
    *
    * @param {Object=} props Bag of custom property key/values to
    *   apply to the document.
+   * @return {void}
    */
   Polymer.updateStyles = function(props) {
     if (window.ShadyCSS) {