Rebase sanitize dom value getter onto legacy-undefined-noBatch (#5618)

* Add getSanitizeDOMValue to settings API For environments that don't well support `export let`. * Add a test for getSanitizeDOMValue
Polymer · Jan 17, 2020 · afdd911 · afdd911
1 parent 7d071f7
commit afdd911
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 3 deletions.
diff --git a/lib/utils/settings.js b/lib/utils/settings.js
@@ -64,7 +64,7 @@ export const setRootPath = function(path) {
  * `type` indicates where the value is being inserted: one of property, attribute, or text.
  * `node` is the node where the value is being inserted.
  *
- * @type {(function(*,string,string,Node):*)|undefined}
+ * @type {(function(*,string,string,?Node):*)|undefined}
  */
 export let sanitizeDOMValue =
   window.Polymer && window.Polymer.sanitizeDOMValue || undefined;
@@ -73,13 +73,22 @@ export let sanitizeDOMValue =
  * Sets the global sanitizeDOMValue available via this module's exported
  * `sanitizeDOMValue` variable.
  *
- * @param {(function(*,string,string,Node):*)|undefined} newSanitizeDOMValue the global sanitizeDOMValue callback
+ * @param {(function(*,string,string,?Node):*)|undefined} newSanitizeDOMValue the global sanitizeDOMValue callback
  * @return {void}
  */
 export const setSanitizeDOMValue = function(newSanitizeDOMValue) {
   sanitizeDOMValue = newSanitizeDOMValue;
 };
 
+/**
+ * Gets sanitizeDOMValue, for environments that don't well support `export let`.
+ *
+ * @return {(function(*,string,string,?Node):*)|undefined} sanitizeDOMValue
+ */
+export const getSanitizeDOMValue = function() {
+  return sanitizeDOMValue;
+};
+
 /**
  * Globally settable property to make Polymer Gestures use passive TouchEvent listeners when recognizing gestures.
  * When set to `true`, gestures made from touch will not be able to prevent scrolling, allowing for smoother

diff --git a/test/unit/property-effects.html b/test/unit/property-effects.html
@@ -26,7 +26,7 @@
 <script type="module">
 import './property-effects-elements.js';
 import { Polymer, html } from '../../polymer-legacy.js';
-import { setSanitizeDOMValue, sanitizeDOMValue, setLegacyWarnings, legacyUndefined, setLegacyUndefined, setOrderedComputed, orderedComputed } from '../../lib/utils/settings.js';
+import { setSanitizeDOMValue, sanitizeDOMValue, getSanitizeDOMValue, setLegacyWarnings, legacyUndefined, setLegacyUndefined, setOrderedComputed, orderedComputed } from '../../lib/utils/settings.js';
 import { PropertyEffects } from '../../lib/mixins/property-effects.js';
 import { flush } from '../../lib/utils/flush.js';
 
@@ -1471,6 +1471,13 @@
       ['javascript', 'reflectedstring', 'attribute', el]);
   });
 
+  test('getter returns the current value', function() {
+    assert(sanitizeDOMValue instanceof Function);
+    assert.strictEqual(getSanitizeDOMValue(), sanitizeDOMValue);
+    setSanitizeDOMValue(null);
+    assert.strictEqual(sanitizeDOMValue, null);
+    assert.strictEqual(getSanitizeDOMValue(), null);
+  });
 });
 
 suite('data (im)mutability', function() {