Skip to content

Commit

Permalink
Read properties off of proto during configuration.
Browse files Browse the repository at this point in the history
  • Loading branch information
kevinpschaaf committed Feb 16, 2017
1 parent 6fc567f commit a68c0b3
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion src/standard/configure.html
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,12 @@
this._configureProperties(this.behaviors[i].properties, config);
}
// prototypical behavior
this._configureProperties(this.properties, config);
// Read `properties` off of the prototype, as an concession to non-spec
// compliant browsers where a.) HTMLElement's have a non-spec `properties`
// property, and b.) the `properties` accessor is on instances rather
// than `HTMLElement.prototype`; going under the instance to the prototype
// avoids the problem.
this._configureProperties(this.__proto__.properties, config);
// TODO(sorvell): it *may* be faster to loop over _propertyInfo but
// there are some test issues.
//this._configureProperties(this._propertyInfo, config);
Expand Down

0 comments on commit a68c0b3

Please sign in to comment.