Skip to content

Commit

Permalink
last two stragglers
Browse files Browse the repository at this point in the history
  • Loading branch information
@dfreedm
dfreedm committed Jun 6, 2017
1 parent ba72012 commit 9bd8920
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 25 deletions.
42 changes: 17 additions & 25 deletions closure.log
View file
Original file line number Diff line number Diff line change
Expand Up @@ -38,75 +38,67 @@ polymer.html_script_31.js:321: WARNING - Property itemsIndexAs never defined on
instanceProps[this.itemsIndexAs] = true;
^^^^^^^^^^^^^^^^^

polymer.html_script_31.js:364: WARNING - Property __dataHost never defined on this of type DomRepeat
return this.__dataHost._methodHost || this.__dataHost;
^^^^^^^^^^^^^^^

polymer.html_script_31.js:416: WARNING - Property _targetFrameTime never defined on this of type DomRepeat
polymer.html_script_31.js:421: WARNING - Property _targetFrameTime never defined on this of type DomRepeat
let ratio = this._targetFrameTime / (currChunkTime - this.__lastChunkTime);
^^^^^^^^^^^^^^^^^^^^^

polymer.html_script_31.js:450: WARNING - Property delay never defined on this of type DomRepeat{__needFullRefresh:true, __observePaths:truthy}
polymer.html_script_31.js:455: WARNING - Property delay never defined on this of type DomRepeat{__needFullRefresh:true, __observePaths:truthy}
this.__debounceRender(this.__render, this.delay);
^^^^^^^^^^

polymer.html_script_31.js:496: WARNING - Property _setRenderedItemCount never defined on this of type DomRepeat{__pool:{length:number} (loose)}
polymer.html_script_31.js:501: WARNING - Property _setRenderedItemCount never defined on this of type DomRepeat{__pool:{length:number} (loose)}
this._setRenderedItemCount(this.__instances.length);
^^^^^^^^^^^^^^^^^^^^^^^^^^

polymer.html_script_31.js:532: WARNING - Property as never defined on this of type DomRepeat{__instances:Object, __itemsIdxToInstIdx:Object{}, __limit:number, items:?=}
polymer.html_script_31.js:537: WARNING - Property as never defined on this of type DomRepeat{__instances:Object, __itemsIdxToInstIdx:Object{}, __limit:number, items:?=}
inst._setPendingProperty(this.as, item);
^^^^^^^

polymer.html_script_31.js:533: WARNING - Property indexAs never defined on this of type DomRepeat{__instances:Object, __itemsIdxToInstIdx:Object{}, __limit:number, items:?=}
polymer.html_script_31.js:538: WARNING - Property indexAs never defined on this of type DomRepeat{__instances:Object, __itemsIdxToInstIdx:Object{}, __limit:number, items:?=}
inst._setPendingProperty(this.indexAs, instIdx);
^^^^^^^^^^^^

polymer.html_script_31.js:534: WARNING - Property itemsIndexAs never defined on this of type DomRepeat{__instances:Object, __itemsIdxToInstIdx:Object{}, __limit:number, items:?=}
polymer.html_script_31.js:539: WARNING - Property itemsIndexAs never defined on this of type DomRepeat{__instances:Object, __itemsIdxToInstIdx:Object{}, __limit:number, items:?=}
inst._setPendingProperty(this.itemsIndexAs, itemIdx);
^^^^^^^^^^^^^^^^^

polymer.html_script_31.js:570: WARNING - Property as never defined on this of type DomRepeat
polymer.html_script_31.js:575: WARNING - Property as never defined on this of type DomRepeat
model[this.as] = item;
^^^^^^^

polymer.html_script_31.js:571: WARNING - Property indexAs never defined on this of type DomRepeat
polymer.html_script_31.js:576: WARNING - Property indexAs never defined on this of type DomRepeat
model[this.indexAs] = instIdx;
^^^^^^^^^^^^

polymer.html_script_31.js:572: WARNING - Property itemsIndexAs never defined on this of type DomRepeat
polymer.html_script_31.js:577: WARNING - Property itemsIndexAs never defined on this of type DomRepeat
model[this.itemsIndexAs] = itemIdx;
^^^^^^^^^^^^^^^^^

polymer.html_script_31.js:581: WARNING - Property as never defined on this of type DomRepeat{__pool:{pop:LOOSE_TOP_FUNCTION} (loose)}
polymer.html_script_31.js:586: WARNING - Property as never defined on this of type DomRepeat{__pool:{pop:LOOSE_TOP_FUNCTION} (loose)}
inst._setPendingProperty(this.as, item);
^^^^^^^

polymer.html_script_31.js:582: WARNING - Property indexAs never defined on this of type DomRepeat{__pool:{pop:LOOSE_TOP_FUNCTION} (loose)}
polymer.html_script_31.js:587: WARNING - Property indexAs never defined on this of type DomRepeat{__pool:{pop:LOOSE_TOP_FUNCTION} (loose)}
inst._setPendingProperty(this.indexAs, instIdx);
^^^^^^^^^^^^

polymer.html_script_31.js:583: WARNING - Property itemsIndexAs never defined on this of type DomRepeat{__pool:{pop:LOOSE_TOP_FUNCTION} (loose)}
polymer.html_script_31.js:588: WARNING - Property itemsIndexAs never defined on this of type DomRepeat{__pool:{pop:LOOSE_TOP_FUNCTION} (loose)}
inst._setPendingProperty(this.itemsIndexAs, itemIdx);
^^^^^^^^^^^^^^^^^

polymer.html_script_31.js:617: WARNING - Property as never defined on this of type DomRepeat{__instances:Object, __itemsIdxToInstIdx:Object}
polymer.html_script_31.js:622: WARNING - Property as never defined on this of type DomRepeat{__instances:Object, __itemsIdxToInstIdx:Object}
let itemPath = this.as + (itemSubPath ? '.' + itemSubPath : '');
^^^^^^^

polymer.html_script_31.js:641: WARNING - Property as never defined on this of type DomRepeat
polymer.html_script_31.js:646: WARNING - Property as never defined on this of type DomRepeat
return instance && instance[this.as];
^^^^^^^

polymer.html_script_31.js:655: WARNING - Property indexAs never defined on this of type DomRepeat
polymer.html_script_31.js:660: WARNING - Property indexAs never defined on this of type DomRepeat
return instance && instance[this.indexAs];
^^^^^^^^^^^^

polymer.html_script_32.js:221: WARNING - Property __dataHost never defined on this of type DomIf{__instance:{_setPendingProperty:LOOSE_TOP_FUNCTION} (loose)}
this.__instance._setPendingProperty(prop, this.__dataHost[prop]);
^^^^^^^^^^^^^^^

polymer.html_script_32.js:244: WARNING - Property if never defined on this of type DomIf
polymer.html_script_32.js:245: WARNING - Property if never defined on this of type DomIf
let hidden = this.__hideTemplateChildren__ || !this.if;
^^^^^^^

Expand Down Expand Up @@ -138,4 +130,4 @@ polymer.html_script_35.js:5: WARNING - Property _mutablePropertyChange never def
let mutablePropertyChange = Polymer.MutableData._mutablePropertyChange;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

0 error(s), 35 warning(s), 75.8% typed
0 error(s), 33 warning(s), 75.8% typed
1 change: 1 addition & 0 deletions lib/elements/dom-if.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,7 @@
return true;
}

/** @suppress {missingProperties} */
__syncHostProperties() {
let props = this.__invalidProps;
if (props) {
Expand Down
5 changes: 5 additions & 0 deletions lib/elements/dom-repeat.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -371,6 +371,10 @@
return true;
}

/* eslint-disable valid-jsdoc */
/**
* @suppress {missingProperties}
*/
__getMethodHost() {
// Technically this should be the owner of the outermost template.
// In shadow dom, this is always getRootNode().host, but we can
Expand All @@ -379,6 +383,7 @@
// instance causing it to get a dataHost.
return this.__dataHost._methodHost || this.__dataHost;
}
/* eslint-enable valid-jsdoc */

__sortChanged(sort) {
let methodHost = this.__getMethodHost();
Expand Down

0 comments on commit 9bd8920

Please sign in to comment.