Skip to content

Commit

Permalink
Update jsdoc for PropertyEffects.splice (#5367)
Browse files Browse the repository at this point in the history
Array.prototype.splice has its "deleteCount" parameter optional. When omitted, all
items of the arrays are removed. This works with a polymer element
"splice" method, but the typing does not correspond and TypeScript
prevents it.

Fixes #5366
  • Loading branch information
floribon authored and TimvdLippe committed Oct 5, 2018
1 parent 9b322c2 commit 96557f7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/mixins/property-effects.js
Original file line number Diff line number Diff line change
Expand Up @@ -1873,7 +1873,7 @@ export const PropertyEffects = dedupingMixin(superClass => {
*
* @param {string | !Array<string|number>} path Path to array.
* @param {number} start Index from which to start removing/inserting.
* @param {number} deleteCount Number of items to remove.
* @param {number=} deleteCount Number of items to remove.
* @param {...*} items Items to insert into array.
* @return {Array} Array of removed items.
* @public
Expand Down

0 comments on commit 96557f7

Please sign in to comment.