fix typings

Polymer · Feb 21, 2018 · 8f8135b · 8f8135b
1 parent 7e74e36
commit 8f8135b
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 8 deletions.
diff --git a/externs/closure-types.js b/externs/closure-types.js
@@ -1377,7 +1377,7 @@ Polymer_ArraySelectorMixin.prototype.select = function(item){};
 Polymer_ArraySelectorMixin.prototype.selectIndex = function(idx){};
 /**
 * @interface
-* @extends {Polymer_PropertiesChanged}
+* @extends {Polymer_ElementMixin}
 */
 function Polymer_DisableUpgradeMixin(){}
 /**

diff --git a/lib/elements/dom-if.html b/lib/elements/dom-if.html
@@ -179,7 +179,7 @@
       // Guard against element being detached while render was queued
       if (parentNode) {
         if (!this.__ctor) {
-          let template = this.querySelector('template');
+          let template = /** @type {HTMLTemplateElement} */(this.querySelector('template'));
           if (!template) {
             // Wait until childList changes and template should be there by then
             let observer = new MutationObserver(() => {

diff --git a/lib/elements/dom-repeat.html b/lib/elements/dom-repeat.html
@@ -335,7 +335,7 @@
       // until ready, since won't have its template content handed back to
       // it until then
       if (!this.__ctor) {
-        let template = this.template = this.querySelector('template');
+        let template = this.template = /** @type {HTMLTemplateElement} */(this.querySelector('template'));
         if (!template) {
           // // Wait until childList changes and template should be there by then
           let observer = new MutationObserver(() => {

diff --git a/lib/mixins/disable-upgrade-mixin.html b/lib/mixins/disable-upgrade-mixin.html
@@ -35,17 +35,17 @@
    *
    * @mixinFunction
    * @polymer
-   * @appliesMixin Polymer.PropertiesChanged
+   * @appliesMixin Polymer.ElementMixin
    * @memberof Polymer
    */
   Polymer.DisableUpgradeMixin = Polymer.dedupingMixin((base) => {
 
     /**
      * @constructor
      * @extends {base}
-     * @implements {Polymer_PropertiesMixin}
+     * @implements {Polymer_ElementMixin}
      */
-    const superClass = Polymer.PropertiesMixin(base);
+    const superClass = Polymer.ElementMixin(base);
     /**
      * @polymer
      * @mixinClass

diff --git a/lib/mixins/properties-changed.html b/lib/mixins/properties-changed.html
@@ -355,7 +355,7 @@
          * @return {boolean} true if changedProps is truthy
          */
         _shouldPropertiesChange(currentProps, changedProps, oldProps) { // eslint-disable-line no-unused-vars
-          return changedProps;
+          return Boolean(changedProps);
         }
 
         /**

diff --git a/types/lib/mixins/disable-upgrade-mixin.d.ts b/types/lib/mixins/disable-upgrade-mixin.d.ts
@@ -31,7 +31,7 @@ declare namespace Polymer {
    *
    *     MyClass = Polymer.DisableUpgradeMixin(class extends BaseClass {...});
    */
-  function DisableUpgradeMixin<T extends new (...args: any[]) => {}>(base: T): T & DisableUpgradeMixinConstructor & Polymer.PropertiesChangedConstructor;
+  function DisableUpgradeMixin<T extends new (...args: any[]) => {}>(base: T): T & DisableUpgradeMixinConstructor & Polymer.ElementMixinConstructor & Polymer.PropertyEffectsConstructor & Polymer.TemplateStampConstructor & Polymer.PropertyAccessorsConstructor & Polymer.PropertiesChangedConstructor & Polymer.PropertiesMixinConstructor;
 
   interface DisableUpgradeMixinConstructor {
     new(...args: any[]): DisableUpgradeMixin;