Simplify code for <dom-repeat>'s sort and filter properties

Polymer · Jan 25, 2018 · 88cca86 · 88cca86
1 parent 49eb17b
commit 88cca86
Showing 1 changed file with 14 additions and 12 deletions.
diff --git a/lib/elements/dom-repeat.html b/lib/elements/dom-repeat.html
@@ -392,22 +392,24 @@
       return this.__dataHost._methodHost || this.__dataHost;
     }
 
-    __sortChanged(sort) {
-      let methodHost = this.__getMethodHost();
-      this.__sortFn = sort && (typeof sort == 'function' ? sort :
-        function() { return methodHost[sort].apply(methodHost, arguments); });
-      if (this.items) {
-        this.__debounceRender(this.__render);
+    __functionFromPropertyValue(functionOrMethodName) {
+      if (typeof functionOrMethodName === 'string') {
+        let methodName = functionOrMethodName;
+        let obj = this.__getMethodHost();
+        return function() { return obj[methodName].apply(obj, arguments); };
       }
+
+      return functionOrMethodName;
+    }
+
+    __sortChanged(sort) {
+      this.__sortFn = this.__functionFromPropertyValue(sort);
+      if (this.items) { this.__debounceRender(this.__render); }
     }
 
     __filterChanged(filter) {
-      let methodHost = this.__getMethodHost();
-      this.__filterFn = filter && (typeof filter == 'function' ? filter :
-        function() { return methodHost[filter].apply(methodHost, arguments); });
-      if (this.items) {
-        this.__debounceRender(this.__render);
-      }
+      this.__filterFn = this.__functionFromPropertyValue(filter);
+      if (this.items) { this.__debounceRender(this.__render); }
     }
 
     __computeFrameTime(rate) {