Skip to content

Commit

Permalink
Revert optimization to not wrap change notifications.
Browse files Browse the repository at this point in the history
This was causing a number of rendering tests to fail. Needs investigation, but possibly because wrapping calls ShadyDOM.flush, and this alters distribution timing which some tests may have inadvertently relied on.
  • Loading branch information
kevinpschaaf committed Sep 20, 2019
1 parent d64ee9e commit 848e8c9
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions lib/mixins/property-effects.js
Original file line number Diff line number Diff line change
Expand Up @@ -320,8 +320,7 @@ function dispatchNotifyEvent(inst, eventName, value, path) {
if (path) {
detail.path = path;
}
// Note, since this does not bubble, it should not need to be wrapped.
inst.dispatchEvent(new CustomEvent(eventName, { detail }));
wrap(/** @type {!HTMLElement} */(inst)).dispatchEvent(new CustomEvent(eventName, { detail }));
}

/**
Expand Down

0 comments on commit 848e8c9

Please sign in to comment.