Skip to content

Commit

Permalink
Add @Suppress annotations for missing property checks.
Browse files Browse the repository at this point in the history
Upstream of cl/228620162
  • Loading branch information
aomarks committed Jan 10, 2019
1 parent ccc9380 commit 7f2d736
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 3 deletions.
3 changes: 2 additions & 1 deletion lib/legacy/legacy-element-mixin.js
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,8 @@ export const LegacyElementMixin = dedupingMixin((base) => {
* @param {HTMLTemplateElement} template HTML template element to instance.
* @return {!DocumentFragment} Document fragment containing the imported
* template content.
*/
* @suppress {missingProperties} go/missingfnprops
*/
instanceTemplate(template) {
let content = this.constructor._contentForTemplate(template);
let dom = /** @type {!DocumentFragment} */
Expand Down
5 changes: 4 additions & 1 deletion lib/mixins/disable-upgrade-mixin.js
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,10 @@ export const DisableUpgradeMixin = dedupingMixin((base) => {
*/
class DisableUpgradeClass extends superClass {

/** @override */
/**
* @override
* @suppress {missingProperties} go/missingfnprops
*/
static get observedAttributes() {
return super.observedAttributes.concat(DISABLED_ATTR);
}
Expand Down
2 changes: 1 addition & 1 deletion lib/mixins/element-mixin.js
Original file line number Diff line number Diff line change
Expand Up @@ -516,7 +516,7 @@ export const ElementMixin = dedupingMixin(base => {
*
* @return {void}
* @override
* @suppress {invalidCasts}
* @suppress {invalidCasts,missingProperties} go/missingfnprops
*/
_initializeProperties() {
this.constructor.finalize();
Expand Down
2 changes: 2 additions & 0 deletions lib/mixins/property-effects.js
Original file line number Diff line number Diff line change
Expand Up @@ -2088,6 +2088,7 @@ export const PropertyEffects = dedupingMixin(superClass => {
* @param {string} property Property name
* @return {void}
* @protected
* @suppress {missingProperties} go/missingfnprops
*/
_createReflectedProperty(property) {
let attr = this.constructor.attributeNameForProperty(property);
Expand Down Expand Up @@ -2348,6 +2349,7 @@ export const PropertyEffects = dedupingMixin(superClass => {
* @return {!TemplateInfo} Template metadata object; for `runtimeBinding`,
* this is an instance of the prototypical template info
* @protected
* @suppress {missingProperties} go/missingfnprops
*/
_bindTemplate(template, instanceBinding) {
let templateInfo = this.constructor._parseTemplate(template);
Expand Down

0 comments on commit 7f2d736

Please sign in to comment.